Re: [FFmpeg-devel] [PATCH 3/3] configure: Disable automatic image base calculation
On Sun, Sep 27, 2015 at 04:59:25PM +0200, Hendrik Leppkes wrote: > On Mon, Sep 21, 2015 at 6:41 AM, Alex Smith wrote: > > From: Alex Smith > > > > There's no reason for it. ASLR will rebase it regardless so "preventing > > collisions" isn't really relevant. This also brings it in line with > > what a msvc produced dll will have (an image base of 0x1000). > > > > Signed-off-by: Alex Smith > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 0c60c03..a540ae7 100755 > > --- a/configure > > +++ b/configure > > @@ -4386,7 +4386,7 @@ case $target_os in > > SLIB_INSTALL_LINKS= > > SLIB_INSTALL_EXTRA_SHLIB='$(SLIBNAME:$(SLIBSUF)=.lib)' > > SLIB_INSTALL_EXTRA_LIB='lib$(SLIBNAME:$(SLIBSUF)=.dll.a) > > $(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.def)' > > -SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.orig.def) > > -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) > > -Wl,--enable-runtime-pseudo-reloc -Wl,--enable-auto-image-base' > > +SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.orig.def) > > -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) > > -Wl,--enable-runtime-pseudo-reloc -Wl,--disable-auto-image-base' > > objformat="win32" > > ranlib=: > > enable dos_paths > > -- > > 1.9.5.msysgit.0 > > LGTM, as it matches msvc afterwards. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/3] configure: Disable automatic image base calculation
On Mon, Sep 21, 2015 at 6:41 AM, Alex Smith wrote: > From: Alex Smith > > There's no reason for it. ASLR will rebase it regardless so "preventing > collisions" isn't really relevant. This also brings it in line with > what a msvc produced dll will have (an image base of 0x1000). > > Signed-off-by: Alex Smith > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 0c60c03..a540ae7 100755 > --- a/configure > +++ b/configure > @@ -4386,7 +4386,7 @@ case $target_os in > SLIB_INSTALL_LINKS= > SLIB_INSTALL_EXTRA_SHLIB='$(SLIBNAME:$(SLIBSUF)=.lib)' > SLIB_INSTALL_EXTRA_LIB='lib$(SLIBNAME:$(SLIBSUF)=.dll.a) > $(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.def)' > -SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.orig.def) > -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) > -Wl,--enable-runtime-pseudo-reloc -Wl,--enable-auto-image-base' > +SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.orig.def) > -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) > -Wl,--enable-runtime-pseudo-reloc -Wl,--disable-auto-image-base' > objformat="win32" > ranlib=: > enable dos_paths > -- > 1.9.5.msysgit.0 LGTM, as it matches msvc afterwards. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 3/3] configure: Disable automatic image base calculation
From: Alex Smith There's no reason for it. ASLR will rebase it regardless so "preventing collisions" isn't really relevant. This also brings it in line with what a msvc produced dll will have (an image base of 0x1000). Signed-off-by: Alex Smith --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0c60c03..a540ae7 100755 --- a/configure +++ b/configure @@ -4386,7 +4386,7 @@ case $target_os in SLIB_INSTALL_LINKS= SLIB_INSTALL_EXTRA_SHLIB='$(SLIBNAME:$(SLIBSUF)=.lib)' SLIB_INSTALL_EXTRA_LIB='lib$(SLIBNAME:$(SLIBSUF)=.dll.a) $(SLIBNAME_WITH_MAJOR:$(SLIBSUF)=.def)' -SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.orig.def) -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) -Wl,--enable-runtime-pseudo-reloc -Wl,--enable-auto-image-base' +SHFLAGS='-shared -Wl,--output-def,$$(@:$(SLIBSUF)=.orig.def) -Wl,--out-implib,$(SUBDIR)lib$(SLIBNAME:$(SLIBSUF)=.dll.a) -Wl,--enable-runtime-pseudo-reloc -Wl,--disable-auto-image-base' objformat="win32" ranlib=: enable dos_paths -- 1.9.5.msysgit.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
