Re: [FFmpeg-devel] [PATCH 3/4] avformat/oggenc: make Vorbis audio the only default for ogg muxer

2016-07-12 Thread Michael Niedermayer 
On Fri, Jul 08, 2016 at 12:08:14PM -0300, James Almer wrote:
> On 7/8/2016 4:22 AM, Michael Niedermayer wrote:
> > On Thu, Jul 07, 2016 at 11:02:30PM -0300, James Almer wrote:
> >> On 7/7/2016 10:55 PM, Michael Niedermayer wrote:
> >>> On Wed, Jul 06, 2016 at 08:25:26PM -0300, James Almer wrote:
>  While not enforced, RFC 5334 mentions that the .ogg extension should
>  be used for Vorbis audio files only.
> 
>  Signed-off-by: James Almer 
>  ---
>  This patch turns the ogg muxer into an audio only muxer to follow
>  the RFC's recommendation. The next patch in the set adds a new ogv
>  muxer to properly deal with video files.
> 
>  I doubt anyone out there tries to mux theora video using the .ogg
>  extension (even ffmpeg2theora seems to default to .ogv), so it's
>  unlikely it will affect people's normal workflow.
>  But if someone is against it then this patch can either be dropped
>  or changed to only remove flac from the defaults. That way video
>  can still be muxed.
> 
>  I personally prefer to apply this patch as is, though.
> 
>   libavformat/oggenc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> >>>
> >>> breaks fate
> >>
> >> Yes, forgot to run fate for this set. It's caused by the fact the ogg
> >> muxer can't mux video streams anymore after this patch.
> >>
> >> I want to know if the actual change is acceptable first, then I'll
> >> resend the set with fate tests updated to use ogv muxer and similar
> >> changes.
> > 
> > making it impossible to mux video into .ogg seems a bit strange and
> > unexpected to me. Thats just my personal oppinion, iam not blocking
> > this ...
> 
> My intention is to remove the default behavior of trying to mux video
> into .ogg extension files, which as the RFC states is meant for Vorbis
> audio. Any combination of Video + Audio and/or Subtitles is meant to
> use the .ogv extension and video/ogg mimetype.
> 

> I couldn't find a way to remove that default behavior that doesn't
> forbid muxing video when using the Ogg Muxer altogether. If you know
> how then I'm happy to use it because my objective is not to remove
> functionality to the muxer, even if said funcionality will be
> available in the Ogv muxer, but to make sure it doesn't mux content it
> ideally shouldn't unless explicitly told.
> Ogg, Oga, Speex, Opus and now Ogv are all aliases to the same
> underlying muxer after all.

ff_ogg_muxer should implement query_codec()
this could through avformat_query_codec() check if a specific video
codec is supported

ffmpeg would probably need to be modified to check this
i think its around line 2050 in ffmpeg_opt.c
dont know if thats the only change needed


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avformat/oggenc: make Vorbis audio the only default for ogg muxer

2016-07-08 Thread James Almer 
On 7/8/2016 4:22 AM, Michael Niedermayer wrote:
> On Thu, Jul 07, 2016 at 11:02:30PM -0300, James Almer wrote:
>> On 7/7/2016 10:55 PM, Michael Niedermayer wrote:
>>> On Wed, Jul 06, 2016 at 08:25:26PM -0300, James Almer wrote:
 While not enforced, RFC 5334 mentions that the .ogg extension should
 be used for Vorbis audio files only.

 Signed-off-by: James Almer 
 ---
 This patch turns the ogg muxer into an audio only muxer to follow
 the RFC's recommendation. The next patch in the set adds a new ogv
 muxer to properly deal with video files.

 I doubt anyone out there tries to mux theora video using the .ogg
 extension (even ffmpeg2theora seems to default to .ogv), so it's
 unlikely it will affect people's normal workflow.
 But if someone is against it then this patch can either be dropped
 or changed to only remove flac from the defaults. That way video
 can still be muxed.

 I personally prefer to apply this patch as is, though.

  libavformat/oggenc.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> breaks fate
>>
>> Yes, forgot to run fate for this set. It's caused by the fact the ogg
>> muxer can't mux video streams anymore after this patch.
>>
>> I want to know if the actual change is acceptable first, then I'll
>> resend the set with fate tests updated to use ogv muxer and similar
>> changes.
> 
> making it impossible to mux video into .ogg seems a bit strange and
> unexpected to me. Thats just my personal oppinion, iam not blocking
> this ...

My intention is to remove the default behavior of trying to mux video
into .ogg extension files, which as the RFC states is meant for Vorbis
audio. Any combination of Video + Audio and/or Subtitles is meant to
use the .ogv extension and video/ogg mimetype.

I couldn't find a way to remove that default behavior that doesn't
forbid muxing video when using the Ogg Muxer altogether. If you know
how then I'm happy to use it because my objective is not to remove
functionality to the muxer, even if said funcionality will be
available in the Ogv muxer, but to make sure it doesn't mux content it
ideally shouldn't unless explicitly told.
Ogg, Oga, Speex, Opus and now Ogv are all aliases to the same
underlying muxer after all.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avformat/oggenc: make Vorbis audio the only default for ogg muxer

2016-07-08 Thread Michael Niedermayer 
On Thu, Jul 07, 2016 at 11:02:30PM -0300, James Almer wrote:
> On 7/7/2016 10:55 PM, Michael Niedermayer wrote:
> > On Wed, Jul 06, 2016 at 08:25:26PM -0300, James Almer wrote:
> >> While not enforced, RFC 5334 mentions that the .ogg extension should
> >> be used for Vorbis audio files only.
> >>
> >> Signed-off-by: James Almer 
> >> ---
> >> This patch turns the ogg muxer into an audio only muxer to follow
> >> the RFC's recommendation. The next patch in the set adds a new ogv
> >> muxer to properly deal with video files.
> >>
> >> I doubt anyone out there tries to mux theora video using the .ogg
> >> extension (even ffmpeg2theora seems to default to .ogv), so it's
> >> unlikely it will affect people's normal workflow.
> >> But if someone is against it then this patch can either be dropped
> >> or changed to only remove flac from the defaults. That way video
> >> can still be muxed.
> >>
> >> I personally prefer to apply this patch as is, though.
> >>
> >>  libavformat/oggenc.c | 4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > breaks fate
> 
> Yes, forgot to run fate for this set. It's caused by the fact the ogg
> muxer can't mux video streams anymore after this patch.
> 
> I want to know if the actual change is acceptable first, then I'll
> resend the set with fate tests updated to use ogv muxer and similar
> changes.

making it impossible to mux video into .ogg seems a bit strange and
unexpected to me. Thats just my personal oppinion, iam not blocking
this ...

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avformat/oggenc: make Vorbis audio the only default for ogg muxer

2016-07-07 Thread James Almer 
On 7/7/2016 10:55 PM, Michael Niedermayer wrote:
> On Wed, Jul 06, 2016 at 08:25:26PM -0300, James Almer wrote:
>> While not enforced, RFC 5334 mentions that the .ogg extension should
>> be used for Vorbis audio files only.
>>
>> Signed-off-by: James Almer 
>> ---
>> This patch turns the ogg muxer into an audio only muxer to follow
>> the RFC's recommendation. The next patch in the set adds a new ogv
>> muxer to properly deal with video files.
>>
>> I doubt anyone out there tries to mux theora video using the .ogg
>> extension (even ffmpeg2theora seems to default to .ogv), so it's
>> unlikely it will affect people's normal workflow.
>> But if someone is against it then this patch can either be dropped
>> or changed to only remove flac from the defaults. That way video
>> can still be muxed.
>>
>> I personally prefer to apply this patch as is, though.
>>
>>  libavformat/oggenc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> breaks fate

Yes, forgot to run fate for this set. It's caused by the fact the ogg
muxer can't mux video streams anymore after this patch.

I want to know if the actual change is acceptable first, then I'll
resend the set with fate tests updated to use ogv muxer and similar
changes.

> 
> --- ./tests/ref/lavf-fate/ogg_vp3   2016-07-04 23:15:26.551386870 +0200
> +++ tests/data/fate/lavf-fate-ogg_vp3   2016-07-08 03:51:46.269196793 +0200
> @@ -1,3 +0,0 @@
> -4bd51dac3194fa88ae33767c25b4b1e6 *./tests/data/lavf-fate/lavf.ogg
> -417621 ./tests/data/lavf-fate/lavf.ogg
> -./tests/data/lavf-fate/lavf.ogg CRC=0x037e3e79
> Test lavf-fate-ogg_vp3 failed. Look at tests/data/fate/lavf-fate-ogg_vp3.err 
> for details.
> make: *** [fate-lavf-fate-ogg_vp3] Error 1
> make: *** Waiting for unfinished jobs
> 
> [...]
> 
> 
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avformat/oggenc: make Vorbis audio the only default for ogg muxer

2016-07-07 Thread Michael Niedermayer 
On Wed, Jul 06, 2016 at 08:25:26PM -0300, James Almer wrote:
> While not enforced, RFC 5334 mentions that the .ogg extension should
> be used for Vorbis audio files only.
> 
> Signed-off-by: James Almer 
> ---
> This patch turns the ogg muxer into an audio only muxer to follow
> the RFC's recommendation. The next patch in the set adds a new ogv
> muxer to properly deal with video files.
> 
> I doubt anyone out there tries to mux theora video using the .ogg
> extension (even ffmpeg2theora seems to default to .ogv), so it's
> unlikely it will affect people's normal workflow.
> But if someone is against it then this patch can either be dropped
> or changed to only remove flac from the defaults. That way video
> can still be muxed.
> 
> I personally prefer to apply this patch as is, though.
> 
>  libavformat/oggenc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

breaks fate

--- ./tests/ref/lavf-fate/ogg_vp3   2016-07-04 23:15:26.551386870 +0200
+++ tests/data/fate/lavf-fate-ogg_vp3   2016-07-08 03:51:46.269196793 +0200
@@ -1,3 +0,0 @@
-4bd51dac3194fa88ae33767c25b4b1e6 *./tests/data/lavf-fate/lavf.ogg
-417621 ./tests/data/lavf-fate/lavf.ogg
-./tests/data/lavf-fate/lavf.ogg CRC=0x037e3e79
Test lavf-fate-ogg_vp3 failed. Look at tests/data/fate/lavf-fate-ogg_vp3.err 
for details.
make: *** [fate-lavf-fate-ogg_vp3] Error 1
make: *** Waiting for unfinished jobs

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/4] avformat/oggenc: make Vorbis audio the only default for ogg muxer

2016-07-06 Thread James Almer 
While not enforced, RFC 5334 mentions that the .ogg extension should
be used for Vorbis audio files only.

Signed-off-by: James Almer 
---
This patch turns the ogg muxer into an audio only muxer to follow
the RFC's recommendation. The next patch in the set adds a new ogv
muxer to properly deal with video files.

I doubt anyone out there tries to mux theora video using the .ogg
extension (even ffmpeg2theora seems to default to .ogv), so it's
unlikely it will affect people's normal workflow.
But if someone is against it then this patch can either be dropped
or changed to only remove flac from the defaults. That way video
can still be muxed.

I personally prefer to apply this patch as is, though.

 libavformat/oggenc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c
index fee4c7f..2dcab15 100644
--- a/libavformat/oggenc.c
+++ b/libavformat/oggenc.c
@@ -669,9 +669,7 @@ AVOutputFormat ff_ogg_muxer = {
 #endif
  ,
 .priv_data_size= sizeof(OGGContext),
-.audio_codec   = CONFIG_LIBVORBIS_ENCODER ?
- AV_CODEC_ID_VORBIS : AV_CODEC_ID_FLAC,
-.video_codec   = AV_CODEC_ID_THEORA,
+.audio_codec   = AV_CODEC_ID_VORBIS,
 .write_header  = ogg_write_header,
 .write_packet  = ogg_write_packet,
 .write_trailer = ogg_write_trailer,
-- 
2.9.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel