Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-04 Thread Henrik Gramner 
On Mon, Aug 3, 2015 at 1:37 AM, Ronald S. Bultje  wrote:
> Does silencing these warnings still work after this patch?
>
> If so: ok.
>
> Ronald

Applied.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Henrik Gramner 
On Mon, Aug 3, 2015 at 1:37 AM, Ronald S. Bultje  wrote:
> Does silencing these warnings still work after this patch?

Yes, undefining __SECT__ is no longer needed after this patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Henrik Gramner 
On Mon, Aug 3, 2015 at 9:02 AM, Dave Yeo  wrote:
> Here, if the 32 is left as the alignment, the build dies.

That's why I removed the 32. It seems to run fine on Haswell (which
has AVX2) without it, so I don't know the reason for why it was added
in the first place.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Dave Yeo 

On 08/02/15 11:04 PM, Clément Bœsch wrote:

On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote:

The .text section is already 16-byte aligned by default on all supported
platforms so `SECTION_TEXT` isn't any different from `SECTION .text`.


naive question, what about the few SECTION_TEXT 32?

[...]


Here, if the 32 is left as the alignment, the build dies.
...
nasm -f aout  -DPREFIX -I./ -IK:/usr/local/src/ffmpeg// -Pconfig.asm -I 
K:/usr/local/src/ffmpeg/libavcodec/x86/ -o libavcodec/x86/hevc_idct.o 
K:/usr/local/src/ffmpeg/libavcodec/x86/hevc_idct.asm
K:/usr/local/src/ffmpeg/libavcodec/x86/hevc_idct.asm:24: error: segment 
name `.text 32' not recognized

make: *** [libavcodec/x86/hevc_idct.o] Error 1

My builds have been dropping the 32 without problems but that is on a 32 
bit platform without AVX.

Dave
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Henrik Gramner 
On Mon, Aug 3, 2015 at 8:04 AM, Clément Bœsch  wrote:
> naive question, what about the few SECTION_TEXT 32?
I don't know why 32-byte alignment was used for the text section in
the first place. Functions are only 16-byte aligned anyway.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Clément Bœsch 
On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote:
> The .text section is already 16-byte aligned by default on all supported
> platforms so `SECTION_TEXT` isn't any different from `SECTION .text`.

naive question, what about the few SECTION_TEXT 32?

[...]

-- 
Clément B.


pgpiCW7CJ2oX1.pgp
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Ronald S. Bultje 
Hi,

On Sun, Aug 2, 2015 at 4:40 PM, Henrik Gramner  wrote:

> The .text section is already 16-byte aligned by default on all supported
> platforms so `SECTION_TEXT` isn't any different from `SECTION .text`.-;
> Overrides the default .text section.
> -; Silences warnings when defining structures.
> -%define __SECT__
> -


Does silencing these warnings still work after this patch?

If so: ok.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Henrik Gramner 
The .text section is already 16-byte aligned by default on all supported
platforms so `SECTION_TEXT` isn't any different from `SECTION .text`.
---
 libavcodec/x86/aacpsdsp.asm  |  2 +-
 libavcodec/x86/audiodsp.asm  |  2 +-
 libavcodec/x86/blockdsp.asm  |  2 +-
 libavcodec/x86/bswapdsp.asm  |  2 +-
 libavcodec/x86/dcadsp.asm|  2 +-
 libavcodec/x86/dct32.asm |  2 +-
 libavcodec/x86/fft.asm   |  2 +-
 libavcodec/x86/flac_dsp_gpl.asm  |  2 +-
 libavcodec/x86/fmtconvert.asm|  2 +-
 libavcodec/x86/g722dsp.asm   |  2 +-
 libavcodec/x86/h263_loopfilter.asm   |  2 +-
 libavcodec/x86/hevc_idct.asm |  2 +-
 libavcodec/x86/hevc_mc.asm   |  3 ++-
 libavcodec/x86/hevc_sao.asm  |  2 +-
 libavcodec/x86/hpeldsp.asm   |  2 +-
 libavcodec/x86/huffyuvdsp.asm|  2 +-
 libavcodec/x86/idctdsp.asm   |  2 +-
 libavcodec/x86/imdct36.asm   |  2 +-
 libavcodec/x86/lossless_audiodsp.asm |  2 +-
 libavcodec/x86/lossless_videodsp.asm |  2 +-
 libavcodec/x86/mlpdsp.asm|  2 +-
 libavcodec/x86/pngdsp.asm|  2 +-
 libavcodec/x86/qpeldsp.asm   |  2 +-
 libavcodec/x86/sbrdsp.asm|  2 +-
 libavcodec/x86/svq1enc.asm   |  2 +-
 libavfilter/x86/af_volume.asm|  2 +-
 libavfilter/x86/vf_idet.asm  |  2 +-
 libavfilter/x86/vf_pullup.asm|  2 +-
 libavfilter/x86/vf_removegrain.asm   |  2 +-
 libavresample/x86/audio_convert.asm  |  2 +-
 libavresample/x86/audio_mix.asm  |  2 +-
 libavresample/x86/dither.asm |  2 +-
 libavutil/x86/pixelutils.asm |  2 +-
 libavutil/x86/x86inc.asm | 12 
 34 files changed, 34 insertions(+), 45 deletions(-)

diff --git a/libavcodec/x86/aacpsdsp.asm b/libavcodec/x86/aacpsdsp.asm
index d4dfd5b..d1187df 100644
--- a/libavcodec/x86/aacpsdsp.asm
+++ b/libavcodec/x86/aacpsdsp.asm
@@ -26,7 +26,7 @@ SECTION_RODATA
 
 ps_p1m1p1m1: dd 0, 0x8000, 0, 0x8000
 
-SECTION_TEXT
+SECTION .text
 
 ;*
 ;void ff_ps_add_squares_(float *dst, const float (*src)[2], int n);
diff --git a/libavcodec/x86/audiodsp.asm b/libavcodec/x86/audiodsp.asm
index 273b9ef..3ffb27f 100644
--- a/libavcodec/x86/audiodsp.asm
+++ b/libavcodec/x86/audiodsp.asm
@@ -21,7 +21,7 @@
 
 %include "libavutil/x86/x86util.asm"
 
-SECTION_TEXT
+SECTION .text
 
 %macro SCALARPRODUCT 0
 ; int ff_scalarproduct_int16(int16_t *v1, int16_t *v2, int order)
diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm
index af2b0de..7cbfa3a 100644
--- a/libavcodec/x86/blockdsp.asm
+++ b/libavcodec/x86/blockdsp.asm
@@ -23,7 +23,7 @@
 
 %include "libavutil/x86/x86util.asm"
 
-SECTION_TEXT
+SECTION .text
 
 ;
 ; void ff_clear_block(int16_t *blocks);
diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm
index b2d749c..56d8083 100644
--- a/libavcodec/x86/bswapdsp.asm
+++ b/libavcodec/x86/bswapdsp.asm
@@ -28,7 +28,7 @@ pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 
13, 12
 
 cextern pb_80
 
-SECTION_TEXT
+SECTION .text
 
 ; %1 = aligned/unaligned
 %macro BSWAP_LOOPS  1
diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm
index 030b4d4..548cec1 100644
--- a/libavcodec/x86/dcadsp.asm
+++ b/libavcodec/x86/dcadsp.asm
@@ -24,7 +24,7 @@
 SECTION_RODATA
 pf_inv16:  times 4 dd 0x3D80 ; 1/16
 
-SECTION_TEXT
+SECTION .text
 
 ; void decode_hf(float dst[DCA_SUBBANDS][8], const int32_t 
vq_num[DCA_SUBBANDS],
 ;const int8_t hf_vq[1024][32], intptr_t vq_offset,
diff --git a/libavcodec/x86/dct32.asm b/libavcodec/x86/dct32.asm
index 3e37812..4e657b5 100644
--- a/libavcodec/x86/dct32.asm
+++ b/libavcodec/x86/dct32.asm
@@ -191,7 +191,7 @@ ps_p1p1m1m1: dd 0, 0, 0x8000, 0x8000, 0, 0, 
0x8000, 0x8000
 %endmacro
 
 INIT_YMM avx
-SECTION_TEXT
+SECTION .text
 %if HAVE_AVX_EXTERNAL
 ; void ff_dct32_float_avx(FFTSample *out, const FFTSample *in)
 cglobal dct32_float, 2,3,8, out, in, tmp
diff --git a/libavcodec/x86/fft.asm b/libavcodec/x86/fft.asm
index f233774..22d9866 100644
--- a/libavcodec/x86/fft.asm
+++ b/libavcodec/x86/fft.asm
@@ -90,7 +90,7 @@ cextern cos_ %+ i
 %1
 %endmacro
 
-SECTION_TEXT
+SECTION .text
 
 %macro T2_3DNOW 4 ; z0, z1, mem0, mem1
 mova %1, %3
diff --git a/libavcodec/x86/flac_dsp_gpl.asm b/libavcodec/x86/flac_dsp_gpl.asm
index cedf083..e285158 100644
--- a/libavcodec/x86/flac_dsp_gpl.asm
+++ b/libavcodec/x86/flac_dsp_gpl.asm
@@ -22,7 +22,7 @@
 
 %include "libavutil/x86/x86util.asm"
 
-SECTION_TEXT
+SECTION .text
 
 INIT_XMM sse4
 %if ARCH_X86_64
diff --git a/libavcodec/x86/fmtconvert.asm b/libavcodec/x86/fmtconvert.asm
index f4fc0c2..20d8315 100644
--- a/libavcodec/x86/fmtconvert.asm
+++ b/libavcodec/x86/fmtconvert.asm
@@ -21,7 +21,7 @@
 
 %include "libavutil/x86/x86util.asm"
 
-SECTION_TEXT
+SECTION .text
 
 ;---