Re: [FFmpeg-devel] [PATCH 32/40] avcodec/dsicinvideo: Remove redundant code for freeing

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:39AM +0200, Andreas Rheinhardt wrote:
> The dsicinvideo decoder already has the FF_CODEC_CAP_INIT_CLEANUP flag
> set, so it is unnecessary to directly clean up some already allocated
> buffers in case another one could not be allocated in the init function,
> as all buffers will be freed anyway later in the decoder's close
> function.
> 
> Signed-off-by: Andreas Rheinhardt 
> ---
>  libavcodec/dsicinvideo.c | 1 -
>  1 file changed, 1 deletion(-)
> 

probably ok
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 32/40] avcodec/dsicinvideo: Remove redundant code for freeing

2020-09-13 Thread Andreas Rheinhardt
The dsicinvideo decoder already has the FF_CODEC_CAP_INIT_CLEANUP flag
set, so it is unnecessary to directly clean up some already allocated
buffers in case another one could not be allocated in the init function,
as all buffers will be freed anyway later in the decoder's close
function.

Signed-off-by: Andreas Rheinhardt 
---
 libavcodec/dsicinvideo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavcodec/dsicinvideo.c b/libavcodec/dsicinvideo.c
index 7f74808e6d..52f660fb51 100644
--- a/libavcodec/dsicinvideo.c
+++ b/libavcodec/dsicinvideo.c
@@ -58,7 +58,6 @@ static av_cold int allocate_buffers(CinVideoContext *cin)
 cin->bitmap_table[i] = av_mallocz(cin->bitmap_size);
 if (!cin->bitmap_table[i]) {
 av_log(cin->avctx, AV_LOG_ERROR, "Can't allocate bitmap 
buffers.\n");
-destroy_buffers(cin);
 return AVERROR(ENOMEM);
 }
 }
-- 
2.25.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".