Re: [FFmpeg-devel] [PATCH 4/5] avformat/movenc: check the return value of avio_get_dyn_buf()

[Nicolas George]

lance.lmw...@gmail.com (12020-04-29):
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
>  libavformat/movenc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 32e8109268..1a97e7c883 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -5251,10 +5251,11 @@ static int mov_flush_fragment(AVFormatContext *s, int 
> force)
>  return 0;
>  }
>  
> -buf_size = avio_get_dyn_buf(mov->mdat_buf, &buf);
> +if ((buf_size = avio_get_dyn_buf(mov->mdat_buf, &buf)) > 0) {
>  avio_wb32(s->pb, buf_size + 8);
>  ffio_wfourcc(s->pb, "mdat");
>  avio_write(s->pb, buf, buf_size);
> +}
>  ffio_free_dyn_buf(&mov->mdat_buf);
>  
>  if (mov->flags & FF_MOV_FLAG_GLOBAL_SIDX)

This one seems broken like the other two.

Regards,

-- 
  Nicolas George


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 4/5] avformat/movenc: check the return value of avio_get_dyn_buf()

[lance . lmwang]

From: Limin Wang 

Signed-off-by: Limin Wang 
---
 libavformat/movenc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 32e8109268..1a97e7c883 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -5251,10 +5251,11 @@ static int mov_flush_fragment(AVFormatContext *s, int 
force)
 return 0;
 }
 
-buf_size = avio_get_dyn_buf(mov->mdat_buf, &buf);
+if ((buf_size = avio_get_dyn_buf(mov->mdat_buf, &buf)) > 0) {
 avio_wb32(s->pb, buf_size + 8);
 ffio_wfourcc(s->pb, "mdat");
 avio_write(s->pb, buf, buf_size);
+}
 ffio_free_dyn_buf(&mov->mdat_buf);
 
 if (mov->flags & FF_MOV_FLAG_GLOBAL_SIDX)
-- 
2.21.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".