Re: [FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop
On Wed, Apr 24, 2024 at 05:18:55AM +, Xiang, Haihao wrote: > On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote: > > Fixes: CID1517022 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > doc/examples/qsv_transcode.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c > > index a4440a3403f..8e843ddd84c 100644 > > --- a/doc/examples/qsv_transcode.c > > +++ b/doc/examples/qsv_transcode.c > > @@ -76,8 +76,7 @@ static int str_to_dict(char* optstr, AVDictionary **opt) > > if (value == NULL) > > return AVERROR(EINVAL); > > av_dict_set(opt, key, value, 0); > > - } while(key != NULL); > > - return 0; > > + } while(1); > > } > > > > static int dynamic_set_parameter(AVCodecContext *avctx) > > LGTM, thanks for catching & fixing this. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop
On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote: > Fixes: CID1517022 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > doc/examples/qsv_transcode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c > index a4440a3403f..8e843ddd84c 100644 > --- a/doc/examples/qsv_transcode.c > +++ b/doc/examples/qsv_transcode.c > @@ -76,8 +76,7 @@ static int str_to_dict(char* optstr, AVDictionary **opt) > if (value == NULL) > return AVERROR(EINVAL); > av_dict_set(opt, key, value, 0); > - } while(key != NULL); > - return 0; > + } while(1); > } > > static int dynamic_set_parameter(AVCodecContext *avctx) LGTM, thanks for catching & fixing this. - Haihao ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop
Fixes: CID1517022 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/qsv_transcode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c index a4440a3403f..8e843ddd84c 100644 --- a/doc/examples/qsv_transcode.c +++ b/doc/examples/qsv_transcode.c @@ -76,8 +76,7 @@ static int str_to_dict(char* optstr, AVDictionary **opt) if (value == NULL) return AVERROR(EINVAL); av_dict_set(opt, key, value, 0); -} while(key != NULL); -return 0; +} while(1); } static int dynamic_set_parameter(AVCodecContext *avctx) -- 2.43.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
