Re: [FFmpeg-devel] [PATCH 5/8] avformat/mxfdec: Clear metadata_sets_count in mxf_read_close()

2019-12-01 Thread Michael Niedermayer 
On Thu, Nov 07, 2019 at 06:04:04PM +0100, Michael Niedermayer wrote:
> On Wed, Nov 06, 2019 at 09:34:01PM +0100, Tomas Härdin wrote:
> > tor 2019-10-31 klockan 18:58 +0100 skrev Michael Niedermayer:
> > > This avoids problems if the function is called twice
> > > 
> > > Signed-off-by: Michael Niedermayer 
> > > ---
> > >  libavformat/mxfdec.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > > index f3b1b704f9..68a670154b 100644
> > > --- a/libavformat/mxfdec.c
> > > +++ b/libavformat/mxfdec.c
> > > @@ -3582,6 +3582,7 @@ static int mxf_read_close(AVFormatContext *s)
> > >  for (i = 0; i < mxf->metadata_sets_count; i++) {
> > >  mxf_free_metadataset(mxf->metadata_sets + i, 1);
> > >  }
> > > +mxf->metadata_sets_count = 0;
> > >  av_freep(>partitions);
> > >  av_freep(>metadata_sets);
> > >  av_freep(>aesc);
> > 
> > Looks OK, but I'd work out why close() is called twice
> 
> I dont think i saw a case where it was called twice, i just felt
> that its more robust to clear this

will apply

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mxfdec: Clear metadata_sets_count in mxf_read_close()

2019-11-07 Thread Michael Niedermayer 
On Wed, Nov 06, 2019 at 09:34:01PM +0100, Tomas Härdin wrote:
> tor 2019-10-31 klockan 18:58 +0100 skrev Michael Niedermayer:
> > This avoids problems if the function is called twice
> > 
> > Signed-off-by: Michael Niedermayer 
> > ---
> >  libavformat/mxfdec.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index f3b1b704f9..68a670154b 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -3582,6 +3582,7 @@ static int mxf_read_close(AVFormatContext *s)
> >  for (i = 0; i < mxf->metadata_sets_count; i++) {
> >  mxf_free_metadataset(mxf->metadata_sets + i, 1);
> >  }
> > +mxf->metadata_sets_count = 0;
> >  av_freep(>partitions);
> >  av_freep(>metadata_sets);
> >  av_freep(>aesc);
> 
> Looks OK, but I'd work out why close() is called twice

I dont think i saw a case where it was called twice, i just felt
that its more robust to clear this

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mxfdec: Clear metadata_sets_count in mxf_read_close()

2019-11-06 Thread Tomas Härdin 
tor 2019-10-31 klockan 18:58 +0100 skrev Michael Niedermayer:
> This avoids problems if the function is called twice
> 
> Signed-off-by: Michael Niedermayer 
> ---
>  libavformat/mxfdec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index f3b1b704f9..68a670154b 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -3582,6 +3582,7 @@ static int mxf_read_close(AVFormatContext *s)
>  for (i = 0; i < mxf->metadata_sets_count; i++) {
>  mxf_free_metadataset(mxf->metadata_sets + i, 1);
>  }
> +mxf->metadata_sets_count = 0;
>  av_freep(>partitions);
>  av_freep(>metadata_sets);
>  av_freep(>aesc);

Looks OK, but I'd work out why close() is called twice

/Tomas

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 5/8] avformat/mxfdec: Clear metadata_sets_count in mxf_read_close()

2019-10-31 Thread Michael Niedermayer 
This avoids problems if the function is called twice

Signed-off-by: Michael Niedermayer 
---
 libavformat/mxfdec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index f3b1b704f9..68a670154b 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -3582,6 +3582,7 @@ static int mxf_read_close(AVFormatContext *s)
 for (i = 0; i < mxf->metadata_sets_count; i++) {
 mxf_free_metadataset(mxf->metadata_sets + i, 1);
 }
+mxf->metadata_sets_count = 0;
 av_freep(>partitions);
 av_freep(>metadata_sets);
 av_freep(>aesc);
-- 
2.23.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".