Re: [FFmpeg-devel] [PATCH 6/6] avformat: add AVFMT_FLAG_FASTSEEK, use it for mp3

2015-04-22 Thread Nicolas George
Le tridi 3 floréal, an CCXXIII, wm4 a écrit :
  #define AVFMT_FLAG_KEEP_SIDE_DATA 0x4 /// Don't merge side data but 
 keep it separate.
 +#define AVFMT_FLAG_FAST_SEEK   0x8 /// Enable fast, but inaccurate 
 seeks for some formats

Better with the 0, but I suspect it needs a safety gap to avoid future
conflicts with the fork.

Regards,

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH 6/6] avformat: add AVFMT_FLAG_FASTSEEK, use it for mp3

2015-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 05:27:19PM +0200, wm4 wrote:
 On Wed, 22 Apr 2015 17:10:30 +0200
 Nicolas George geo...@nsup.org wrote:
 
  Le tridi 3 floréal, an CCXXIII, wm4 a écrit :
#define AVFMT_FLAG_KEEP_SIDE_DATA 0x4 /// Don't merge side data but 
   keep it separate.
   +#define AVFMT_FLAG_FAST_SEEK   0x8 /// Enable fast, but inaccurate 
   seeks for some formats
  
  Better with the 0, but I suspect it needs a safety gap to avoid future
  conflicts with the fork.
  
  Regards,
  
 
 AVFMT_FLAG_KEEP_SIDE_DATA already does not exist in Libav. (Mainly
 because the associated side-data inline mechanism is 100% insane
 and FFmpeg-only.)
 
 There's actually a gap after AVFMT_FLAG_BITEXACT, which is probably
 meant to avoid ABI issues if Libav adds something.

IIRC yes

and patch applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
conveniently.
New school: Use the highest level language in which the latest supercomputer
can solve the problem without the user falling asleep waiting.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel