Re: [FFmpeg-devel] [PATCH v1] MAINTAINERS: add myself to the general developers list

2020-04-29 Thread Michael Niedermayer
On Sun, Apr 26, 2020 at 06:50:09PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
> I have actively contributed to FFmpeg in the past year and should be familiar
> with the entire code base and the rules of the developers. Up to now, more 
> than
> one hundred patches have been accepted and pushed with the help of other 
> developers. However, some reviewed patches have not been pushed yet, so I am
> glad to request push access to the FFmpeg repository so that I can push them
> by the developer rules. I think being a committer is a duty, I prefer to 
> submit
> any patch to ML for review to avoid making mistakes.
> 
> Please the core team give comments or vote for my request.
> 
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)

Will apply

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] MAINTAINERS: add myself to the general developers list

2020-04-26 Thread Limin Wang
On Sun, Apr 26, 2020 at 11:44:32PM +0200, Marton Balint wrote:
> 
> 
> On Sun, 26 Apr 2020, lance.lmw...@gmail.com wrote:
> 
> >From: Limin Wang 
> >
> >Signed-off-by: Limin Wang 
> >---
> >I have actively contributed to FFmpeg in the past year and should be familiar
> >with the entire code base and the rules of the developers.
> 
> Then maybe could you omit v1 designators in the future? A patch
> without a version designator is usually the first version, or at
> least that is how most of the developers send patches, so I suggest
> you follow this as well.

Got it, I'm glad to learn for the rule. Maybe it's better to add the rule
to developer document to follow.

> 
> Thanks,
> Marton
> 
> >Up to now, more than
> >one hundred patches have been accepted and pushed with the help of
> >other developers. However, some reviewed patches have not been
> >pushed yet, so I am
> >glad to request push access to the FFmpeg repository so that I can push them
> >by the developer rules. I think being a committer is a duty, I prefer to 
> >submit
> >any patch to ML for review to avoid making mistakes.
> >
> >Please the core team give comments or vote for my request.
> >
> >MAINTAINERS | 1 +
> >1 file changed, 1 insertion(+)
> >
> >diff --git a/MAINTAINERS b/MAINTAINERS
> >index e19d1ee586..06956f8741 100644
> >--- a/MAINTAINERS
> >+++ b/MAINTAINERS
> >@@ -564,6 +564,7 @@ Joakim Plate
> >Jun Zhao
> >Kieran Kunhya
> >Kirill Gavrilov
> >+Limin Wang
> >Martin Storsjö
> >Panagiotis Issaris
> >Pedro Arthur
> >-- 
> >2.21.0
> >
> >___
> >ffmpeg-devel mailing list
> >ffmpeg-devel@ffmpeg.org
> >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >To unsubscribe, visit link above, or email
> >ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] MAINTAINERS: add myself to the general developers list

2020-04-26 Thread Marton Balint



On Sun, 26 Apr 2020, lance.lmw...@gmail.com wrote:


From: Limin Wang 

Signed-off-by: Limin Wang 
---
I have actively contributed to FFmpeg in the past year and should be familiar
with the entire code base and the rules of the developers.


Then maybe could you omit v1 designators in the future? A patch without a 
version designator is usually the first version, or at least that is how 
most of the developers send patches, so I suggest you follow this as well.


Thanks,
Marton


Up to now, more than
one hundred patches have been accepted and pushed with the help of other 
developers. However, some reviewed patches have not been pushed yet, so I am

glad to request push access to the FFmpeg repository so that I can push them
by the developer rules. I think being a committer is a duty, I prefer to submit
any patch to ML for review to avoid making mistakes.

Please the core team give comments or vote for my request.

MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e19d1ee586..06956f8741 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -564,6 +564,7 @@ Joakim Plate
Jun Zhao
Kieran Kunhya
Kirill Gavrilov
+Limin Wang
Martin Storsjö
Panagiotis Issaris
Pedro Arthur
--
2.21.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v1] MAINTAINERS: add myself to the general developers list

2020-04-26 Thread lance . lmwang
From: Limin Wang 

Signed-off-by: Limin Wang 
---
I have actively contributed to FFmpeg in the past year and should be familiar
with the entire code base and the rules of the developers. Up to now, more than
one hundred patches have been accepted and pushed with the help of other 
developers. However, some reviewed patches have not been pushed yet, so I am
glad to request push access to the FFmpeg repository so that I can push them
by the developer rules. I think being a committer is a duty, I prefer to submit
any patch to ML for review to avoid making mistakes.

Please the core team give comments or vote for my request.

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e19d1ee586..06956f8741 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -564,6 +564,7 @@ Joakim Plate
 Jun Zhao
 Kieran Kunhya
 Kirill Gavrilov
+Limin Wang
 Martin Storsjö
 Panagiotis Issaris
 Pedro Arthur
-- 
2.21.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".