[FFmpeg-devel] [PATCH v1] avfilter/vf_showinfo: fix the integer handling issues

[lance . lmwang]

From: Limin Wang 

Fixes CID 1457606 and 1457607
Signed-off-by: Limin Wang 

Signed-off-by: Limin Wang 
---
 libavfilter/vf_showinfo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 5fff123..79b79db 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -221,10 +221,10 @@ static void update_sample_stats_16(int be, const uint8_t 
*src, int len, int64_t
 for (i = 0; i < len / 2; i++) {
 if ((HAVE_BIGENDIAN && !be) || (!HAVE_BIGENDIAN && be)) {
 *sum += av_bswap16(src1[i]);
-*sum2 += av_bswap16(src1[i]) * av_bswap16(src1[i]);
+*sum2 += (uint32_t)av_bswap16(src1[i]) * 
(uint32_t)av_bswap16(src1[i]);
 } else {
 *sum += src1[i];
-*sum2 += src1[i] * src1[i];
+*sum2 += (uint32_t)src1[i] * (uint32_t)src1[i];
 }
 }
 }
-- 
2.9.5

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_showinfo: fix the integer handling issues

[Michael Niedermayer]

On Thu, Jan 09, 2020 at 09:02:11AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> Fixes CID 1457606 and 1457607
> Signed-off-by: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
>  libavfilter/vf_showinfo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".