Re: [FFmpeg-devel] [PATCH v2] api-h264-slice-test: fix arguments and help

[Michael Niedermayer]

On Sun, Jan 13, 2019 at 05:35:32PM +0100, Rafaël Carré wrote:
> This patch also changes the call to api-h264-slice-test.
> 
> v1 was done during a working day but was not requested by the direction.
> 
> v2 was done on sunday.
> 
> I think it's fair to say I was not paid for this, and to reassure you,
> both times I put a minimum amount of effort.

>  api/api-h264-slice-test.c |6 ++
>  fate/api.mak  |2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 717f5a27fa51be82fe490b57a57a5c64f1e4cf5e  
> 0001-api-h264-slice-test-fix-arguments-and-help.patch
> From 7a84425ea60b4f185b57b44fb2463033993c53f0 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rafa=C3=ABl=20Carr=C3=A9?= 
> Date: Thu, 10 Jan 2019 12:00:27 +0100
> Subject: [PATCH] api-h264-slice-test: fix arguments and help
> 

will apply

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH v2] api-h264-slice-test: fix arguments and help

[Rafaël Carré]

This patch also changes the call to api-h264-slice-test.

v1 was done during a working day but was not requested by the direction.

v2 was done on sunday.

I think it's fair to say I was not paid for this, and to reassure you,
both times I put a minimum amount of effort.
>From 7a84425ea60b4f185b57b44fb2463033993c53f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafa=C3=ABl=20Carr=C3=A9?= 
Date: Thu, 10 Jan 2019 12:00:27 +0100
Subject: [PATCH] api-h264-slice-test: fix arguments and help

This program only takes 2 arguments
Remove comment that was never right
---
 tests/api/api-h264-slice-test.c | 6 ++
 tests/fate/api.mak  | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/api/api-h264-slice-test.c b/tests/api/api-h264-slice-test.c
index b893737bca..dee93b8349 100644
--- a/tests/api/api-h264-slice-test.c
+++ b/tests/api/api-h264-slice-test.c
@@ -22,8 +22,6 @@
 
 #define MAX_SLICES 8
 
-// ./fate 2 ./crew_cif out.y4m
-
 #include "config.h"
 
 #include 
@@ -121,8 +119,8 @@ int main(int argc, char **argv)
 int nals = 0, ret = 0;
 char *p;
 
-if (argc < 4) {
-fprintf(stderr, "Usage: %s   \n", argv[0]);
+if (argc < 3) {
+fprintf(stderr, "Usage: %s  \n", argv[0]);
 return -1;
 }
 
diff --git a/tests/fate/api.mak b/tests/fate/api.mak
index 132c38f2c2..3714f900bd 100644
--- a/tests/fate/api.mak
+++ b/tests/fate/api.mak
@@ -14,7 +14,7 @@ fate-api-h264: CMD = run $(APITESTSDIR)/api-h264-test $(TARGET_SAMPLES)/h264-con
 
 FATE_API_SAMPLES_LIBAVFORMAT-$(call DEMDEC, H264, H264) += fate-api-h264-slice
 fate-api-h264-slice: $(APITESTSDIR)/api-h264-slice-test$(EXESUF)
-fate-api-h264-slice: CMD = run $(APITESTSDIR)/api-h264-slice-test 2 $(TARGET_SAMPLES)/h264/crew_cif.nal api-h264-slice.h264
+fate-api-h264-slice: CMD = run $(APITESTSDIR)/api-h264-slice-test 2 $(TARGET_SAMPLES)/h264/crew_cif.nal
 
 FATE_API_LIBAVFORMAT-$(call DEMDEC, FLV, FLV) += fate-api-seek
 fate-api-seek: $(APITESTSDIR)/api-seek-test$(EXESUF) fate-lavf-flv_fmt
-- 
2.19.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel