Re: [FFmpeg-devel] [PATCH v2] configure: Do not abort when cross-compiling to the native CPU
On Thu, Apr 2, 2020 at 5:38 PM Michael Niedermayer wrote: > On Wed, Apr 01, 2020 at 12:07:55AM -0400, David Michael wrote: > > Using a compiler with a different host triplet is considered > > cross-compiling, even when it is for the same architecture as the > > build system. With such a cross-compiler, it is still valid to > > optimize builds with --cpu=host. Make the condition that aborts in > > this case into a warning instead, since a cross-compiler for an > > incompatible architecture will fail with -mtune=native anyway. > > > > Signed-off-by: David Michael > > --- > > > > Changes since v1: > > * Use a warning instead of dropping the condition altogether > > > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > will apply Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2] configure: Do not abort when cross-compiling to the native CPU
On Wed, Apr 01, 2020 at 12:07:55AM -0400, David Michael wrote: > Using a compiler with a different host triplet is considered > cross-compiling, even when it is for the same architecture as the > build system. With such a cross-compiler, it is still valid to > optimize builds with --cpu=host. Make the condition that aborts in > this case into a warning instead, since a cross-compiler for an > incompatible architecture will fail with -mtune=native anyway. > > Signed-off-by: David Michael > --- > > Changes since v1: > * Use a warning instead of dropping the condition altogether > > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH v2] configure: Do not abort when cross-compiling to the native CPU
Using a compiler with a different host triplet is considered cross-compiling, even when it is for the same architecture as the build system. With such a cross-compiler, it is still valid to optimize builds with --cpu=host. Make the condition that aborts in this case into a warning instead, since a cross-compiler for an incompatible architecture will fail with -mtune=native anyway. Signed-off-by: David Michael --- Changes since v1: * Use a warning instead of dropping the condition altogether configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 21827eeb45..251b6a977a 100755 --- a/configure +++ b/configure @@ -4797,7 +4797,7 @@ fi if test "$cpu" = host; then enabled cross_compile && -die "--cpu=host makes no sense when cross-compiling." +warn "--cpu=host makes no sense when cross-compiling." case "$cc_type" in gcc|llvm_gcc) -- 2.21.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
