Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.
On 2019-09-02 20:10, Paul B Mahol wrote: On 9/2/19, Andrey Semashev wrote: Ping? I would like this to make it into 4.2 as well. Applied to master. Thanks. Could you also merge it to 4.2 branch? On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev wrote: The current code in libavfilter/af_sofalizer.c requires mysofa_neighborhood_init_withstepdefine function, which only appeared in libmysofa 0.7. Use this function in configure script to bail out early if a too old libmysofa is found in the system instead of failing at compile time. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 51dc77c780..0d06ea6a02 100755 --- a/configure +++ b/configure @@ -6237,8 +6237,8 @@ enabled libmfx&& { check_pkg_config libmfx libmfx "mfx/mfxvideo.h" M { require libmfx "mfx/mfxvideo.h" MFXInit "-llibmfx $advapi32_extralibs" && warn "using libmfx without pkg-config"; } } enabled libmodplug&& require_pkg_config libmodplug libmodplug libmodplug/modplug.h ModPlug_Load enabled libmp3lame&& require "libmp3lame >= 3.98.3" lame/lame.h lame_set_VBR_quality -lmp3lame $libm_extralibs -enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h mysofa_load || - require libmysofa mysofa.h mysofa_load -lmysofa $zlib_extralibs; } +enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h mysofa_neighborhood_init_withstepdefine || + require libmysofa mysofa.h mysofa_neighborhood_init_withstepdefine -lmysofa $zlib_extralibs; } enabled libnpp&& { check_lib libnpp npp.h nppGetLibVersion -lnppig -lnppicc -lnppc -lnppidei || check_lib libnpp npp.h nppGetLibVersion -lnppi -lnppc -lnppidei || die "ERROR: libnpp not found"; } -- 2.20.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.
On 9/2/19, Andrey Semashev wrote: > Ping? I would like this to make it into 4.2 as well. > Applied to master. > On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev > wrote: >> >> The current code in libavfilter/af_sofalizer.c requires >> mysofa_neighborhood_init_withstepdefine function, which only appeared >> in libmysofa 0.7. Use this function in configure script to bail out >> early if a too old libmysofa is found in the system instead of failing >> at compile time. >> --- >> configure | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 51dc77c780..0d06ea6a02 100755 >> --- a/configure >> +++ b/configure >> @@ -6237,8 +6237,8 @@ enabled libmfx&& { check_pkg_config >> libmfx libmfx "mfx/mfxvideo.h" M >> { require libmfx "mfx/mfxvideo.h" MFXInit >> "-llibmfx $advapi32_extralibs" && warn "using libmfx without pkg-config"; >> } } >> enabled libmodplug&& require_pkg_config libmodplug libmodplug >> libmodplug/modplug.h ModPlug_Load >> enabled libmp3lame&& require "libmp3lame >= 3.98.3" lame/lame.h >> lame_set_VBR_quality -lmp3lame $libm_extralibs >> -enabled libmysofa && { check_pkg_config libmysofa libmysofa >> mysofa.h mysofa_load || >> - require libmysofa mysofa.h mysofa_load >> -lmysofa $zlib_extralibs; } >> +enabled libmysofa && { check_pkg_config libmysofa libmysofa >> mysofa.h mysofa_neighborhood_init_withstepdefine || >> + require libmysofa mysofa.h >> mysofa_neighborhood_init_withstepdefine -lmysofa $zlib_extralibs; } >> enabled libnpp&& { check_lib libnpp npp.h nppGetLibVersion >> -lnppig -lnppicc -lnppc -lnppidei || >> check_lib libnpp npp.h nppGetLibVersion >> -lnppi -lnppc -lnppidei || >> die "ERROR: libnpp not found"; } >> -- >> 2.20.1 >> > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.
Ping? I would like this to make it into 4.2 as well. On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev wrote: > > The current code in libavfilter/af_sofalizer.c requires > mysofa_neighborhood_init_withstepdefine function, which only appeared > in libmysofa 0.7. Use this function in configure script to bail out > early if a too old libmysofa is found in the system instead of failing > at compile time. > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 51dc77c780..0d06ea6a02 100755 > --- a/configure > +++ b/configure > @@ -6237,8 +6237,8 @@ enabled libmfx&& { check_pkg_config libmfx > libmfx "mfx/mfxvideo.h" M > { require libmfx "mfx/mfxvideo.h" MFXInit > "-llibmfx $advapi32_extralibs" && warn "using libmfx without pkg-config"; } } > enabled libmodplug&& require_pkg_config libmodplug libmodplug > libmodplug/modplug.h ModPlug_Load > enabled libmp3lame&& require "libmp3lame >= 3.98.3" lame/lame.h > lame_set_VBR_quality -lmp3lame $libm_extralibs > -enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h > mysofa_load || > - require libmysofa mysofa.h mysofa_load > -lmysofa $zlib_extralibs; } > +enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h > mysofa_neighborhood_init_withstepdefine || > + require libmysofa mysofa.h > mysofa_neighborhood_init_withstepdefine -lmysofa $zlib_extralibs; } > enabled libnpp&& { check_lib libnpp npp.h nppGetLibVersion > -lnppig -lnppicc -lnppc -lnppidei || > check_lib libnpp npp.h nppGetLibVersion > -lnppi -lnppc -lnppidei || > die "ERROR: libnpp not found"; } > -- > 2.20.1 > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.
The current code in libavfilter/af_sofalizer.c requires mysofa_neighborhood_init_withstepdefine function, which only appeared in libmysofa 0.7. Use this function in configure script to bail out early if a too old libmysofa is found in the system instead of failing at compile time. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 51dc77c780..0d06ea6a02 100755 --- a/configure +++ b/configure @@ -6237,8 +6237,8 @@ enabled libmfx&& { check_pkg_config libmfx libmfx "mfx/mfxvideo.h" M { require libmfx "mfx/mfxvideo.h" MFXInit "-llibmfx $advapi32_extralibs" && warn "using libmfx without pkg-config"; } } enabled libmodplug&& require_pkg_config libmodplug libmodplug libmodplug/modplug.h ModPlug_Load enabled libmp3lame&& require "libmp3lame >= 3.98.3" lame/lame.h lame_set_VBR_quality -lmp3lame $libm_extralibs -enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h mysofa_load || - require libmysofa mysofa.h mysofa_load -lmysofa $zlib_extralibs; } +enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h mysofa_neighborhood_init_withstepdefine || + require libmysofa mysofa.h mysofa_neighborhood_init_withstepdefine -lmysofa $zlib_extralibs; } enabled libnpp&& { check_lib libnpp npp.h nppGetLibVersion -lnppig -lnppicc -lnppc -lnppidei || check_lib libnpp npp.h nppGetLibVersion -lnppi -lnppc -lnppidei || die "ERROR: libnpp not found"; } -- 2.20.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".