Re: [FFmpeg-devel] [PATCH v2 1/2] lavf/dump: use error log level for invalid size

2019-08-17 Thread Liu Steven 


> 在 2019年8月11日，下午4:41，Steven Liu  写道：
> 
> 
> 
>> 在 2019年8月10日，23:53，lance.lmw...@gmail.com 写道：
>> 
>> From: Limin Wang 
>> 
>> Signed-off-by: Limin Wang 
>> ---
>> libavformat/dump.c | 12 ++--
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>> 
>> diff --git a/libavformat/dump.c b/libavformat/dump.c
>> index 1c44656..68ce9a8 100644
>> --- a/libavformat/dump.c
>> +++ b/libavformat/dump.c
>> @@ -210,7 +210,7 @@ static void dump_paramchange(void *ctx, AVPacketSideData 
>> *sd)
>> 
>>return;
>> fail:
>> -av_log(ctx, AV_LOG_INFO, "unknown param");
>> +av_log(ctx, AV_LOG_ERROR, "unknown param");
>> }
>> 
>> /* replaygain side data*/
>> @@ -239,7 +239,7 @@ static void dump_replaygain(void *ctx, AVPacketSideData 
>> *sd)
>>AVReplayGain *rg;
>> 
>>if (sd->size < sizeof(*rg)) {
>> -av_log(ctx, AV_LOG_INFO, "invalid data");
>> +av_log(ctx, AV_LOG_ERROR, "invalid data");
>>return;
>>}
>>rg = (AVReplayGain*)sd->data;
>> @@ -255,7 +255,7 @@ static void dump_stereo3d(void *ctx, AVPacketSideData 
>> *sd)
>>AVStereo3D *stereo;
>> 
>>if (sd->size < sizeof(*stereo)) {
>> -av_log(ctx, AV_LOG_INFO, "invalid data");
>> +av_log(ctx, AV_LOG_ERROR, "invalid data");
>>return;
>>}
>> 
>> @@ -272,7 +272,7 @@ static void dump_audioservicetype(void *ctx, 
>> AVPacketSideData *sd)
>>enum AVAudioServiceType *ast = (enum AVAudioServiceType *)sd->data;
>> 
>>if (sd->size < sizeof(*ast)) {
>> -av_log(ctx, AV_LOG_INFO, "invalid data");
>> +av_log(ctx, AV_LOG_ERROR, "invalid data");
>>return;
>>}
>> 
>> @@ -315,7 +315,7 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
>>AVCPBProperties *cpb = (AVCPBProperties *)sd->data;
>> 
>>if (sd->size < sizeof(*cpb)) {
>> -av_log(ctx, AV_LOG_INFO, "invalid data");
>> +av_log(ctx, AV_LOG_ERROR, "invalid data");
>>return;
>>}
>> 
>> @@ -357,7 +357,7 @@ static void dump_spherical(void *ctx, AVCodecParameters 
>> *par, AVPacketSideData *
>>double yaw, pitch, roll;
>> 
>>if (sd->size < sizeof(*spherical)) {
>> -av_log(ctx, AV_LOG_INFO, "invalid data");
>> +av_log(ctx, AV_LOG_ERROR, "invalid data");
>>return;
>>}
>> 
>> -- 
>> 2.6.4
>> 
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> 
> lgtm

Pushed

Thanks
Steven

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf/dump: use error log level for invalid size

2019-08-11 Thread Steven Liu 


> 在 2019年8月10日，23:53，lance.lmw...@gmail.com 写道：
> 
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
> libavformat/dump.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index 1c44656..68ce9a8 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -210,7 +210,7 @@ static void dump_paramchange(void *ctx, AVPacketSideData 
> *sd)
> 
> return;
> fail:
> -av_log(ctx, AV_LOG_INFO, "unknown param");
> +av_log(ctx, AV_LOG_ERROR, "unknown param");
> }
> 
> /* replaygain side data*/
> @@ -239,7 +239,7 @@ static void dump_replaygain(void *ctx, AVPacketSideData 
> *sd)
> AVReplayGain *rg;
> 
> if (sd->size < sizeof(*rg)) {
> -av_log(ctx, AV_LOG_INFO, "invalid data");
> +av_log(ctx, AV_LOG_ERROR, "invalid data");
> return;
> }
> rg = (AVReplayGain*)sd->data;
> @@ -255,7 +255,7 @@ static void dump_stereo3d(void *ctx, AVPacketSideData *sd)
> AVStereo3D *stereo;
> 
> if (sd->size < sizeof(*stereo)) {
> -av_log(ctx, AV_LOG_INFO, "invalid data");
> +av_log(ctx, AV_LOG_ERROR, "invalid data");
> return;
> }
> 
> @@ -272,7 +272,7 @@ static void dump_audioservicetype(void *ctx, 
> AVPacketSideData *sd)
> enum AVAudioServiceType *ast = (enum AVAudioServiceType *)sd->data;
> 
> if (sd->size < sizeof(*ast)) {
> -av_log(ctx, AV_LOG_INFO, "invalid data");
> +av_log(ctx, AV_LOG_ERROR, "invalid data");
> return;
> }
> 
> @@ -315,7 +315,7 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
> AVCPBProperties *cpb = (AVCPBProperties *)sd->data;
> 
> if (sd->size < sizeof(*cpb)) {
> -av_log(ctx, AV_LOG_INFO, "invalid data");
> +av_log(ctx, AV_LOG_ERROR, "invalid data");
> return;
> }
> 
> @@ -357,7 +357,7 @@ static void dump_spherical(void *ctx, AVCodecParameters 
> *par, AVPacketSideData *
> double yaw, pitch, roll;
> 
> if (sd->size < sizeof(*spherical)) {
> -av_log(ctx, AV_LOG_INFO, "invalid data");
> +av_log(ctx, AV_LOG_ERROR, "invalid data");
> return;
> }
> 
> -- 
> 2.6.4
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

lgtm

Thanks
Steven





___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 1/2] lavf/dump: use error log level for invalid size

2019-08-10 Thread lance . lmwang 
From: Limin Wang 

Signed-off-by: Limin Wang 
---
 libavformat/dump.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libavformat/dump.c b/libavformat/dump.c
index 1c44656..68ce9a8 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -210,7 +210,7 @@ static void dump_paramchange(void *ctx, AVPacketSideData 
*sd)
 
 return;
 fail:
-av_log(ctx, AV_LOG_INFO, "unknown param");
+av_log(ctx, AV_LOG_ERROR, "unknown param");
 }
 
 /* replaygain side data*/
@@ -239,7 +239,7 @@ static void dump_replaygain(void *ctx, AVPacketSideData *sd)
 AVReplayGain *rg;
 
 if (sd->size < sizeof(*rg)) {
-av_log(ctx, AV_LOG_INFO, "invalid data");
+av_log(ctx, AV_LOG_ERROR, "invalid data");
 return;
 }
 rg = (AVReplayGain*)sd->data;
@@ -255,7 +255,7 @@ static void dump_stereo3d(void *ctx, AVPacketSideData *sd)
 AVStereo3D *stereo;
 
 if (sd->size < sizeof(*stereo)) {
-av_log(ctx, AV_LOG_INFO, "invalid data");
+av_log(ctx, AV_LOG_ERROR, "invalid data");
 return;
 }
 
@@ -272,7 +272,7 @@ static void dump_audioservicetype(void *ctx, 
AVPacketSideData *sd)
 enum AVAudioServiceType *ast = (enum AVAudioServiceType *)sd->data;
 
 if (sd->size < sizeof(*ast)) {
-av_log(ctx, AV_LOG_INFO, "invalid data");
+av_log(ctx, AV_LOG_ERROR, "invalid data");
 return;
 }
 
@@ -315,7 +315,7 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
 AVCPBProperties *cpb = (AVCPBProperties *)sd->data;
 
 if (sd->size < sizeof(*cpb)) {
-av_log(ctx, AV_LOG_INFO, "invalid data");
+av_log(ctx, AV_LOG_ERROR, "invalid data");
 return;
 }
 
@@ -357,7 +357,7 @@ static void dump_spherical(void *ctx, AVCodecParameters 
*par, AVPacketSideData *
 double yaw, pitch, roll;
 
 if (sd->size < sizeof(*spherical)) {
-av_log(ctx, AV_LOG_INFO, "invalid data");
+av_log(ctx, AV_LOG_ERROR, "invalid data");
 return;
 }
 
-- 
2.6.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".