Re: [FFmpeg-devel] [PATCH v2 2/3] lavc/libxavs2: use upper layer qp parameters first

[Liu Steven]

> 在 2019年1月24日，下午11:16，hwrenx  写道：
> 
> Signed-off-by: hwrenx 
> ---
> libavcodec/libxavs2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c
> index 2d29427..d5c4557 100644
> --- a/libavcodec/libxavs2.c
> +++ b/libavcodec/libxavs2.c
> @@ -109,8 +109,8 @@ static av_cold int xavs2_init(AVCodecContext *avctx)
> xavs2_opt_set2("RateControl",   "%d", 1);
> xavs2_opt_set2("TargetBitRate", "%"PRId64"", avctx->bit_rate);
> xavs2_opt_set2("InitialQP", "%d", cae->initial_qp);
> -xavs2_opt_set2("MaxQP", "%d", cae->max_qp);
> -xavs2_opt_set2("MinQP", "%d", cae->min_qp);
> +xavs2_opt_set2("MaxQP", "%d", avctx->qmax >= 0 ? avctx->qmax 
> : cae->max_qp);
> +xavs2_opt_set2("MinQP", "%d", avctx->qmin >= 0 ? avctx->qmin 
> : cae->min_qp);
> } else {
> xavs2_opt_set2("InitialQP", "%d", cae->qp);
> }
> -- 
> 2.7.4
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

patchset LGTM too


Thanks

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH v2 2/3] lavc/libxavs2: use upper layer qp parameters first

[hwrenx]

Signed-off-by: hwrenx 
---
 libavcodec/libxavs2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c
index 2d29427..d5c4557 100644
--- a/libavcodec/libxavs2.c
+++ b/libavcodec/libxavs2.c
@@ -109,8 +109,8 @@ static av_cold int xavs2_init(AVCodecContext *avctx)
 xavs2_opt_set2("RateControl",   "%d", 1);
 xavs2_opt_set2("TargetBitRate", "%"PRId64"", avctx->bit_rate);
 xavs2_opt_set2("InitialQP", "%d", cae->initial_qp);
-xavs2_opt_set2("MaxQP", "%d", cae->max_qp);
-xavs2_opt_set2("MinQP", "%d", cae->min_qp);
+xavs2_opt_set2("MaxQP", "%d", avctx->qmax >= 0 ? avctx->qmax : 
cae->max_qp);
+xavs2_opt_set2("MinQP", "%d", avctx->qmin >= 0 ? avctx->qmin : 
cae->min_qp);
 } else {
 xavs2_opt_set2("InitialQP", "%d", cae->qp);
 }
-- 
2.7.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel