Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value
On Fri, Apr 17, 2020 at 04:34:28PM +0200, Paul B Mahol wrote:
> On 4/17/20, Limin Wang wrote:
> >
> > ping for merge please.
>
> trival patch, apply at will.
I can't push it directly, so ping it for developer/maintainer help to apply it.
>
> >
> > On Sun, Mar 29, 2020 at 08:08:04AM +0800, lance.lmw...@gmail.com wrote:
> >> From: Limin Wang
> >>
> >> Signed-off-by: Limin Wang
> >> ---
> >> libavfilter/af_acrossover.c | 5 -
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c
> >> index f70c50b..002f378 100644
> >> --- a/libavfilter/af_acrossover.c
> >> +++ b/libavfilter/af_acrossover.c
> >> @@ -99,7 +99,10 @@ static av_cold int init(AVFilterContext *ctx)
> >>
> >> p = NULL;
> >>
> >> -av_sscanf(arg, "%f", &freq);
> >> +if (av_sscanf(arg, "%f", &freq) != 1) {
> >> +av_log(ctx, AV_LOG_ERROR, "Invalid syntax for
> >> frequency[%d].\n", i);
> >> +return AVERROR(EINVAL);
> >> +}
> >> if (freq <= 0) {
> >> av_log(ctx, AV_LOG_ERROR, "Frequency %f must be positive
> >> number.\n", freq);
> >> return AVERROR(EINVAL);
> >> --
> >> 2.9.5
> >>
> >
> > --
> > Thanks,
> > Limin Wang
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value
Paul B Mahol (12020-04-17): > trival patch, apply at will. It is not a trivial patch when it has required a v3. Let's stop applying at will. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value
On 4/17/20, Limin Wang wrote:
>
> ping for merge please.
trival patch, apply at will.
>
> On Sun, Mar 29, 2020 at 08:08:04AM +0800, lance.lmw...@gmail.com wrote:
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>> ---
>> libavfilter/af_acrossover.c | 5 -
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c
>> index f70c50b..002f378 100644
>> --- a/libavfilter/af_acrossover.c
>> +++ b/libavfilter/af_acrossover.c
>> @@ -99,7 +99,10 @@ static av_cold int init(AVFilterContext *ctx)
>>
>> p = NULL;
>>
>> -av_sscanf(arg, "%f", &freq);
>> +if (av_sscanf(arg, "%f", &freq) != 1) {
>> +av_log(ctx, AV_LOG_ERROR, "Invalid syntax for
>> frequency[%d].\n", i);
>> +return AVERROR(EINVAL);
>> +}
>> if (freq <= 0) {
>> av_log(ctx, AV_LOG_ERROR, "Frequency %f must be positive
>> number.\n", freq);
>> return AVERROR(EINVAL);
>> --
>> 2.9.5
>>
>
> --
> Thanks,
> Limin Wang
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value
ping for merge please.
On Sun, Mar 29, 2020 at 08:08:04AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/af_acrossover.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c
> index f70c50b..002f378 100644
> --- a/libavfilter/af_acrossover.c
> +++ b/libavfilter/af_acrossover.c
> @@ -99,7 +99,10 @@ static av_cold int init(AVFilterContext *ctx)
>
> p = NULL;
>
> -av_sscanf(arg, "%f", &freq);
> +if (av_sscanf(arg, "%f", &freq) != 1) {
> +av_log(ctx, AV_LOG_ERROR, "Invalid syntax for frequency[%d].\n",
> i);
> +return AVERROR(EINVAL);
> +}
> if (freq <= 0) {
> av_log(ctx, AV_LOG_ERROR, "Frequency %f must be positive
> number.\n", freq);
> return AVERROR(EINVAL);
> --
> 2.9.5
>
--
Thanks,
Limin Wang
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value
From: Limin Wang
Signed-off-by: Limin Wang
---
libavfilter/af_acrossover.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c
index f70c50b..002f378 100644
--- a/libavfilter/af_acrossover.c
+++ b/libavfilter/af_acrossover.c
@@ -99,7 +99,10 @@ static av_cold int init(AVFilterContext *ctx)
p = NULL;
-av_sscanf(arg, "%f", &freq);
+if (av_sscanf(arg, "%f", &freq) != 1) {
+av_log(ctx, AV_LOG_ERROR, "Invalid syntax for frequency[%d].\n",
i);
+return AVERROR(EINVAL);
+}
if (freq <= 0) {
av_log(ctx, AV_LOG_ERROR, "Frequency %f must be positive
number.\n", freq);
return AVERROR(EINVAL);
--
2.9.5
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
