Re: [FFmpeg-devel] [PATCHv2 1/5] ffmpeg: log failed av_write_trailer

[Marton Balint]

On Mon, 19 Oct 2015, Michael Niedermayer wrote:


On Sun, Oct 18, 2015 at 12:07:34PM +0200, Marton Balint wrote:

Signed-off-by: Marton Balint 
---
 ffmpeg.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ffmpeg.c b/ffmpeg.c
index 36a68fb..252bc0d 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -4104,7 +4104,9 @@ static int transcode(void)
 /* write the trailer if needed and close file */
 for (i = 0; i < nb_output_files; i++) {
 os = output_files[i]->ctx;
-av_write_trailer(os);
+if ((ret = av_write_trailer(os)) < 0) {
+av_log(NULL, AV_LOG_ERROR, "Error writing trailer of %s: %s", 
os->filename, av_err2str(ret));
+}
 }


LGTM

thanks


Applied, thanks.

Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv2 1/5] ffmpeg: log failed av_write_trailer

[Michael Niedermayer]

On Sun, Oct 18, 2015 at 12:07:34PM +0200, Marton Balint wrote:
> Signed-off-by: Marton Balint 
> ---
>  ffmpeg.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 36a68fb..252bc0d 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -4104,7 +4104,9 @@ static int transcode(void)
>  /* write the trailer if needed and close file */
>  for (i = 0; i < nb_output_files; i++) {
>  os = output_files[i]->ctx;
> -av_write_trailer(os);
> +if ((ret = av_write_trailer(os)) < 0) {
> +av_log(NULL, AV_LOG_ERROR, "Error writing trailer of %s: %s", 
> os->filename, av_err2str(ret));
> +}
>  }

LGTM

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv2 1/5] ffmpeg: log failed av_write_trailer

[Marton Balint]

Signed-off-by: Marton Balint 
---
 ffmpeg.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ffmpeg.c b/ffmpeg.c
index 36a68fb..252bc0d 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -4104,7 +4104,9 @@ static int transcode(void)
 /* write the trailer if needed and close file */
 for (i = 0; i < nb_output_files; i++) {
 os = output_files[i]->ctx;
-av_write_trailer(os);
+if ((ret = av_write_trailer(os)) < 0) {
+av_log(NULL, AV_LOG_ERROR, "Error writing trailer of %s: %s", 
os->filename, av_err2str(ret));
+}
 }
 
 /* dump report by using the first video and audio streams */
-- 
2.1.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel