Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
On Tue, Dec 02, 2014 at 01:32:10AM +0100, Andreas Cadhalpun wrote: > Hi, > > On 02.12.2014 00:09, Michael Niedermayer wrote: > >On Mon, Dec 01, 2014 at 11:09:47PM +0100, Andreas Cadhalpun wrote: > >>On 01.12.2014 04:37, Michael Niedermayer wrote: > >>>this would result in the native encoder being used even when libfaac > >>>is enabled and linked in > >>>is that intended ? > >> > >>Yes, even though this could/should be improved further. > >> > >>Currently ffmpeg already tries to use the native aac encoder even if > >>libfaac is available, but then fails without '-strict -2': > >>"The encoder 'aac' is experimental but experimental codecs are not > >>enabled, add '-strict -2' if you want to use it. > >>Alternatively use the non experimental encoder 'libfaac'." > >> > > > >>It would be nice if ffmpeg would automatically choose the best aac > >>encoder available (libfdk_aac > libfaac > aac > libvo_aacenc), but > > > >does this require anything more than changing the order of > >registration in allcodecs.c ? > > Now I understand which change you meant above: the aac encoder used > for something like: > ffmpeg -i input.wav output.aac yes [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
Hi, On 02.12.2014 00:09, Michael Niedermayer wrote: On Mon, Dec 01, 2014 at 11:09:47PM +0100, Andreas Cadhalpun wrote: On 01.12.2014 04:37, Michael Niedermayer wrote: this would result in the native encoder being used even when libfaac is enabled and linked in is that intended ? Yes, even though this could/should be improved further. Currently ffmpeg already tries to use the native aac encoder even if libfaac is available, but then fails without '-strict -2': "The encoder 'aac' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it. Alternatively use the non experimental encoder 'libfaac'." It would be nice if ffmpeg would automatically choose the best aac encoder available (libfdk_aac > libfaac > aac > libvo_aacenc), but does this require anything more than changing the order of registration in allcodecs.c ? Now I understand which change you meant above: the aac encoder used for something like: ffmpeg -i input.wav output.aac It seems this uses the first non-experimental encoder and thus could indeed change e.g. from libfaac to aac. That's not intended. I had thought about something like: ffmpeg -i input.mpg -c:a aac output.mpg That always uses the native encoder, because it's name is just 'aac'. Trying to be smart in that case and selecting the best available aac encoder automatically is probably not feasible. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
On Mon, Dec 01, 2014 at 11:09:47PM +0100, Andreas Cadhalpun wrote: > Hi, > > On 01.12.2014 04:37, Michael Niedermayer wrote: > >On Sun, Nov 30, 2014 at 11:43:45PM +0100, Andreas Cadhalpun wrote: > >>Subject: [PATCH] avcodec/aacenc: no longer mark native aac encoder as > >> experimental > > > >this would result in the native encoder being used even when libfaac > >is enabled and linked in > >is that intended ? > > Yes, even though this could/should be improved further. > > Currently ffmpeg already tries to use the native aac encoder even if > libfaac is available, but then fails without '-strict -2': > "The encoder 'aac' is experimental but experimental codecs are not > enabled, add '-strict -2' if you want to use it. > Alternatively use the non experimental encoder 'libfaac'." > > It would be nice if ffmpeg would automatically choose the best aac > encoder available (libfdk_aac > libfaac > aac > libvo_aacenc), but does this require anything more than changing the order of registration in allcodecs.c ? > given that the native aac encoder works reasonably well, just using > it is better than aborting. > > Best regards, > Andreas > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once"- "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..." signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
Hi, On 01.12.2014 04:37, Michael Niedermayer wrote: On Sun, Nov 30, 2014 at 11:43:45PM +0100, Andreas Cadhalpun wrote: Subject: [PATCH] avcodec/aacenc: no longer mark native aac encoder as experimental this would result in the native encoder being used even when libfaac is enabled and linked in is that intended ? Yes, even though this could/should be improved further. Currently ffmpeg already tries to use the native aac encoder even if libfaac is available, but then fails without '-strict -2': "The encoder 'aac' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it. Alternatively use the non experimental encoder 'libfaac'." It would be nice if ffmpeg would automatically choose the best aac encoder available (libfdk_aac > libfaac > aac > libvo_aacenc), but given that the native aac encoder works reasonably well, just using it is better than aborting. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
On Sun, Nov 30, 2014 at 11:43:45PM +0100, Andreas Cadhalpun wrote: > On 20.11.2014 20:14, Michael Niedermayer wrote: > >On Thu, Nov 20, 2014 at 05:59:35PM +0100, Andreas Cadhalpun wrote: > >>Hi, > >> > >>currently the native aac encoder is marked as experimental, while > >>the libvo_aacenc encoder is not. > >> > >>However, after reading the wiki [1] and especially the mentioned > >>mail [2], it seems the native encoder is better. > >> > >>Thus I'm wondering if it would make sense to no longer mark the > >>native aac encoder as experimental. > >> > >>This would also solve problems like [3]. > >> > >>Please comment. > > > >i have no real oppinion on this but > >if users prefer it to be not marked as experimental then we should > >make that change. > > Since nobody complained about the idea, I'm attaching a patch for this. > > Best regards, > Andreas > > aacenc.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > 01b17a8598ff3ee4c08918bbc11d0e4c9012bf40 > avcodec-aacenc-no-longer-mark-native-aac-encoder-as-experimental.patch > From 5e3e0707697454541d1432794c902f574ef17cf3 Mon Sep 17 00:00:00 2001 > From: Andreas Cadhalpun > Date: Sun, 30 Nov 2014 23:29:36 +0100 > Subject: [PATCH] avcodec/aacenc: no longer mark native aac encoder as > experimental this would result in the native encoder being used even when libfaac is enabled and linked in is that intended ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
On 20.11.2014 20:14, Michael Niedermayer wrote:
On Thu, Nov 20, 2014 at 05:59:35PM +0100, Andreas Cadhalpun wrote:
Hi,
currently the native aac encoder is marked as experimental, while
the libvo_aacenc encoder is not.
However, after reading the wiki [1] and especially the mentioned
mail [2], it seems the native encoder is better.
Thus I'm wondering if it would make sense to no longer mark the
native aac encoder as experimental.
This would also solve problems like [3].
Please comment.
i have no real oppinion on this but
if users prefer it to be not marked as experimental then we should
make that change.
Since nobody complained about the idea, I'm attaching a patch for this.
Best regards,
Andreas
>From 5e3e0707697454541d1432794c902f574ef17cf3 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun
Date: Sun, 30 Nov 2014 23:29:36 +0100
Subject: [PATCH] avcodec/aacenc: no longer mark native aac encoder as
experimental
---
libavcodec/aacenc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c
index d9c7215..dacff0d 100644
--- a/libavcodec/aacenc.c
+++ b/libavcodec/aacenc.c
@@ -830,8 +830,7 @@ AVCodec ff_aac_encoder = {
.encode2= aac_encode_frame,
.close = aac_encode_end,
.supported_samplerates = mpeg4audio_sample_rates,
-.capabilities = CODEC_CAP_SMALL_LAST_FRAME | CODEC_CAP_DELAY |
- CODEC_CAP_EXPERIMENTAL,
+.capabilities = CODEC_CAP_SMALL_LAST_FRAME | CODEC_CAP_DELAY,
.sample_fmts= (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_FLTP,
AV_SAMPLE_FMT_NONE },
.priv_class = &aacenc_class,
--
2.1.3
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
On Thu, Nov 20, 2014 at 05:59:35PM +0100, Andreas Cadhalpun wrote: > Hi, > > currently the native aac encoder is marked as experimental, while > the libvo_aacenc encoder is not. > > However, after reading the wiki [1] and especially the mentioned > mail [2], it seems the native encoder is better. > > Thus I'm wondering if it would make sense to no longer mark the > native aac encoder as experimental. > > This would also solve problems like [3]. > > Please comment. i have no real oppinion on this but if users prefer it to be not marked as experimental then we should make that change. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB DNS cache poisoning attacks, popular search engine, Google internet authority dont be evil, please signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental
Hi, currently the native aac encoder is marked as experimental, while the libvo_aacenc encoder is not. However, after reading the wiki [1] and especially the mentioned mail [2], it seems the native encoder is better. Thus I'm wondering if it would make sense to no longer mark the native aac encoder as experimental. This would also solve problems like [3]. Please comment. Best regards, Andreas 1: https://trac.ffmpeg.org/wiki/Encode/AAC#libvo_aacenc 2: https://ffmpeg.org/pipermail/ffmpeg-devel/2013-June/144589.html 3: https://bugs.debian.org/768793 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
