[FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread Jan Ehrhardt
Using FFmpeg and fdk-aac from git I am getting the error that
AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is undefined. I would have expected a
define for AAC_PCM_OUTPUT_CHANNEL_MAPPINGS in
https://github.com/mstorsjo/fdk-aac/blob/master/libAACdec/include/aacdecoder_lib.h#L452
but it is not there.

AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is defined in the Android sources:
https://android.googlesource.com/platform/external/aac/+/jb-dev/libAACdec/include/aacdecoder_lib.h#433

I am using these sources for fdk-aac:
https://github.com/mstorsjo/fdk-aac.git
Does anyone know a git repo with a declared
AAC_PCM_OUTPUT_CHANNEL_MAPPINGS?

FFmpeg commit:
http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b01a2204b5cff7bb920f42fda1bb0103f450fe93
http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5a1aa559054b197b64453c60dd01bc5c37532ff9

I have no build environment for libav, so I did not check if the same
error happens when building libav. But anyway, building FFmpeg with
fdk-aac is broken right now.

Jan

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread Jan Ehrhardt
Oops. Sorry for the top-post, but you should read
AAC_PCM_OUTPUT_CHANNELS everywhere I wrote
AAC_PCM_OUTPUT_CHANNEL_MAPPINGS in my previous message.

Jan Ehrhardt in gmane.comp.video.ffmpeg.devel (Mon, 10 Nov 2014 00:04:53
+0100):
Using FFmpeg and fdk-aac from git I am getting the error that
AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is undefined. I would have expected a
define for AAC_PCM_OUTPUT_CHANNEL_MAPPINGS in
https://github.com/mstorsjo/fdk-aac/blob/master/libAACdec/include/aacdecoder_lib.h#L452
but it is not there.

AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is defined in the Android sources:
https://android.googlesource.com/platform/external/aac/+/jb-dev/libAACdec/include/aacdecoder_lib.h#433

I am using these sources for fdk-aac:
https://github.com/mstorsjo/fdk-aac.git
Does anyone know a git repo with a declared
AAC_PCM_OUTPUT_CHANNEL_MAPPINGS?

FFmpeg commit:
http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b01a2204b5cff7bb920f42fda1bb0103f450fe93
http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5a1aa559054b197b64453c60dd01bc5c37532ff9

I have no build environment for libav, so I did not check if the same
error happens when building libav. But anyway, building FFmpeg with
fdk-aac is broken right now.

Jan

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread Derek Buitenhuis
On 11/9/2014 11:04 PM, Jan Ehrhardt wrote:
 I am using these sources for fdk-aac:
 https://github.com/mstorsjo/fdk-aac.git

This is not the repo for fdk-aac and you should not be using it.

FDK-AAC is from:
Releases: http://sourceforge.net/projects/opencore-amr/files/fdk-aac/
Git: git://git.code.sf.net/p/opencore-amr/fdk-aac

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread Michael Niedermayer
On Mon, Nov 10, 2014 at 12:16:05AM +, Derek Buitenhuis wrote:
 On 11/9/2014 11:04 PM, Jan Ehrhardt wrote:
  I am using these sources for fdk-aac:
  https://github.com/mstorsjo/fdk-aac.git
 
 This is not the repo for fdk-aac and you should not be using it.
 
 FDK-AAC is from:
 Releases: http://sourceforge.net/projects/opencore-amr/files/fdk-aac/

 Git: git://git.code.sf.net/p/opencore-amr/fdk-aac

This issue seems to also apply to that repository
greping succeeds for the new symbol but fails for the old


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
Used only once- Some unspecified defect prevented a second use
In good condition - Can be repaird by experienced expert
As is - You wouldnt want it even if you were payed for it, if you knew ...


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread James Almer
On 09/11/14 8:04 PM, Jan Ehrhardt wrote:
 Using FFmpeg and fdk-aac from git I am getting the error that
 AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is undefined. I would have expected a
 define for AAC_PCM_OUTPUT_CHANNEL_MAPPINGS in
 https://github.com/mstorsjo/fdk-aac/blob/master/libAACdec/include/aacdecoder_lib.h#L452
 but it is not there.
 
 AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is defined in the Android sources:
 https://android.googlesource.com/platform/external/aac/+/jb-dev/libAACdec/include/aacdecoder_lib.h#433
 
 I am using these sources for fdk-aac:
 https://github.com/mstorsjo/fdk-aac.git
 Does anyone know a git repo with a declared
 AAC_PCM_OUTPUT_CHANNEL_MAPPINGS?
 
 FFmpeg commit:
 http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b01a2204b5cff7bb920f42fda1bb0103f450fe93
 http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5a1aa559054b197b64453c60dd01bc5c37532ff9
 
 I have no build environment for libav, so I did not check if the same
 error happens when building libav. But anyway, building FFmpeg with
 fdk-aac is broken right now.

There's a patch pending in libav mailing list posted by one of fdk-aac devs 
that 
probably deals with this.
You can try to apply it (It should work on ffmpeg's tree without conflicts) and 
see if that works, or wait until it's merged.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread Michael Niedermayer
On Sun, Nov 09, 2014 at 10:37:35PM -0300, James Almer wrote:
 On 09/11/14 8:04 PM, Jan Ehrhardt wrote:
  Using FFmpeg and fdk-aac from git I am getting the error that
  AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is undefined. I would have expected a
  define for AAC_PCM_OUTPUT_CHANNEL_MAPPINGS in
  https://github.com/mstorsjo/fdk-aac/blob/master/libAACdec/include/aacdecoder_lib.h#L452
  but it is not there.
  
  AAC_PCM_OUTPUT_CHANNEL_MAPPINGS is defined in the Android sources:
  https://android.googlesource.com/platform/external/aac/+/jb-dev/libAACdec/include/aacdecoder_lib.h#433
  
  I am using these sources for fdk-aac:
  https://github.com/mstorsjo/fdk-aac.git
  Does anyone know a git repo with a declared
  AAC_PCM_OUTPUT_CHANNEL_MAPPINGS?
  
  FFmpeg commit:
  http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b01a2204b5cff7bb920f42fda1bb0103f450fe93
  http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5a1aa559054b197b64453c60dd01bc5c37532ff9
  
  I have no build environment for libav, so I did not check if the same
  error happens when building libav. But anyway, building FFmpeg with
  fdk-aac is broken right now.
 
 There's a patch pending in libav mailing list posted by one of fdk-aac devs 
 that 
 probably deals with this.
 You can try to apply it (It should work on ffmpeg's tree without conflicts) 
 and 
 see if that works, or wait until it's merged.

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [fdk-aac] AAC_PCM_OUTPUT_CHANNEL_MAPPINGS undeclared

2014-11-09 Thread Jan Ehrhardt
Michael Niedermayer in gmane.comp.video.ffmpeg.devel (Mon, 10 Nov 2014
02:47:32 +0100):
On Sun, Nov 09, 2014 at 10:37:35PM -0300, James Almer wrote:
 There's a patch pending in libav mailing list posted by one of fdk-aac devs 
 that 
 probably deals with this.
 You can try to apply it (It should work on ffmpeg's tree without conflicts) 
 and 
 see if that works, or wait until it's merged.

applied

Fix confirmed. @Derek: thanks for the pointer to git.code.sf.net

Jan

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel