Re: [FFmpeg-devel] MpegTS contribution question

2019-08-09 Thread Anthony Delannoy
For now I'm just reading and storing EPG data, once this part is done I'd
like to do what you said.
But first we will have to think of an easy way to change/insert descriptors
inside a specific table.

Thanks for your response :)

Le jeu. 8 août 2019 à 17:57, Phil Burr  a écrit :

> Hello Anthony,
>
> I'm not really the best to answer your questions, as I'm also a fairly new
> contributor (my patches seem to be languishing due to a lack of feedback
> and a lack of time on my part pushing the issue).  I've been working on
> getting support into mpegts for ATSC compliant descriptors of which EIT
> tables are a glaring omission in large part due to the amount of work
> needed to support them.  So to say the least, I'm excited about your
> patches!  I'll take a look at your patches but one thing I would like to
> know if you've considered, is whether or not your code supports modifying
> the EIT tables, ie updating tables_version when the tables are modified?
>
> Thanks,
> Phil
>
> On Thu, Aug 8, 2019 at 4:13 AM Anthony Delannoy  >
> wrote:
>
> > Hi,
> >
> > I'm currently doing my first contribution to ffmpeg by adding EPG support
> > in the mpegts format.
> > For now, i succeeded to add support for EIT table and majority of its
> > descriptors and can read/export EPG
> > events in a .csv file.
> > But I don't know on how to organize it now. Do I make a new codec for epg
> > and a data stream? Do I keep those
> > information « hidden » and present them only in metadatas plus functions
> > api to export them?
> >
> > For those who wants to see where I am at:
> > https://github.com/spnngl/FFmpeg/tree/epg2
> >
> > Some remarks:
> >   * For now I use linked list to store EPG events but I may change for
> > something simpler.
> >   * I made separate descriptors code to be able to use it on others
> tables
> > later. I want to add NIT table
> >   support and maybe others if i succeed to finish EPG.
> >   * EPG/descriptors files are all in libavformat for now, they need to be
> > moved
> >
> > Thanks
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] MpegTS contribution question

2019-08-08 Thread Phil Burr
Hello Anthony,

I'm not really the best to answer your questions, as I'm also a fairly new
contributor (my patches seem to be languishing due to a lack of feedback
and a lack of time on my part pushing the issue).  I've been working on
getting support into mpegts for ATSC compliant descriptors of which EIT
tables are a glaring omission in large part due to the amount of work
needed to support them.  So to say the least, I'm excited about your
patches!  I'll take a look at your patches but one thing I would like to
know if you've considered, is whether or not your code supports modifying
the EIT tables, ie updating tables_version when the tables are modified?

Thanks,
Phil

On Thu, Aug 8, 2019 at 4:13 AM Anthony Delannoy 
wrote:

> Hi,
>
> I'm currently doing my first contribution to ffmpeg by adding EPG support
> in the mpegts format.
> For now, i succeeded to add support for EIT table and majority of its
> descriptors and can read/export EPG
> events in a .csv file.
> But I don't know on how to organize it now. Do I make a new codec for epg
> and a data stream? Do I keep those
> information « hidden » and present them only in metadatas plus functions
> api to export them?
>
> For those who wants to see where I am at:
> https://github.com/spnngl/FFmpeg/tree/epg2
>
> Some remarks:
>   * For now I use linked list to store EPG events but I may change for
> something simpler.
>   * I made separate descriptors code to be able to use it on others tables
> later. I want to add NIT table
>   support and maybe others if i succeed to finish EPG.
>   * EPG/descriptors files are all in libavformat for now, they need to be
> moved
>
> Thanks
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] MpegTS contribution question

2019-08-08 Thread Anthony Delannoy
Hi,

I'm currently doing my first contribution to ffmpeg by adding EPG support
in the mpegts format.
For now, i succeeded to add support for EIT table and majority of its
descriptors and can read/export EPG
events in a .csv file.
But I don't know on how to organize it now. Do I make a new codec for epg
and a data stream? Do I keep those
information « hidden » and present them only in metadatas plus functions
api to export them?

For those who wants to see where I am at:
https://github.com/spnngl/FFmpeg/tree/epg2

Some remarks:
  * For now I use linked list to store EPG events but I may change for
something simpler.
  * I made separate descriptors code to be able to use it on others tables
later. I want to add NIT table
  support and maybe others if i succeed to finish EPG.
  * EPG/descriptors files are all in libavformat for now, they need to be
moved

Thanks
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".