Re: [FFmpeg-devel] Patch to add avcintra-flavor option from x264
You're right. I tested the avcintra-flavor option a while ago in ffmpeg with latests x264 (which included the avcintra-flavor option) and it did not work. I'm not sure why that was but now it does work. So, ignore this patch. Thanks! :-) -steinar Den tor. 6. des. 2018 kl. 11:37 skrev Gyan Doshi : > On 06-12-2018 02:26 PM, Steinar Apalnes wrote: > > This patch adds the new "avcintra-flavor" to the -x264opts. The > > avcintra-flavor option in x264 adds the possibility to create the Sony > XAVC > > flavor of avcintra. Default is Panasonic. > > > > Tested OK. > > > > -steinar > > Why is this needed? All key=value pairs added through -x264opts and > -x264-params are evaluated by x264 and not ffmpeg. Indeed, I just tested > it with avcintra-flavour=sony and x264 accepts it - x264 complains if I > mangle the key or value string. > > Also, your patch adds an AVOption and a new member to the wrapper's > context struct but does not convey the value to x4->params. I don't see > how it has any effect. > > > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Patch to add avcintra-flavor option from x264
On 06-12-2018 02:26 PM, Steinar Apalnes wrote: This patch adds the new "avcintra-flavor" to the -x264opts. The avcintra-flavor option in x264 adds the possibility to create the Sony XAVC flavor of avcintra. Default is Panasonic. Tested OK. -steinar Why is this needed? All key=value pairs added through -x264opts and -x264-params are evaluated by x264 and not ffmpeg. Indeed, I just tested it with avcintra-flavour=sony and x264 accepts it - x264 complains if I mangle the key or value string. Also, your patch adds an AVOption and a new member to the wrapper's context struct but does not convey the value to x4->params. I don't see how it has any effect. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Patch to add avcintra-flavor option from x264
This patch adds the new "avcintra-flavor" to the -x264opts. The avcintra-flavor option in x264 adds the possibility to create the Sony XAVC flavor of avcintra. Default is Panasonic. Tested OK. -steinar 0001-add avcintra-flavor option.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
