Re: [FFmpeg-devel] avcodec/qsv: export session management functionality
Le quartidi 24 frimaire, an CCXXIV, Sven Dueking a écrit : > Thanks for your feedback, I think it´s necessary because : > > 1. qsv_api.c is single file where qsv-related public functions are located > 2. there is big question that qsv.c will exists in future most likely it > will merged with qsv_api later. > We have only one common function left > > If you disagree, please suggest how to split this. Patch #1: make the functions public (renaming ff_ -> av_, removing static, moving prototypes in public headers). Patch #2: move the code from one file to the other. I see no reason this would not work, please correct me if I am wrong. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avcodec/qsv: export session management functionality
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Nicolas George > Gesendet: Montag, 14. Dezember 2015 16:55 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] avcodec/qsv: export session management > functionality > > Le quartidi 24 frimaire, an CCXXIV, Sven Dueking a écrit : > > Thanks for your feedback, I think it´s necessary because : > > > > 1. qsv_api.c is single file where qsv-related public functions are > > located 2. there is big question that qsv.c will exists in future > most > > likely it will merged with qsv_api later. > > We have only one common function left > > > > If you disagree, please suggest how to split this. > > Patch #1: make the functions public (renaming ff_ -> av_, removing > static, moving prototypes in public headers). > > Patch #2: move the code from one file to the other. > > I see no reason this would not work, please correct me if I am wrong. I didn´t say that this would not work. Will split the patch, but will wait for Hendriks feedback - maybe he has some feedback for this patch. > > Regards, > > -- > Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avcodec/qsv: export session management functionality
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Nicolas George > Gesendet: Montag, 14. Dezember 2015 16:32 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] avcodec/qsv: export session management > functionality > > Le quartidi 24 frimaire, an CCXXIV, Sven Dueking a écrit : > > Updated patch according to Hendriks feedback. > > Is it really necessary to have the moves from a file to another in the > same patch as the functional changes? It makes seeing what did actually > change much harder, almost impossible. > > Regards, > > -- > Nicolas George Hi Nicolas, Thanks for your feedback, I think it´s necessary because : 1. qsv_api.c is single file where qsv-related public functions are located 2. there is big question that qsv.c will exists in future most likely it will merged with qsv_api later. We have only one common function left If you disagree, please suggest how to split this. Thanks, Sven ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avcodec/qsv: export session management functionality
Le quartidi 24 frimaire, an CCXXIV, Sven Dueking a écrit : > Updated patch according to Hendriks feedback. Is it really necessary to have the moves from a file to another in the same patch as the functional changes? It makes seeing what did actually change much harder, almost impossible. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] avcodec/qsv: export session management functionality
Updated patch according to Hendriks feedback. Thanks, Sven 0001-export-session-management-functionality.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
