Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number
2018-03-21 16:33 GMT+01:00, sanilraut :
> +if(pls->last_seq_no == 0){
Please add a space to avoid mixing styles: "if ("
We usually use "if (!pls->last_seq_no)", same above.
> +pls->last_seq_no = calc_max_seg_no(pls, s->priv_data);
> +}
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number
On Thu, Mar 22, 2018 at 9:51 PM, sanilraut wrote: > Last segment indicated by mpd is not parsed. > Example stream: > http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd > > This patch supports parsing of Supplemental Descriptor with @schemeIdUri set > to http://dashif.org/guide- > lines/last-segment-number with the @value set to the last segment number. > Hi, Just seeing the commit message, I don't remember if the MPEG-DASH demuxer had any FATE tests, but this stuff sounds like something that should be included as such. MPEG-DASH is quite complex and having tests making sure that we get the same things out of the demuxer would be quite helpful. You can see for example tests/fate/mov.mak as an example of testing a demuxer. Best regards, Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number
Thanks. I have re-submitted the patch with changes.
On Wed, Mar 21, 2018 at 1:24 PM, Carl Eugen Hoyos
wrote:
> 2018-03-21 16:33 GMT+01:00, sanilraut :
>
> > +if(pls->last_seq_no == 0){
>
> Please add a space to avoid mixing styles: "if ("
> We usually use "if (!pls->last_seq_no)", same above.
>
> > +pls->last_seq_no = calc_max_seg_no(pls, s->priv_data);
> > +}
>
> Carl Eugen
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number
On Thu, Mar 22, 2018 at 10:14:36PM +0200, Jan Ekström wrote: > On Thu, Mar 22, 2018 at 9:51 PM, sanilraut wrote: > > Last segment indicated by mpd is not parsed. > > Example stream: > > http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd > > > > This patch supports parsing of Supplemental Descriptor with @schemeIdUri > > set to http://dashif.org/guide- > > lines/last-segment-number with the @value set to the last segment number. > > > > Hi, > > Just seeing the commit message, ... i realize its missing the avformat / libavformat/dashdec prefix :) very minor issue but it seems a common mistake maybe something could test for this automatically so new people would notice before git send mail -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number
Thanks. @Jan: I will look into the FATE tests. I have emailed you a few questions that I have about FATE. Looking forward to your reply. @Michael: I have added the prefix and resubmitted the patch. Regards, Sanil On Fri, Mar 23, 2018 at 5:24 PM, Michael Niedermayer wrote: > On Thu, Mar 22, 2018 at 10:14:36PM +0200, Jan Ekström wrote: > > On Thu, Mar 22, 2018 at 9:51 PM, sanilraut wrote: > > > Last segment indicated by mpd is not parsed. > > > Example stream: http://dash.akamaized.net/dash264/TestCasesIOP41/ > LastSegmentNumber/1/manifest_last_segment_num.mpd > > > > > > This patch supports parsing of Supplemental Descriptor with > @schemeIdUri set to http://dashif.org/guide- > > > lines/last-segment-number with the @value set to the last segment > number. > > > > > > > Hi, > > > > Just seeing the commit message, > > ... i realize its missing the avformat / libavformat/dashdec prefix :) > very minor issue but it seems a common mistake > maybe something could test for this automatically so new people would > notice before git send mail > > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Dictatorship naturally arises out of democracy, and the most aggravated > form of tyranny and slavery out of the most extreme liberty. -- Plato > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
