Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md
On 18/09/2016 01:29, James Almer wrote: On 9/17/2016 8:42 PM, Josh de Kock wrote: TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch to add the notice. Signed-off-by: Josh de Kock --- CONTRIBUTING.md | 4 1 file changed, 4 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000..c2b79e4 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,4 @@ +# Note to Github users +Patches should be submitted to the [ffmpeg-devel mailing list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git format-patch` or `git send-email`. Github pull requests should be avoided because they are not part of our review process and **will be ignored**. The wording here is different to the notice in README.md, so make it either "will be ignored" or "will likely be ignored" in both. This patch should be ok in any case. + +See [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) for more information. Thanks, applied with updated wording to README.md. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md
On 9/17/2016 8:42 PM, Josh de Kock wrote: > TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) > suggested doing this a while ago, but it was never done. As pull requests > seem to be still coming through, I thought I'd send a patch to add the notice. > > Signed-off-by: Josh de Kock > --- > CONTRIBUTING.md | 4 > 1 file changed, 4 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > new file mode 100644 > index 000..c2b79e4 > --- /dev/null > +++ b/CONTRIBUTING.md > @@ -0,0 +1,4 @@ > +# Note to Github users > +Patches should be submitted to the [ffmpeg-devel mailing > list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git > format-patch` or `git send-email`. Github pull requests should be avoided > because they are not part of our review process and **will be ignored**. The wording here is different to the notice in README.md, so make it either "will be ignored" or "will likely be ignored" in both. This patch should be ok in any case. > + > +See > [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) > for more information. > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Add CONTRIBUTING.md
> Am 18.09.2016 um 01:42 schrieb Josh de Kock : > > TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) > suggested doing this a while ago, but it was never done. As pull requests > seem to be still coming through, I thought I'd send a patch to add the notice. > > Signed-off-by: Josh de Kock > --- > CONTRIBUTING.md | 4 > 1 file changed, 4 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > new file mode 100644 > index 000..c2b79e4 > --- /dev/null > +++ b/CONTRIBUTING.md > @@ -0,0 +1,4 @@ > +# Note to Github users > +Patches should be submitted to the [ffmpeg-devel mailing > list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git > format-patch` or `git send-email`. Github pull requests should be avoided > because they are not part of our review process and **will be ignored**. > + > +See > [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) > for more information. > -- LGTM -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On Tue, 6 Oct 2015 18:37:47 +0200, Stefano Sabatini wrote: > If we keep CONTRIBUTING.md, better to make it independent from Github > - that is I'm suggesting that we move all contributing indications to > README.md, or we keep them in a separate file CONTRIBUTING.md, as > proposed by this patch. > > In case we adopt the second solution (which I'm fine with), then you > could mention CONTRIBUTING.md in README.md and remove the > corresponding section, since otherwise you're duplicating the > information stated in README.md. After looking at it again I decided to drop this patch. I don't really like adding even more verbosity in yet another location for users to (not) read; especially just to have a notice on the Github FFmpeg page. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On date Tuesday 2015-10-06 08:20:11 -0800, Lou Logan encoded: > On Tue, Oct 6, 2015, at 07:07 AM, Stefano Sabatini wrote: > > > > I wonder if adding the contents to README.md is not a better choice > > > > Note also since we're writing about github, that the README.md will > > have a better visibility there, since it is shown on the project main > > page: > > https://github.com/FFmpeg/FFmpeg > > I forgot to mention that main reason for making this is to address this: > > https://github.com/FFmpeg/FFmpeg/pull/153 > > README.md is already displayed on the Github page, but CONTRIBUTING.md > should add a notification banner as shown in the link above. The idea is > to attempt to reduce the number of Github pull requests since the vast > majority of us don't pay attention to them. Makes sense. > If you prefer I can remove everything but the "Note to Github Users" and > then mention they should refer to README.md for more info. If we keep CONTRIBUTING.md, better to make it independent from Github - that is I'm suggesting that we move all contributing indications to README.md, or we keep them in a separate file CONTRIBUTING.md, as proposed by this patch. In case we adopt the second solution (which I'm fine with), then you could mention CONTRIBUTING.md in README.md and remove the corresponding section, since otherwise you're duplicating the information stated in README.md. -- FFmpeg = Frenzy & Frenzy Mean Power Empowered Gem ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On Tue, Oct 6, 2015, at 07:07 AM, Stefano Sabatini wrote: > > I wonder if adding the contents to README.md is not a better choice > > Note also since we're writing about github, that the README.md will > have a better visibility there, since it is shown on the project main > page: > https://github.com/FFmpeg/FFmpeg I forgot to mention that main reason for making this is to address this: https://github.com/FFmpeg/FFmpeg/pull/153 README.md is already displayed on the Github page, but CONTRIBUTING.md should add a notification banner as shown in the link above. The idea is to attempt to reduce the number of Github pull requests since the vast majority of us don't pay attention to them. If you prefer I can remove everything but the "Note to Github Users" and then mention they should refer to README.md for more info. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On date Monday 2015-10-05 15:26:46 -0800, Lou Logan encoded: > For the Github users to ignore. > > Signed-off-by: Lou Logan > --- > CONTRIBUTING.md | 36 > 1 file changed, 36 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > new file mode 100644 > index 000..4bccf25 > --- /dev/null > +++ b/CONTRIBUTING.md > @@ -0,0 +1,36 @@ > +# Contributing to FFmpeg > + > +FFmpeg is a big project, but we like seeing patches from new contributors. > +You can get started by reading the [Developer Documentation] > +(https://ffmpeg.org/developer.html). > + > +## A note to Github users > + > +**FFmpeg development, including patch reviews, occurs on the ffmpeg-devel > +mailing list, so most developers do not view Github pull requests. > +Therefore, Github pull requests should be avoided because they will > +likely be not be noticed.** typo: likely not be noticed [...] I wonder if adding the contents to README.md is not a better choice Note also since we're writing about github, that the README.md will have a better visibility there, since it is shown on the project main page: https://github.com/FFmpeg/FFmpeg -- FFmpeg = Fantastic and Fascinating Mysterious Perennial Ermetic Gigant ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On Mon, Oct 5, 2015 at 11:17 PM, Lou Logan wrote: > On Mon, Oct 5, 2015, at 05:46 PM, Ganesh Ajjanagadde wrote: >> Unless you have a good reason for this, please change the paragraph to >> be much more similar/identical with README.md. > > Why would that matter? It is just a minor nit; users/developers should not get the impression that we are inconsistent in our stance towards pull requests. The two paragraphs are sufficiently similar that I am willing to let this slide. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On 15-10-05 at 15:26, Lou Logan wrote: [..] > + > +**FFmpeg development, including patch reviews, occurs on the ffmpeg-devel > +mailing list, so most developers do not view Github pull requests. > +Therefore, Github pull requests should be avoided because they will > +likely be not be noticed.** likely not be noticed. [..] -- Simon Thelen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On Mon, Oct 5, 2015, at 05:46 PM, Ganesh Ajjanagadde wrote: > Unless you have a good reason for this, please change the paragraph to > be much more similar/identical with README.md. Why would that matter? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] add CONTRIBUTING.md
On Mon, Oct 5, 2015 at 7:26 PM, Lou Logan wrote: > For the Github users to ignore. > > Signed-off-by: Lou Logan > --- > CONTRIBUTING.md | 36 > 1 file changed, 36 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > new file mode 100644 > index 000..4bccf25 > --- /dev/null > +++ b/CONTRIBUTING.md > @@ -0,0 +1,36 @@ > +# Contributing to FFmpeg > + > +FFmpeg is a big project, but we like seeing patches from new contributors. > +You can get started by reading the [Developer Documentation] > +(https://ffmpeg.org/developer.html). > + > +## A note to Github users > + > +**FFmpeg development, including patch reviews, occurs on the ffmpeg-devel > +mailing list, so most developers do not view Github pull requests. > +Therefore, Github pull requests should be avoided because they will > +likely be not be noticed.** Unless you have a good reason for this, please change the paragraph to be much more similar/identical with README.md. > + > +## Submitting patches > + > +Patches should be sent to the [ffmpeg-devel mailing list] > +(https://ffmpeg.org/contact.html). > + > +Patches created with `git send-email` are preferred, but using > +`git format-patch` is also acceptable. See [Submitting Patches] > +(http://ffmpeg.org/developer.html#Submitting-patches-1) and > +[Using Git to Develop FFmpeg](https://ffmpeg.org/git-howto.html). > + > +## Bug reports > + > +Bug reports and feature requests should be submitted to our > +[bug tracker](https://trac.ffmpeg.org/). For more information refer to > +[Submitting a Bug Report](https://ffmpeg.org/bugreports.html). > + > +Please do not send bug reports to the ffmpeg-devel mailing list unless > +you are also sending a patch to fix the bug. > + > +## If you need help > + > +Visit the #ffmpeg IRC channel, or send a message to one of the > +appropriate [mailing lists](https://ffmpeg.org/contact.html). > -- > 2.5.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel