Re: [FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries
On 22-07-2019 12:50 PM, Paul B Mahol wrote: On 7/21/19, Gyan wrote: On 21-07-2019 02:21 PM, Paul B Mahol wrote: On 7/20/19, Gyan wrote: Affected files can now be demuxed. Verified with John Stebbins. FATE passes. Gyan You removed negative check, so not ok. entries is unsigned (in the code as well as in the standard). So the value read from file will be >= 0. Even after adjustment for index size overflow, it cannot become negative. OK then Pushed as d51d71c1e3a6a225a5bc8f35963b50331e479b1a after moving check to after overflow check. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries
On 7/21/19, Gyan wrote: > > > On 21-07-2019 02:21 PM, Paul B Mahol wrote: >> On 7/20/19, Gyan wrote: >>> Affected files can now be demuxed. Verified with John Stebbins. FATE >>> passes. >>> >>> Gyan >>> >> You removed negative check, so not ok. > > entries is unsigned (in the code as well as in the standard). So the > value read from file will be >= 0. Even after adjustment for index size > overflow, it cannot become negative. OK then > > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries
On 21-07-2019 02:21 PM, Paul B Mahol wrote: On 7/20/19, Gyan wrote: Affected files can now be demuxed. Verified with John Stebbins. FATE passes. Gyan You removed negative check, so not ok. entries is unsigned (in the code as well as in the standard). So the value read from file will be >= 0. Even after adjustment for index size overflow, it cannot become negative. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries
On 7/20/19, Gyan wrote: > > Affected files can now be demuxed. Verified with John Stebbins. FATE > passes. > > Gyan > You removed negative check, so not ok. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
