Re: [FFmpeg-devel] [PATCH] doc/codecs: Better documentation for the libavcodec bitexact flag

2014-11-03 Thread Michael Niedermayer
On Mon, Nov 03, 2014 at 10:01:11AM +0100, Benoit Fouet wrote:
> 
> 
> - Mail original -
> > Signed-off-by: Michael Niedermayer 
> > ---
> >  doc/codecs.texi |4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/doc/codecs.texi b/doc/codecs.texi
> > index 2bb6059..85e6d47 100644
> > --- a/doc/codecs.texi
> > +++ b/doc/codecs.texi
> > @@ -71,7 +71,9 @@ Force low delay.
> >  @item global_header
> >  Place global headers in extradata instead of every keyframe.
> >  @item bitexact
> > -Use only bitexact stuff (except (I)DCT).
> > +Only write platform-, build- and time-independant data. (except
> > (I)DCT).
> 
> independent

changed


> 
> > +This ensures that file and data checksums are reproducable and match
> > between
> > +platforms. Its primary use is for regression testing.
> >  @item aic
> >  Apply H263 advanced intra coding / mpeg4 ac prediction.
> >  @item cbp
> > 
> 
> LGTM otherwise.

applied

i also chnaged the bitexact docs for libavformat

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] doc/codecs: Better documentation for the libavcodec bitexact flag

2014-11-03 Thread Benoit Fouet


- Mail original -
> Signed-off-by: Michael Niedermayer 
> ---
>  doc/codecs.texi |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/codecs.texi b/doc/codecs.texi
> index 2bb6059..85e6d47 100644
> --- a/doc/codecs.texi
> +++ b/doc/codecs.texi
> @@ -71,7 +71,9 @@ Force low delay.
>  @item global_header
>  Place global headers in extradata instead of every keyframe.
>  @item bitexact
> -Use only bitexact stuff (except (I)DCT).
> +Only write platform-, build- and time-independant data. (except
> (I)DCT).

independent

> +This ensures that file and data checksums are reproducable and match
> between
> +platforms. Its primary use is for regression testing.
>  @item aic
>  Apply H263 advanced intra coding / mpeg4 ac prediction.
>  @item cbp
> 

LGTM otherwise.

-- 
Ben
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] doc/codecs: Better documentation for the libavcodec bitexact flag

2014-11-02 Thread Michael Niedermayer
On Sat, Nov 01, 2014 at 09:22:15PM -0700, Timothy Gu wrote:
> On Friday, October 31, 2014, Michael Niedermayer  wrote:
> 
> > Signed-off-by: Michael Niedermayer >
> > ---
> >  doc/codecs.texi |2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/codecs.texi b/doc/codecs.texi
> > index 2bb6059..5cf2dc0 100644
> > --- a/doc/codecs.texi
> > +++ b/doc/codecs.texi
> > @@ -71,7 +71,7 @@ Force low delay.
> >  @item global_header
> >  Place global headers in extradata instead of every keyframe.
> >  @item bitexact
> > -Use only bitexact stuff (except (I)DCT).
> > +Only write binary portable, build and time independant data. (except
> > (I)DCT).
> >
> 

> What is "binary portable"?

removed


> 
> Also, it should be "build- and time-independent." I would prefer if you can
> add the word "reproducible" somewhere in it as well.

ok, sent another try

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] doc/codecs: Better documentation for the libavcodec bitexact flag

2014-11-01 Thread Timothy Gu
On Friday, October 31, 2014, Michael Niedermayer  wrote:

> Signed-off-by: Michael Niedermayer >
> ---
>  doc/codecs.texi |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/codecs.texi b/doc/codecs.texi
> index 2bb6059..5cf2dc0 100644
> --- a/doc/codecs.texi
> +++ b/doc/codecs.texi
> @@ -71,7 +71,7 @@ Force low delay.
>  @item global_header
>  Place global headers in extradata instead of every keyframe.
>  @item bitexact
> -Use only bitexact stuff (except (I)DCT).
> +Only write binary portable, build and time independant data. (except
> (I)DCT).
>

What is "binary portable"?

Also, it should be "build- and time-independent." I would prefer if you can
add the word "reproducible" somewhere in it as well.

Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel