Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 29.10.2016 20:12, Lou Logan wrote: > On Sat, Oct 29, 2016, at 06:57 AM, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun>> --- >> doc/filters.texi | 2 +- >> doc/formats.texi | 2 +- >> libavcodec/4xm.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) > > LGTM, thanks. Pushed. > Feel free to push trivial typo patches without sending > them to the mailing list (unless of course you prefer a review or feel > more comfortable doing so). OK, I might do that next time. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Sat, Oct 29, 2016, at 06:57 AM, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun> --- > doc/filters.texi | 2 +- > doc/formats.texi | 2 +- > libavcodec/4xm.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) LGTM, thanks. Feel free to push trivial typo patches without sending them to the mailing list (unless of course you prefer a review or feel more comfortable doing so). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 21.10.2016 23:47, Lou Logan wrote: > On Fri, Oct 21, 2016, at 01:21 PM, Andreas Cadhalpun wrote: >> >> Updated patch is attached. > > LGTM, thanks. Pushed. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Fri, Oct 21, 2016, at 01:21 PM, Andreas Cadhalpun wrote: > > Updated patch is attached. LGTM, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 21.10.2016 22:12, Lou Logan wrote: > On Thu, Oct 13, 2016, at 01:25 PM, Andreas Cadhalpun wrote: > [...] >> @item mgain >> Set max gain that will be displayed. Only useful if curves option is >> activated. >> -Setting this to reasonable value allows to display gain which is derived >> from >> +Setting this to reasonable value allows one to display gain which is >> derived from > > To *a* reasonable... Sure. > I've never been a fan of the "one" pronoun, but I'm fine with it being > used in the docs and it's better than it not being there. I've replaced 'allows one to' with 'makes it possible'. Hopefully you like that better. ;) Updated patch is attached. Best regards, Andreas >From 794261f73f72bb1c85b6fde8217d01b34642abf1 Mon Sep 17 00:00:00 2001 From: Andreas CadhalpunDate: Thu, 13 Oct 2016 23:08:01 +0200 Subject: [PATCH] doc: fix spelling errors Thanks to Mathieu Malaterre for reporting the Que/Queue typo. (https://bugs.debian.org/839542) Signed-off-by: Andreas Cadhalpun --- doc/Doxyfile| 2 +- doc/encoders.texi | 2 +- doc/ffprobe.texi| 2 +- doc/filters.texi| 10 +- doc/muxers.texi | 6 +++--- ffmpeg.c| 2 +- ffmpeg_cuvid.c | 4 ++-- libavcodec/aaccoder_twoloop.h | 2 +- libavcodec/cabac.c | 2 +- libavcodec/ffjni.c | 2 +- libavcodec/mediacodec_wrapper.h | 2 +- libavcodec/psymodel.h | 2 +- libavcodec/x86/vp9lpf_16bpp.asm | 2 +- libavfilter/af_hdcd.c | 2 +- libavfilter/f_ebur128.c | 2 +- libavformat/internal.h | 2 +- libavutil/frame.h | 2 +- libavutil/tree.h| 2 +- 18 files changed, 25 insertions(+), 25 deletions(-) diff --git a/doc/Doxyfile b/doc/Doxyfile index fb5cdd3..0891899 100644 --- a/doc/Doxyfile +++ b/doc/Doxyfile @@ -1637,7 +1637,7 @@ EXTRA_PACKAGES = # following commands have a special meaning inside the header: $title, # $datetime, $date, $doxygenversion, $projectname, $projectnumber, # $projectbrief, $projectlogo. Doxygen will replace $title with the empy string, -# for the replacement values of the other commands the user is refered to +# for the replacement values of the other commands the user is referred to # HTML_HEADER. # This tag requires that the tag GENERATE_LATEX is set to YES. diff --git a/doc/encoders.texi b/doc/encoders.texi index 09e1b9e..5a60e7e 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1773,7 +1773,7 @@ Enable CAVLC and disable CABAC. It generates the same effect as @end table @item cmp -Set full pixel motion estimation comparation algorithm. Possible values: +Set full pixel motion estimation comparison algorithm. Possible values: @table @samp @item chroma diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi index 2024eed..1069ae3 100644 --- a/doc/ffprobe.texi +++ b/doc/ffprobe.texi @@ -245,7 +245,7 @@ continue reading from that. Each interval is specified by two optional parts, separated by "%". The first part specifies the interval start position. It is -interpreted as an abolute position, or as a relative offset from the +interpreted as an absolute position, or as a relative offset from the current position if it is preceded by the "+" character. If this first part is not specified, no seeking will be performed when reading this interval. diff --git a/doc/filters.texi b/doc/filters.texi index b470f40..c37fa29 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -449,7 +449,7 @@ This filter is bit crusher with enhanced functionality. A bit crusher is used to audibly reduce number of bits an audio signal is sampled with. This doesn't change the bit depth at all, it just produces the effect. Material reduced in bit depth sounds more harsh and "digital". -This filter is able to even round to continous values instead of discrete +This filter is able to even round to continuous values instead of discrete bit depths. Additionally it has a D/C offset which results in different crushing of the lower and the upper half of the signal. @@ -475,7 +475,7 @@ Set level out. Set bit reduction. @item mix -Set mixing ammount. +Set mixing amount. @item mode Can be linear: @code{lin} or logarithmic: @code{log}. @@ -1203,7 +1203,7 @@ Set video stream size. Only useful if curves option is activated. @item mgain Set max gain that will be displayed. Only useful if curves option is activated. -Setting this to reasonable value allows to display gain which is derived from +Setting this to a reasonable value makes it possible to display gain which is derived from neighbour bands which are too close to each other and thus produce higher gain when both are activated. @@ -8858,7 +8858,7 @@ value. @section hysteresis Grow first stream into second stream by connecting components.
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Thu, Oct 13, 2016, at 01:25 PM, Andreas Cadhalpun wrote: [...] > @item mgain > Set max gain that will be displayed. Only useful if curves option is > activated. > -Setting this to reasonable value allows to display gain which is derived > from > +Setting this to reasonable value allows one to display gain which is > derived from To *a* reasonable... I've never been a fan of the "one" pronoun, but I'm fine with it being used in the docs and it's better than it not being there. Everything else LGTM. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 13.10.2016 23:25, Andreas Cadhalpun wrote: > Thanks to Mathieu Malaterrefor reporting the > Que/Queue typo. (https://bugs.debian.org/839542) > > Signed-off-by: Andreas Cadhalpun > --- > doc/Doxyfile| 2 +- > doc/encoders.texi | 2 +- > doc/ffprobe.texi| 2 +- > doc/filters.texi| 10 +- > doc/muxers.texi | 6 +++--- > ffmpeg.c| 2 +- > ffmpeg_cuvid.c | 4 ++-- > libavcodec/aaccoder_twoloop.h | 2 +- > libavcodec/cabac.c | 2 +- > libavcodec/ffjni.c | 2 +- > libavcodec/mediacodec_wrapper.h | 2 +- > libavcodec/psymodel.h | 2 +- > libavcodec/x86/vp9lpf_16bpp.asm | 2 +- > libavfilter/af_hdcd.c | 2 +- > libavfilter/f_ebur128.c | 2 +- > libavformat/internal.h | 2 +- > libavutil/frame.h | 2 +- > libavutil/tree.h| 2 +- > 18 files changed, 25 insertions(+), 25 deletions(-) Ping. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 30.09.2015 03:27, Lou Logan wrote: > On Tue, 29 Sep 2015 20:34:09 +0200, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun>> --- >> doc/encoders.texi | 2 +- >> doc/filters.texi | 14 +++--- >> libavcodec/g726.c | 2 +- >> libavcodec/vaapi_hevc.c| 2 +- >> libavfilter/x86/vf_removegrain.asm | 4 ++-- >> libavformat/asfdec_o.c | 6 +++--- >> libavformat/ffmdec.c | 2 +- >> libavformat/mov.c | 4 ++-- >> 8 files changed, 18 insertions(+), 18 deletions(-) > > Patch LGTM, thanks. Pushed. > There are some existing grammar issues that I > noticed because of your patch (this is just a typo patch anyway), but I > can fix those "someday". OK. > Consider adding "bellow" to tools/patcheck, and whatever other typos you > think are appropriate. Well, "bellow" is actually a regular word, so it depends on the context. I'll just fix whenever I notice a spelling error. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Fri, Oct 9, 2015 at 4:13 PM, Andreas Cadhalpunwrote: > On 30.09.2015 03:27, Lou Logan wrote: >> On Tue, 29 Sep 2015 20:34:09 +0200, Andreas Cadhalpun wrote: >> >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> doc/encoders.texi | 2 +- >>> doc/filters.texi | 14 +++--- >>> libavcodec/g726.c | 2 +- >>> libavcodec/vaapi_hevc.c| 2 +- >>> libavfilter/x86/vf_removegrain.asm | 4 ++-- >>> libavformat/asfdec_o.c | 6 +++--- >>> libavformat/ffmdec.c | 2 +- >>> libavformat/mov.c | 4 ++-- >>> 8 files changed, 18 insertions(+), 18 deletions(-) >> >> Patch LGTM, thanks. > > Pushed. > >> There are some existing grammar issues that I >> noticed because of your patch (this is just a typo patch anyway), but I >> can fix those "someday". > > OK. > >> Consider adding "bellow" to tools/patcheck, and whatever other typos you >> think are appropriate. > > Well, "bellow" is actually a regular word, so it depends on the context. > I'll just fix whenever I notice a spelling error. I doubt that "bellow" has a place in any comment/doc in FFmpeg ;). > > Best regards, > Andreas > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 9/29/15, Moritz Barsnickwrote: > On Tue, Sep 29, 2015 at 20:34:09 +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> doc/encoders.texi | 2 +- >> doc/filters.texi | 14 +++--- >> libavcodec/g726.c | 2 +- >> libavcodec/vaapi_hevc.c| 2 +- >> libavfilter/x86/vf_removegrain.asm | 4 ++-- >> libavformat/asfdec_o.c | 6 +++--- >> libavformat/ffmdec.c | 2 +- >> libavformat/mov.c | 4 ++-- >> 8 files changed, 18 insertions(+), 18 deletions(-) > > [Slightly highjacking this thread, sorry.] > > I also have a collection of a ton of spelling, grammar and > comprehensibility errors. Is this the right way to submit them, or > shoud they be grouped by source files, sections, types of error? Just send them as you find one. No need to group them or send all of them at once. > > Thanks, > Moritz > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Tue, Sep 29, 2015 at 20:34:09 +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun> --- > doc/encoders.texi | 2 +- > doc/filters.texi | 14 +++--- > libavcodec/g726.c | 2 +- > libavcodec/vaapi_hevc.c| 2 +- > libavfilter/x86/vf_removegrain.asm | 4 ++-- > libavformat/asfdec_o.c | 6 +++--- > libavformat/ffmdec.c | 2 +- > libavformat/mov.c | 4 ++-- > 8 files changed, 18 insertions(+), 18 deletions(-) [Slightly highjacking this thread, sorry.] I also have a collection of a ton of spelling, grammar and comprehensibility errors. Is this the right way to submit them, or shoud they be grouped by source files, sections, types of error? Thanks, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Tue, 29 Sep 2015 20:34:09 +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun> --- > doc/encoders.texi | 2 +- > doc/filters.texi | 14 +++--- > libavcodec/g726.c | 2 +- > libavcodec/vaapi_hevc.c| 2 +- > libavfilter/x86/vf_removegrain.asm | 4 ++-- > libavformat/asfdec_o.c | 6 +++--- > libavformat/ffmdec.c | 2 +- > libavformat/mov.c | 4 ++-- > 8 files changed, 18 insertions(+), 18 deletions(-) Patch LGTM, thanks. There are some existing grammar issues that I noticed because of your patch (this is just a typo patch anyway), but I can fix those "someday". Consider adding "bellow" to tools/patcheck, and whatever other typos you think are appropriate. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Sat, Jun 13, 2015 at 09:46:01PM +0200, Andreas Cadhalpun wrote: Neccessary - Necessary formated - formatted thee - the eventhough - even though seperately - separately Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- doc/examples/transcoding.c | 2 +- libavcodec/ass_split.h | 2 +- libavcodec/bitstream.c | 2 +- libavformat/avio.h | 2 +- libavformat/flvenc.c | 2 +- libavutil/log.h| 2 +- libavutil/pixfmt.h | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) should be ok thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On 14.06.2015 14:36, Michael Niedermayer wrote: On Sat, Jun 13, 2015 at 09:46:01PM +0200, Andreas Cadhalpun wrote: Neccessary - Necessary formated - formatted thee - the eventhough - even though seperately - separately Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- doc/examples/transcoding.c | 2 +- libavcodec/ass_split.h | 2 +- libavcodec/bitstream.c | 2 +- libavformat/avio.h | 2 +- libavformat/flvenc.c | 2 +- libavutil/log.h| 2 +- libavutil/pixfmt.h | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) should be ok Pushed. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors
On Mon, Dec 01, 2014 at 12:08:03AM +0100, Andreas Cadhalpun wrote: Hi, attached patch fixes some spelling mistakes in the documentation and code comments. succesfully = successfully reproducable = reproducible specifiying = specifying isnt = isn't seperated = separated Best regards, Andreas doc/codecs.texi|2 +- doc/formats.texi |2 +- doc/indevs.texi|2 +- doc/print_options.c|2 +- libavcodec/avcodec.h |2 +- libavcodec/vdpau.h |2 +- libavformat/avformat.h |4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) 99742216aaded2f2c02d88ec9ede183a033cc4a0 doc-fix-spelling-errors.patch From cf836c2b85f2bffe3de7b87b4f4c89e150640c58 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun andreas.cadhal...@googlemail.com Date: Sun, 30 Nov 2014 23:59:22 +0100 Subject: [PATCH] doc: fix spelling errors succesfully = successfully, reproducable = reproducible, specifiying = specifying, isnt = isn't, seperated = separated applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel