Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread Nicolas George
Anton Khirnov (12022-07-18):
> Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of
>  AVFrame.pkt_duration

You may want to update this: it is no longer "instead".

Regards,

-- 
  Nicolas George


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread Anton Khirnov
Quoting Nicolas George (2022-07-18 10:23:40)
> Anton Khirnov (12022-07-18):
> > Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of
> >  AVFrame.pkt_duration
> 
> You may want to update this: it is no longer "instead".

Right, changed locally.

-- 
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread James Almer

On 7/18/2022 4:34 AM, Anton Khirnov wrote:

diff --git a/tests/ref/fate/exif-image-jpg b/tests/ref/fate/exif-image-jpg
index b942fc5a7b..2d5fe18d61 100644
--- a/tests/ref/fate/exif-image-jpg
+++ b/tests/ref/fate/exif-image-jpg
@@ -10,6 +10,8 @@ best_effort_timestamp=0
  best_effort_timestamp_time=0.00
  pkt_duration=1
  pkt_duration_time=0.04
+duration=1
+duration_time=0.04
  pkt_pos=N/A
  pkt_size=46095
  width=400
@@ -27,30 +29,30 @@ color_space=bt470bg
  color_primaries=unknown
  color_transfer=unknown
  chroma_location=center
-TAG:ImageDescription=
+TAG:ImageDescription=
  TAG:Make=Canon
  TAG:Model=Canon PowerShot SX200 IS
  TAG:Orientation=1
-TAG:XResolution=180:1
-TAG:YResolution=180:1
+TAG:XResolution=180:1
+TAG:YResolution=180:1
  TAG:ResolutionUnit=2
  TAG:DateTime=2013:07:18 13:12:03
  TAG:YCbCrPositioning=2
-TAG:ExposureTime=  1:1250
-TAG:FNumber= 40:10
+TAG:ExposureTime=  1:1250
+TAG:FNumber= 40:10
  TAG:ISOSpeedRatings=  160
  TAG:ExifVersion= 48,  50,  50,  49
  TAG:DateTimeOriginal=2013:07:18 13:12:03
  TAG:DateTimeDigitized=2013:07:18 13:12:03
  TAG:ComponentsConfiguration=  1,   2,   3,   0
-TAG:CompressedBitsPerPixel=  3:1
-TAG:ShutterSpeedValue=329:32
-TAG:ApertureValue=128:32
-TAG:ExposureBiasValue=  0:3
-TAG:MaxApertureValue=113:32
+TAG:CompressedBitsPerPixel=  3:1
+TAG:ShutterSpeedValue=329:32
+TAG:ApertureValue=128:32
+TAG:ExposureBiasValue=  0:3
+TAG:MaxApertureValue=113:32
  TAG:MeteringMode=5
  TAG:Flash=   16
-TAG:FocalLength=   5000:1000
+TAG:FocalLength=   5000:1000
  TAG:MakerNote=
   25,   0,   1,   0,   3,   0,  48,   0,   0,   0,  28,   4,   0,   0,   2,   0
3,   0,   4,   0,   0,   0, 124,   4,   0,   0,   3,   0,   3,   0,   4,   0


This and exif-image-webp got a lot of suspicious changes, adding 
trailing whitespaces to several lines.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread Anton Khirnov
Quoting James Almer (2022-07-18 13:49:18)
> On 7/18/2022 4:34 AM, Anton Khirnov wrote:
> > diff --git a/tests/ref/fate/exif-image-jpg b/tests/ref/fate/exif-image-jpg
> > index b942fc5a7b..2d5fe18d61 100644
> > --- a/tests/ref/fate/exif-image-jpg
> > +++ b/tests/ref/fate/exif-image-jpg
> > @@ -10,6 +10,8 @@ best_effort_timestamp=0
> >   best_effort_timestamp_time=0.00
> >   pkt_duration=1
> >   pkt_duration_time=0.04
> > +duration=1
> > +duration_time=0.04
> >   pkt_pos=N/A
> >   pkt_size=46095
> >   width=400
> > @@ -27,30 +29,30 @@ color_space=bt470bg
> >   color_primaries=unknown
> >   color_transfer=unknown
> >   chroma_location=center
> > -TAG:ImageDescription=
> > +TAG:ImageDescription=
> >   TAG:Make=Canon
> >   TAG:Model=Canon PowerShot SX200 IS
> >   TAG:Orientation=1
> > -TAG:XResolution=180:1
> > -TAG:YResolution=180:1
> > +TAG:XResolution=180:1
> > +TAG:YResolution=180:1
> >   TAG:ResolutionUnit=2
> >   TAG:DateTime=2013:07:18 13:12:03
> >   TAG:YCbCrPositioning=2
> > -TAG:ExposureTime=  1:1250
> > -TAG:FNumber= 40:10
> > +TAG:ExposureTime=  1:1250
> > +TAG:FNumber= 40:10
> >   TAG:ISOSpeedRatings=  160
> >   TAG:ExifVersion= 48,  50,  50,  49
> >   TAG:DateTimeOriginal=2013:07:18 13:12:03
> >   TAG:DateTimeDigitized=2013:07:18 13:12:03
> >   TAG:ComponentsConfiguration=  1,   2,   3,   0
> > -TAG:CompressedBitsPerPixel=  3:1
> > -TAG:ShutterSpeedValue=329:32
> > -TAG:ApertureValue=128:32
> > -TAG:ExposureBiasValue=  0:3
> > -TAG:MaxApertureValue=113:32
> > +TAG:CompressedBitsPerPixel=  3:1
> > +TAG:ShutterSpeedValue=329:32
> > +TAG:ApertureValue=128:32
> > +TAG:ExposureBiasValue=  0:3
> > +TAG:MaxApertureValue=113:32
> >   TAG:MeteringMode=5
> >   TAG:Flash=   16
> > -TAG:FocalLength=   5000:1000
> > +TAG:FocalLength=   5000:1000
> >   TAG:MakerNote=
> >25,   0,   1,   0,   3,   0,  48,   0,   0,   0,  28,   4,   0,   0,   
> > 2,   0
> > 3,   0,   4,   0,   0,   0, 124,   4,   0,   0,   3,   0,   3,   0,   
> > 4,   0
> 
> This and exif-image-webp got a lot of suspicious changes, adding 
> trailing whitespaces to several lines.

That whitespace is actually present in the tags exported from lavc.
Don't know why it wasn't present in the refs before.

-- 
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".