Re: [FFmpeg-devel] [PATCH] lavu: use address-of operator checking clock_gettime

2020-12-23 Thread Marvin Scholz 
Ping.

On 8 Dec 2020, at 23:18, Marvin Scholz wrote:

> When targeting a recent enough macOS/iOS version that has clock_gettime
> it won't be a weak symbol, in which case clang warns for this check
> as it's always true:
>
>   warning: address of function 'clock_gettime' will always
>   evaluate to 'true'
>
> This warning is silenced by using the address-of operator to make
> the intent explicit.
> ---
>  libavutil/time.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavutil/time.c b/libavutil/time.c
> index afa6658aa6..740afc4785 100644
> --- a/libavutil/time.c
> +++ b/libavutil/time.c
> @@ -57,7 +57,7 @@ int64_t av_gettime_relative(void)
>  {
>  #if HAVE_CLOCK_GETTIME && defined(CLOCK_MONOTONIC)
>  #ifdef __APPLE__
> -if (clock_gettime)
> +if (_gettime)
>  #endif
>  {
>  struct timespec ts;
> @@ -72,7 +72,7 @@ int av_gettime_relative_is_monotonic(void)
>  {
>  #if HAVE_CLOCK_GETTIME && defined(CLOCK_MONOTONIC)
>  #ifdef __APPLE__
> -if (!clock_gettime)
> +if (!_gettime)
>  return 0;
>  #endif
>  return 1;
> -- 
> 2.24.3 (Apple Git-128)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavu: use address-of operator checking clock_gettime

2020-12-17 Thread Marvin Scholz 
Ping

On 8 Dec 2020, at 23:18, Marvin Scholz wrote:

> When targeting a recent enough macOS/iOS version that has clock_gettime
> it won't be a weak symbol, in which case clang warns for this check
> as it's always true:
>
>   warning: address of function 'clock_gettime' will always
>   evaluate to 'true'
>
> This warning is silenced by using the address-of operator to make
> the intent explicit.
> ---
>  libavutil/time.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavutil/time.c b/libavutil/time.c
> index afa6658aa6..740afc4785 100644
> --- a/libavutil/time.c
> +++ b/libavutil/time.c
> @@ -57,7 +57,7 @@ int64_t av_gettime_relative(void)
>  {
>  #if HAVE_CLOCK_GETTIME && defined(CLOCK_MONOTONIC)
>  #ifdef __APPLE__
> -if (clock_gettime)
> +if (_gettime)
>  #endif
>  {
>  struct timespec ts;
> @@ -72,7 +72,7 @@ int av_gettime_relative_is_monotonic(void)
>  {
>  #if HAVE_CLOCK_GETTIME && defined(CLOCK_MONOTONIC)
>  #ifdef __APPLE__
> -if (!clock_gettime)
> +if (!_gettime)
>  return 0;
>  #endif
>  return 1;
> -- 
> 2.24.3 (Apple Git-128)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".