Re: [FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result
Hi Brad
do you have a oppinion on the change below ?
you are the author of the code
On Thu, Oct 15, 2015 at 10:22:17PM -0400, Ganesh Ajjanagadde wrote:
> This does not trigger any warnings, but adds robustness.
> Untested, as my configure does not compile this file.
>
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libavdevice/sndio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavdevice/sndio.h b/libavdevice/sndio.h
> index 54a5ec3..6571429 100644
> --- a/libavdevice/sndio.h
> +++ b/libavdevice/sndio.h
> @@ -42,6 +42,7 @@ typedef struct SndioData {
> int sample_rate;
> } SndioData;
>
> +av_warn_unused_result
> int ff_sndio_open(AVFormatContext *s1, int is_output, const char
> *audio_device);
> int ff_sndio_close(SndioData *s);
>
> --
> 2.6.1
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
What does censorship reveal? It reveals fear. -- Julian Assange
signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result
On Fri, Oct 16, 2015 at 5:31 PM, Ganesh Ajjanagadde wrote: > On Fri, Oct 16, 2015 at 11:46 AM, Michael Niedermayer > wrote: >> On Thu, Oct 15, 2015 at 10:22:17PM -0400, Ganesh Ajjanagadde wrote: >>> This does not trigger any warnings, but adds robustness. >>> Untested, as my configure does not compile this file. >>> >>> Signed-off-by: Ganesh Ajjanagadde >>> --- >>> libavdevice/sndio.h | 1 + >>> 1 file changed, 1 insertion(+) >> >> iam not the maintainer of this but its probably ok > > Will wait, will need at the minimum a compile test (to ensure that the > attributes stuff is present). To anyone with ability to compile sndio stuff, ping - I am not sure whether the libavutil/attributes header is needed or not, and can't test on my end. > >> >> [...] >> >> -- >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >> >> Many things microsoft did are stupid, but not doing something just because >> microsoft did it is even more stupid. If everything ms did were stupid they >> would be bankrupt already. >> >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result
On Fri, Oct 16, 2015 at 11:46 AM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 10:22:17PM -0400, Ganesh Ajjanagadde wrote: >> This does not trigger any warnings, but adds robustness. >> Untested, as my configure does not compile this file. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavdevice/sndio.h | 1 + >> 1 file changed, 1 insertion(+) > > iam not the maintainer of this but its probably ok Will wait, will need at the minimum a compile test (to ensure that the attributes stuff is present). > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Many things microsoft did are stupid, but not doing something just because > microsoft did it is even more stupid. If everything ms did were stupid they > would be bankrupt already. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result
On Thu, Oct 15, 2015 at 10:22:17PM -0400, Ganesh Ajjanagadde wrote: > This does not trigger any warnings, but adds robustness. > Untested, as my configure does not compile this file. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavdevice/sndio.h | 1 + > 1 file changed, 1 insertion(+) iam not the maintainer of this but its probably ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
