Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Don't assume separate u and v planes in ff_alloc_picture
On Tue, Nov 14, 2017 at 07:24:13AM -0800, Philip Langdale wrote: > I'm confused at how none of the previous hwaccels hit this, but > alloc_frame_buffer in ff_alloc_picture asserts that the linesize > of planes 1 and 2 are the same. If the pixfmt has a single uv > plane, like NV12, this won't be true. > > So, let's only do this check if there are more than 2 planes. > > I didn't bother investigating why, but vdpau avoids this by having > all linesizes set to zero. Cute. > > Signed-off-by: Philip Langdale > --- > libavcodec/mpegpicture.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Don't assume separate u and v planes in ff_alloc_picture
On Tue, 14 Nov 2017 16:29:06 +0100 Hendrik Leppkes wrote: > On Tue, Nov 14, 2017 at 4:24 PM, Philip Langdale > wrote: > > > > I didn't bother investigating why, but vdpau avoids this by having > > all linesizes set to zero. Cute. > > Thats probably what most hwaccels do, the hardware surface has its own > descriptor, so the linesize is not used. Indeed. I took a look at the get_buffer implementations and cuda is special in that it sets the data and linesize values to reflect the underlying pixfmt. No good deed goes unpunished. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Don't assume separate u and v planes in ff_alloc_picture
On Tue, Nov 14, 2017 at 4:24 PM, Philip Langdale wrote: > > I didn't bother investigating why, but vdpau avoids this by having > all linesizes set to zero. Cute. Thats probably what most hwaccels do, the hardware surface has its own descriptor, so the linesize is not used. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
