Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-19 Thread James Almer 
On 7/18/2016 8:56 PM, Michael Niedermayer wrote:
> On Mon, Jul 18, 2016 at 01:56:29PM -0300, James Almer wrote:
>> On 7/12/2016 6:36 PM, James Almer wrote:
>>> Signed-off-by: James Almer 
>>> ---
>>>  libavformat/oggparsevp8.c | 6 +-
>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> Ping for patchset.
> 
> you are the author of the oggparsevp8 code, also i tested this a bit
> with random ogg files, seems not breaking anything

Pushed the first two patches. I'll push the third one soon if nobody
comments on it.

Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-18 Thread Michael Niedermayer 
On Mon, Jul 18, 2016 at 01:56:29PM -0300, James Almer wrote:
> On 7/12/2016 6:36 PM, James Almer wrote:
> > Signed-off-by: James Almer 
> > ---
> >  libavformat/oggparsevp8.c | 6 +-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Ping for patchset.

you are the author of the oggparsevp8 code, also i tested this a bit
with random ogg files, seems not breaking anything

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-18 Thread James Almer 
On 7/12/2016 6:36 PM, James Almer wrote:
> Signed-off-by: James Almer 
> ---
>  libavformat/oggparsevp8.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Ping for patchset.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-12 Thread James Almer 
On 7/12/2016 7:52 PM, Moritz Barsnick wrote:
> On Tue, Jul 12, 2016 at 18:36:20 -0300, James Almer wrote:
>> +uint32_t invcnt = !((granule >> 30) & 3);
> 
> If it's just for storing a 0/1 (bool, basically), wouldn't you use the
> more unspecific type "int"? (Not sure whether it matters at all.)
> 
> Moritz

Yeah, int should suffice. I used uint32_t for alignment purposes
with the other variables, but then i added the comment and that
became superfluous i guess.

Changed locally.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avformat/oggparsevp8: fix pts calculation on pages ending with an invisible frame

2016-07-12 Thread Moritz Barsnick 
On Tue, Jul 12, 2016 at 18:36:20 -0300, James Almer wrote:
> +uint32_t invcnt = !((granule >> 30) & 3);

If it's just for storing a 0/1 (bool, basically), wouldn't you use the
more unspecific type "int"? (Not sure whether it matters at all.)

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel