Re: [FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

2014-11-10 Thread Lukasz Marek 

On 01.11.2014 22:20, Reynaldo H. Verdejo Pinochet wrote:

Hi

On 10/31/2014 11:00 PM, Lukasz Marek wrote:

[..]
diff --git a/ffserver_config.c b/ffserver_config.c
index d589ff2..f11db03 100644
--- a/ffserver_config.c
+++ b/ffserver_config.c
@@ -819,8 +819,6 @@ static int ffserver_parse_config_stream(FFServerConfig 
*config, const char *cmd,
  ret = av_parse_video_size(w, h, arg);
  if (ret  0)
  ERROR(Invalid video size '%s'\n, arg);
-else if ((w % 16) || (h % 16))
-ERROR(Image size must be a multiple of 16\n);
[..]


OK if always safe. Otherwise demote to WARNING()


Changed to warning when (w%2) || (h%2).
with current constraints 360p is not even possible to be used.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

2014-11-08 Thread Michael Niedermayer 
On Sat, Nov 08, 2014 at 06:17:07PM +0100, Lukasz Marek wrote:
 On 1 November 2014 22:20, Reynaldo H. Verdejo Pinochet 
 reyna...@osg.samsung.com wrote:
 
  Hi
 
  On 10/31/2014 11:00 PM, Lukasz Marek wrote:
   [..]
   diff --git a/ffserver_config.c b/ffserver_config.c
   index d589ff2..f11db03 100644
   --- a/ffserver_config.c
   +++ b/ffserver_config.c
   @@ -819,8 +819,6 @@ static int
  ffserver_parse_config_stream(FFServerConfig *config, const char *cmd,
ret = av_parse_video_size(w, h, arg);
if (ret  0)
ERROR(Invalid video size '%s'\n, arg);
   -else if ((w % 16) || (h % 16))
   -ERROR(Image size must be a multiple of 16\n);
   [..]
 
  OK if always safe. Otherwise demote to WARNING()
 
  Feel free to push otherwise.
 
 
 Can some one confirm it is safe to not demand width and height to be
 multiply of 16? Is there any other constraint? like %2?

arbitrary dimensions should be safe, codecs which dont support them
should fail
of course there might be bugs and testing can never hurt ...

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

2014-11-01 Thread Reynaldo H. Verdejo Pinochet 
Hi

On 10/31/2014 11:00 PM, Lukasz Marek wrote:
 [..]
 diff --git a/ffserver_config.c b/ffserver_config.c
 index d589ff2..f11db03 100644
 --- a/ffserver_config.c
 +++ b/ffserver_config.c
 @@ -819,8 +819,6 @@ static int ffserver_parse_config_stream(FFServerConfig 
 *config, const char *cmd,
  ret = av_parse_video_size(w, h, arg);
  if (ret  0)
  ERROR(Invalid video size '%s'\n, arg);
 -else if ((w % 16) || (h % 16))
 -ERROR(Image size must be a multiple of 16\n);
 [..]

OK if always safe. Otherwise demote to WARNING()

Feel free to push otherwise.

Bests,

-- 
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel