Re: [FFmpeg-devel] [PATCH 2/4] lavd/avfoundation: Add human readable option arguments.
Am 30.06.19 um 21:40 schrieb Thilo Borgmann:
> Am 30.06.19 um 19:17 schrieb Moritz Barsnick:
>> On Sun, Jun 30, 2019 at 14:14:13 +0200, Thilo Borgmann wrote:
>>> -{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
>>> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
>>> AV_OPT_FLAG_DECODING_PARAM },
>>> -{ "capture_mouse_clicks", "capture the screen mouse clicks",
>>> offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0,
>>> 1, AV_OPT_FLAG_DECODING_PARAM },
>>> +{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
>>> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
>>> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
>>> +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0,
>>> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
>>> +{ "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0,
>>> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
>>> +{ "capture_mouse_clicks", "capture the screen mouse clicks",
>>> offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0,
>>> 1, AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
>>> +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0,
>>> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
>>> +{ "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0,
>>> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
>>
>> Can't you just make the options AV_OPT_TYPE_BOOL? No additional consts
>> requires.
>
> Yes. Changed locally.
Also changed for the new option in patch 4/4, of course.
-Thilo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 2/4] lavd/avfoundation: Add human readable option arguments.
Am 30.06.19 um 19:17 schrieb Moritz Barsnick:
> On Sun, Jun 30, 2019 at 14:14:13 +0200, Thilo Borgmann wrote:
>> -{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
>> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, AV_OPT_FLAG_DECODING_PARAM
>> },
>> -{ "capture_mouse_clicks", "capture the screen mouse clicks",
>> offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
>> AV_OPT_FLAG_DECODING_PARAM },
>> +{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
>> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
>> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
>> +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0,
>> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
>> +{ "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0,
>> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
>> +{ "capture_mouse_clicks", "capture the screen mouse clicks",
>> offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
>> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
>> +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0,
>> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
>> +{ "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0,
>> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
>
> Can't you just make the options AV_OPT_TYPE_BOOL? No additional consts
> requires.
Yes. Changed locally.
Thanks,
Thilo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 2/4] lavd/avfoundation: Add human readable option arguments.
On Sun, Jun 30, 2019 at 14:14:13 +0200, Thilo Borgmann wrote:
> -{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, AV_OPT_FLAG_DECODING_PARAM
> },
> -{ "capture_mouse_clicks", "capture the screen mouse clicks",
> offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
> AV_OPT_FLAG_DECODING_PARAM },
> +{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, AV_OPT_FLAG_DECODING_PARAM,
> "capture_cursor" },
> +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0,
> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
> +{ "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0,
> AV_OPT_FLAG_DECODING_PARAM, "capture_cursor" },
> +{ "capture_mouse_clicks", "capture the screen mouse clicks",
> offsetof(AVFContext, capture_mouse_clicks), AV_OPT_TYPE_INT, {.i64=0}, 0, 1,
> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
> +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0,
> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
> +{ "false", "", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0,
> AV_OPT_FLAG_DECODING_PARAM, "capture_mouse_clicks" },
Can't you just make the options AV_OPT_TYPE_BOOL? No additional consts
requires.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
