Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro
On 08/02/15 11:04 PM, Clément Bœsch wrote: On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote: The .text section is already 16-byte aligned by default on all supported platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. naive question, what about the few SECTION_TEXT 32? [...] Here, if the 32 is left as the alignment, the build dies. ... nasm -f aout -DPREFIX -I./ -IK:/usr/local/src/ffmpeg// -Pconfig.asm -I K:/usr/local/src/ffmpeg/libavcodec/x86/ -o libavcodec/x86/hevc_idct.o K:/usr/local/src/ffmpeg/libavcodec/x86/hevc_idct.asm K:/usr/local/src/ffmpeg/libavcodec/x86/hevc_idct.asm:24: error: segment name `.text 32' not recognized make: *** [libavcodec/x86/hevc_idct.o] Error 1 My builds have been dropping the 32 without problems but that is on a 32 bit platform without AVX. Dave ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro
On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote: The .text section is already 16-byte aligned by default on all supported platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. naive question, what about the few SECTION_TEXT 32? [...] -- Clément B. pgpiCW7CJ2oX1.pgp Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro
On Mon, Aug 3, 2015 at 8:04 AM, Clément Bœsch u...@pkh.me wrote: naive question, what about the few SECTION_TEXT 32? I don't know why 32-byte alignment was used for the text section in the first place. Functions are only 16-byte aligned anyway. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro
On Mon, Aug 3, 2015 at 1:37 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Does silencing these warnings still work after this patch? Yes, undefining __SECT__ is no longer needed after this patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
