Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

[Hamza Shahid]

Hi Will,

I think we addressed all the review comments in this patch. Which are as
follows:

1. Remove inline asm for color conversion and replace with swscale, which I
did.
2. Replace static variables with #defines, which I did.
3. Remove unnecessary stuff from configure script, which I did.
4. Use named constants instead string to constant conversion function,
which I did.
5. configure script was broke, which I fixed.

Can you please be a bit more specific about which comments did we not
address. I will be more than glad to fix everything and get this patch
through.

Thanks & Regards
Hamza Shahid

On Tue, Jan 12, 2016 at 9:44 PM, Will Kelleher 
wrote:

> On 01/09, ha...@mayartech.com wrote:
> > From: "ha...@mayartech.com" 
> >
> > This commit adds a hardware accelerated H.264 encoder which utilizes
> > libVA (open source implementation of VA-API). Information about libva
> > is available at: https://en.wikipedia.org/wiki/Video_Acceleration_API
> > This encoder is only availbale on linux and supported hardware which
> > can be viewed at:
> >
> https://en.wikipedia.org/wiki/Video_Acceleration_API#Supported_hardware_and_drivers
> >
>
> Hi,
>
> I tested this and I can confirm that it at least works from a functional
> perspective.  I'm very interested in seeing this cleaned up and merged,
> since it
> provides a better alternative to h264_qsv on platforms for which Intel has
> decided to drop support in recent versions of the MediaSDK.  For example,
> my
> IvyBridge hardware is no longer supported with the current MediaSDK and is
> limited to kernel 3.14.5 with an old MediaSDK release.  I can use this
> patch to
> encode through vaapi with kernel 4.3.0 and no MediaSDK dependency.  This
> makes
> me happy!
>
> That said, it doesn't look like any of the previous review comments (which
> I
> agree with) were addressed in this second version.  Let me know if there is
> anything I can do to help.
>
> Thanks,
>
> will
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

[Hendrik Leppkes]

On Tue, Jan 12, 2016 at 9:26 PM, compn  wrote:
> On Tue, 12 Jan 2016 10:44:18 -0600
> Will Kelleher  wrote:
>
>> That said, it doesn't look like any of the previous review comments
>> (which I agree with) were addressed in this second version.  Let me
>> know if there is anything I can do to help.
>
> some devs made comments that it cannot use colorspace conversion,
> because colorspace conversion code belongs in swscale.
>
> now they complain that there is a swscale dep.
>
> so what do these devs want? heh.

We want it to define its native input format, and let the generic code
in ffmpeg.c etc handle conversion to the appropriate format.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

[compn]

On Tue, 12 Jan 2016 10:44:18 -0600
Will Kelleher  wrote:

> That said, it doesn't look like any of the previous review comments
> (which I agree with) were addressed in this second version.  Let me
> know if there is anything I can do to help.

some devs made comments that it cannot use colorspace conversion,
because colorspace conversion code belongs in swscale.

now they complain that there is a swscale dep.

so what do these devs want? heh.

-compn
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel