Re: [FFmpeg-devel] [PATCH v2 1/5] vaapi_encode: Support configurable slices
On 23/10/18 00:06, Mark Thompson wrote: > On 25/09/18 02:40, myp...@gmail.com wrote: >> On Mon, Sep 24, 2018 at 5:53 AM Mark Thompson wrote: >>> >>> This adds common code to query driver support and set appropriate >>> address/size information for each slice. It only supports rectangular >>> slices for now, since that is the most common use-case. >>> --- >> >> Tested and verified with media-driver master branch >> (https://github.com/intel/media-driver) in SKL. > > Thank you! > > I added the missing slice_segments -> guessed level dependency in 4/5. > > I don't think there is anything else to do here, so I'll push it in two days > if there are no further comments. Applied. Thanks, - Mark ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2 1/5] vaapi_encode: Support configurable slices
On 25/09/18 02:40, myp...@gmail.com wrote: > On Mon, Sep 24, 2018 at 5:53 AM Mark Thompson wrote: >> >> This adds common code to query driver support and set appropriate >> address/size information for each slice. It only supports rectangular >> slices for now, since that is the most common use-case. >> --- > > Tested and verified with media-driver master branch > (https://github.com/intel/media-driver) in SKL. Thank you! I added the missing slice_segments -> guessed level dependency in 4/5. I don't think there is anything else to do here, so I'll push it in two days if there are no further comments. - Mark ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2 1/5] vaapi_encode: Support configurable slices
On Mon, Sep 24, 2018 at 5:53 AM Mark Thompson wrote: > > This adds common code to query driver support and set appropriate > address/size information for each slice. It only supports rectangular > slices for now, since that is the most common use-case. > --- Tested and verified with media-driver master branch (https://github.com/intel/media-driver) in SKL. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2 1/5] vaapi_encode: Support configurable slices
On Sun, Sep 23, 2018 at 22:52:56 +0100, Mark Thompson wrote: > const VAEntrypoint *usable_entrypoints; > -const VAAPIEncodeProfile *profile; > -const AVPixFmtDescriptor *desc; > +const VAAPIEncodeProfile *profile;const AVPixFmtDescriptor *desc; This change doesn't look intentional. Cheers, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
