Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 08:27:42PM +, Kieran Kunhya wrote:
> Hello,
> 
> I need to remove MPEG-4 support from mpegvideo in order to upstream the
> following code:
> https://github.com/kierank/ffmpeg-sstp
> 
> I'll need to extract mpeg4video from mpegvideo for the following reasons in
> the Studio Profile:
> 
> - 10-bit video, mpegvideo.c is entirely 8-bit, I'll need to write a new
> idct or use an existing (e.g ProRes) if applicable
> - DPCM mode (a bit like h264's mode)
> 
> In particular I think this will break lowres. Is this ok or will the patch
> be blocked?

If the patch breaks lowres and people lack interrest in fixing it
then please give me a chance to find a solution that doesnt break it.


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 22:33 Carl Eugen Hoyos  wrote:

> 2017-11-04 21:27 GMT+01:00 Kieran Kunhya :
>
> > I need to remove MPEG-4 support from mpegvideo in order
> > to upstream the following code:
> > https://github.com/kierank/ffmpeg-sstp
>
> Decoding of the yuv422p10 samples does not yet work.
> Is the rgb output correct? It looks as if seen through a
> strange colour filter, do you think this is intended?
>

I haven't looked at this for nearly a year but at the time all samples I
had looked correct.
Except some macroblocks which used DPCM were not decodable for the reasons
I described previously (impossible to fit this into mpegvideo.c).
I will look at this again over the Christmas holidays.

Regards,
Kieran
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Carl Eugen Hoyos
2017-11-04 21:27 GMT+01:00 Kieran Kunhya :

> I need to remove MPEG-4 support from mpegvideo in order
> to upstream the following code:
> https://github.com/kierank/ffmpeg-sstp

Decoding of the yuv422p10 samples does not yet work.
Is the rgb output correct? It looks as if seen through a
strange colour filter, do you think this is intended?

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread James Almer
On 11/4/2017 5:27 PM, Kieran Kunhya wrote:
> Hello,
> 
> I need to remove MPEG-4 support from mpegvideo in order to upstream the
> following code:
> https://github.com/kierank/ffmpeg-sstp
> 
> I'll need to extract mpeg4video from mpegvideo for the following reasons in
> the Studio Profile:
> 
> - 10-bit video, mpegvideo.c is entirely 8-bit, I'll need to write a new
> idct or use an existing (e.g ProRes) if applicable
> - DPCM mode (a bit like h264's mode)
> 
> In particular I think this will break lowres. Is this ok or will the patch
> be blocked?
> 

lowres is deprecated and the only reason it wasn't removed during this
major bump was because i couldn't feasibly find a way to untangle it
from the rest of the codebase, and no one else answered my call for help
when i sent the major bump patch two months ago.

The unstable ABI period is still open, for that matter, so if you or
anyone else feels like giving it a try then there's still a couple weeks
to remove it as originally scheduled.
Otherwise, it will be removed next year or so alongside AVStream->codec.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel