Re: [FFmpeg-devel] FFserver bug?
On 05.11.2014 02:15, Lukasz Marek wrote: On 31.10.2014 02:14, Sevan Gelici wrote: Hi, Two days ago i updated my linux system and also ffmpeg was updated. When i started to stream it was not working anymore. I am using ffserver. i determined the problem which causes the problem thats the bitrate it makes like 50mb of it. i reinstalled the system a couple times because of some tests and still i don't get it work. Can someone help me with this pls. I fixed it on 2.3 release branch. I know this should be done on master first, but I wanted to be close for the commit that introduced the problem. There are some changes in later releases so cherry-pick would not be enough tho, to fix it on previous release Fix patches attached. I see I was very tired yesterday :) I sent updated patch for master branch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
W dniu środa, 5 listopada 2014 Michael Niedermayer napisał(a): > On Wed, Nov 05, 2014 at 12:07:14AM +0100, Lukasz Marek wrote: > > On 31.10.2014 03:19, Michael Niedermayer wrote: > > >On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: > > >>Hi, > > >> > > >>Two days ago i updated my linux system and also ffmpeg was updated. > When i > > >>started to stream it was not working anymore. I am using ffserver. i > > >>determined the problem which causes the problem thats the bitrate it > makes > > >>like 50mb of it. i reinstalled the system a couple times because of > some > > >>tests and still i don't get it work. Can someone help me with this pls. > > > > > >do you know which commit / revission has caused the regression ? > > > > I wanted to learn git bisect and checked it. > > > > Last working rev is f478e8500a3d1fb0c6014956de42d87e292b9e3b > > > > The issue is present at next merge commit: > > 9b7cb02319b65596b5ef106a830fd813248fb580 > > > but it segfaults. It can be fixed by cherry-picking: > > 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d > > git show 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d > fatal: bad object 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d > I probably copied from picked. this should be the correct one. e0d074556055e8d2ed706be100e26d7bb6864d6e > > > > Maybe worth to mention I recently created function to dump > > AvCodecContext, to test if ffm is transmitting context properly. And > > strange thing I noticed ffm demuxer's read_header callback is called > > only once, even though there are 2 streams. I haven't investigate it > > further yet, but it smells like a bug in ffmpeg tool. > > > > > BTW, during bisecting sometimes I landed in libav's tree (when > > merged commit was tested) Some one know how to avoid that? > > see tools/bisect-create > OK, thx ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On 31.10.2014 02:14, Sevan Gelici wrote: Hi, Two days ago i updated my linux system and also ffmpeg was updated. When i started to stream it was not working anymore. I am using ffserver. i determined the problem which causes the problem thats the bitrate it makes like 50mb of it. i reinstalled the system a couple times because of some tests and still i don't get it work. Can someone help me with this pls. I fixed it on 2.3 release branch. I know this should be done on master first, but I wanted to be close for the commit that introduced the problem. There are some changes in later releases so cherry-pick would not be enough tho, to fix it on previous release Fix patches attached. >From 9c1455bd9e830aedba645451b7c0cb44831658e2 Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Wed, 5 Nov 2014 02:10:24 +0100 Subject: [PATCH 1/2] lavc/options: don't free options while they are still in use Signed-off-by: Lukasz Marek --- libavcodec/options.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 64b27e5..a13f3e3 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -181,8 +181,6 @@ int avcodec_copy_context(AVCodecContext *dest, const AVCodecContext *src) return AVERROR(EINVAL); } -av_opt_free(dest); - memcpy(dest, src, sizeof(*dest)); dest->priv_data = orig_priv_data; -- 1.9.1 >From 3425953e04113a37a6b54217bc2254a76405e7f7 Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Wed, 5 Nov 2014 01:58:59 +0100 Subject: [PATCH 2/2] ffmpeg_opt: set correct priv_data for feed stream new_output_stream creates a codec context with arbitraty picked codec. Later data is updated, but priv_data are left alone. There is a bit chance there is a mismatch between codecs. Signed-off-by: Lukasz Marek --- ffmpeg_opt.c | 4 1 file changed, 4 insertions(+) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index a825062..97056e8 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -1636,6 +1636,10 @@ static int read_ffserver_streams(OptionsContext *o, AVFormatContext *s, const ch memcpy(st->info, ic->streams[i]->info, sizeof(*st->info)); st->codec= avctx; avcodec_copy_context(st->codec, ic->streams[i]->codec); +av_opt_free(st->codec); +av_free(st->codec->priv_data); +st->codec->priv_data = ic->streams[i]->codec->priv_data; +ic->streams[i]->codec->priv_data = NULL; if (st->codec->codec_type == AVMEDIA_TYPE_AUDIO && !ost->stream_copy) choose_sample_fmt(st, codec); -- 1.9.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On Wed, Nov 05, 2014 at 12:07:14AM +0100, Lukasz Marek wrote: > On 31.10.2014 03:19, Michael Niedermayer wrote: > >On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: > >>Hi, > >> > >>Two days ago i updated my linux system and also ffmpeg was updated. When i > >>started to stream it was not working anymore. I am using ffserver. i > >>determined the problem which causes the problem thats the bitrate it makes > >>like 50mb of it. i reinstalled the system a couple times because of some > >>tests and still i don't get it work. Can someone help me with this pls. > > > >do you know which commit / revission has caused the regression ? > > I wanted to learn git bisect and checked it. > > Last working rev is f478e8500a3d1fb0c6014956de42d87e292b9e3b > > The issue is present at next merge commit: > 9b7cb02319b65596b5ef106a830fd813248fb580 > but it segfaults. It can be fixed by cherry-picking: > 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d git show 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d fatal: bad object 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d > > Maybe worth to mention I recently created function to dump > AvCodecContext, to test if ffm is transmitting context properly. And > strange thing I noticed ffm demuxer's read_header callback is called > only once, even though there are 2 streams. I haven't investigate it > further yet, but it smells like a bug in ffmpeg tool. > > BTW, during bisecting sometimes I landed in libav's tree (when > merged commit was tested) Some one know how to avoid that? see tools/bisect-create [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On 05.11.2014 00:07, Lukasz Marek wrote: Maybe worth to mention I recently created function to dump AvCodecContext, to test if ffm is transmitting context properly. And strange thing I noticed ffm demuxer's read_header callback is called only once, even though there are 2 streams. I guess it is OK, ignore this remark ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On 31.10.2014 03:19, Michael Niedermayer wrote: On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: Hi, Two days ago i updated my linux system and also ffmpeg was updated. When i started to stream it was not working anymore. I am using ffserver. i determined the problem which causes the problem thats the bitrate it makes like 50mb of it. i reinstalled the system a couple times because of some tests and still i don't get it work. Can someone help me with this pls. do you know which commit / revission has caused the regression ? I wanted to learn git bisect and checked it. Last working rev is f478e8500a3d1fb0c6014956de42d87e292b9e3b The issue is present at next merge commit: 9b7cb02319b65596b5ef106a830fd813248fb580 but it segfaults. It can be fixed by cherry-picking: 24a324855cbdb8d1be3ac2cc5e22d007c38d7c8d Maybe worth to mention I recently created function to dump AvCodecContext, to test if ffm is transmitting context properly. And strange thing I noticed ffm demuxer's read_header callback is called only once, even though there are 2 streams. I haven't investigate it further yet, but it smells like a bug in ffmpeg tool. BTW, during bisecting sometimes I landed in libav's tree (when merged commit was tested) Some one know how to avoid that? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On date Monday 2014-11-03 00:25:54 +0100, Lukasz Marek encoded: [...] > Offtopic: > regarding config: partitions, directpred (it should be direct-pred), > wpredp are x264 options and ffserver doesn't send them to ffmpeg > that serves a stream. Any private option for any codec is not > supported yet. They have no meaning and now they are treated as > errors. > (in near future I will add posibility to set them) I'm curious about that, since that was in my (much neglected) todo list. How do you plan to do that? The only way I see is to fiddle with FFM. -- FFmpeg = Formidable and Fast Mysterious Picky Eccentric Guru ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On 02.11.2014 23:34, Sevan Gelici wrote: I still don't have tested old gits. But i will try to expain. A half year ago i installed ffmpeg and i made a configuration file. When i start this bitrate was going up to 2000kbs max. I updated and now it will go higher like its sum up or something, in some seconds the content bitrate will be 40 mb and still go higher. I also reinstalled the system. Maybe my configuration is old and that causes the problem. Offtopic: regarding config: partitions, directpred (it should be direct-pred), wpredp are x264 options and ffserver doesn't send them to ffmpeg that serves a stream. Any private option for any codec is not supported yet. They have no meaning and now they are treated as errors. (in near future I will add posibility to set them) Also VideoGopSize is as alias for AVOptionVideo g But this doesn't cause the issue anyway. I noticed that commenting out VideoSize 1280x720 reduces bitrate back to 1500kbit/s which is correct. Why setting VideoSize has such strange effect - I dont know. I just checked ffserver and ffm format and there is everything ok with these width and height. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
I still don't have tested old gits. But i will try to expain. A half year ago i installed ffmpeg and i made a configuration file. When i start this bitrate was going up to 2000kbs max. I updated and now it will go higher like its sum up or something, in some seconds the content bitrate will be 40 mb and still go higher. I also reinstalled the system. Maybe my configuration is old and that causes the problem. I will do some more extra tests and i will tell you. Op 2 nov. 2014 22:52 schreef "Reynaldo H. Verdejo Pinochet" < reyna...@osg.samsung.com>: > Hi. I'm afraid I don't understand what the problem is. Can > someone elaborate? > > Bests, > > -- > Reynaldo H. Verdejo Pinochet > Open Source Group > Samsung Research America / Silicon Valley > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
Hi. I'm afraid I don't understand what the problem is. Can someone elaborate? Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On 31 October 2014 03:19, Michael Niedermayer wrote: > On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: > > Hi, > > > > Two days ago i updated my linux system and also ffmpeg was updated. When > i > > started to stream it was not working anymore. I am using ffserver. i > > determined the problem which causes the problem thats the bitrate it > makes > > like 50mb of it. i reinstalled the system a couple times because of some > > tests and still i don't get it work. Can someone help me with this pls. > > do you know which commit / revission has caused the regression ? > At first moment I thought I messed something with configuration code, but it reproducible before my recent changes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] FFserver bug?
On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: > Hi, > > Two days ago i updated my linux system and also ffmpeg was updated. When i > started to stream it was not working anymore. I am using ffserver. i > determined the problem which causes the problem thats the bitrate it makes > like 50mb of it. i reinstalled the system a couple times because of some > tests and still i don't get it work. Can someone help me with this pls. do you know which commit / revission has caused the regression ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB DNS cache poisoning attacks, popular search engine, Google internet authority dont be evil, please signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
