Re: [FFmpeg-devel] avformat: QuickTime Sample Description Table 'corruption' with ACLR atom.
On Fri, Feb 13, 2015 at 02:43:13PM +, Kevin Wheatley wrote: Hi, currently when writing ACLR atoms to .mov's there is a 'corruption' caused by the function mov_write_avid_tag() writing an additional 4 bytes of zero's. this is potentially then followed by other atoms colr and pasp. Looking at the specifications it appears this 4 bytes is supposed to occur at the end of the stsd if at all, as it is optional. I'm working on a patch to fix the 'corruption' but wondered how to handle the optional terminator: 1) Don't write one ever 2) Write one if requested by adding a flag to -movflags stdsterminator 3) Write one by default, add a 'nostdsterminator' flag (needs a better name) 4) always write one. I'm favouring 2 or 3 what difference does the terminator make ? does it improve compatibility with other software ? Currently I've done option 1 see https://github.com/KevinJW/FFmpeg/compare/mov_dnxhd_stsd_corruption Thanks Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avformat: QuickTime Sample Description Table 'corruption' with ACLR atom.
OK I'll proceed with that. Thanks Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avformat: QuickTime Sample Description Table 'corruption' with ACLR atom.
On Fri, Feb 13, 2015 at 04:34:37PM +, Kevin Wheatley wrote: On Fri, Feb 13, 2015 at 3:06 PM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Feb 13, 2015 at 02:43:13PM +, Kevin Wheatley wrote: what difference does the terminator make ? does it improve compatibility with other software ? I believe there are some versions of Apple's Final Cut that need the terminator, I've also been wondering if mp4 has the same needs but I don't have the spec to cross check. if compatibility is better with it and it doesnt break anything then it should be added ba default [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avformat: QuickTime Sample Description Table 'corruption' with ACLR atom.
On Fri, Feb 13, 2015 at 3:06 PM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Feb 13, 2015 at 02:43:13PM +, Kevin Wheatley wrote: what difference does the terminator make ? does it improve compatibility with other software ? I believe there are some versions of Apple's Final Cut that need the terminator, I've also been wondering if mp4 has the same needs but I don't have the spec to cross check. Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] avformat: QuickTime Sample Description Table 'corruption' with ACLR atom.
I've rebased the patch against current master, it is a lot of FATE changes due to the extra 4 bytes... It should now merge appropriately, see https://github.com/FFmpeg/FFmpeg/pull/110 Please let me know if anything needs tweaking Thanks Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
