Re: [FFmpeg-user] Enable all audio tracks for MOV container

2016-08-09 Thread Robert Krüger
On Tue, Jul 19, 2016 at 11:39 PM, Christian Johannesen <
chrisjohanne...@gmail.com> wrote:

> On Tue, Jul 19, 2016 at 4:07 PM, Rens Dijkshoorn <r...@offlinemedia.nl>
> wrote:
>
> > - Original Message -
> > > From: "Christian Johannesen" <chrisjohanne...@gmail.com>
> > > To: "FFmpeg user questions" <ffmpeg-user@ffmpeg.org>
> > > Sent: Tuesday, 19 July, 2016 21:41:48
> > > Subject: [FFmpeg-user] Enable all audio tracks for MOV container
> >
> > > Hi all -
> > >
> > > I had been using a patch from this mailing list on the FFMPEG source
> code
> > > to enable all audio tracks when encoding QuickTime MOV.
> > >
> > >
> > > However, it seems as though this no longer works as movenc has been
> > > modified since it last worked for me with source code from March 25th
> > 2016.
> > > Is there a way to enable all audio tracks when encoding a MOV with the
> > > current source or does anyone have an updated patch?
> > >
> > > Thanks,
> > > Chris
> >
> > Hi Chris,
> >
> > this is my update patch, should work with current GIT version.
> >
> > Regards
> >
> > Rens
> >
>
> Hi Rens,
>
> Appreciate the help! Your updated patch worked for me and all tracks are
> enabled after patching and compiling the most recent source.
>
> Thanks,
> Chris
>
> Hi,

before I start using the patch myself (thanks for the patch, btw.), just
asking the obvious question. Was this discussed as a patch and rejected? At
least having it as a muxer or command line option seems to be a better
solution than not having it at all in master as there are obviously use
cases for it out there.

Thanks,
Robert
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-user] Enable all audio tracks for MOV container

2016-07-19 Thread Christian Johannesen
On Tue, Jul 19, 2016 at 4:07 PM, Rens Dijkshoorn <r...@offlinemedia.nl>
wrote:

> - Original Message -
> > From: "Christian Johannesen" <chrisjohanne...@gmail.com>
> > To: "FFmpeg user questions" <ffmpeg-user@ffmpeg.org>
> > Sent: Tuesday, 19 July, 2016 21:41:48
> > Subject: [FFmpeg-user] Enable all audio tracks for MOV container
>
> > Hi all -
> >
> > I had been using a patch from this mailing list on the FFMPEG source code
> > to enable all audio tracks when encoding QuickTime MOV.
> >
> >
> > However, it seems as though this no longer works as movenc has been
> > modified since it last worked for me with source code from March 25th
> 2016.
> > Is there a way to enable all audio tracks when encoding a MOV with the
> > current source or does anyone have an updated patch?
> >
> > Thanks,
> > Chris
>
> Hi Chris,
>
> this is my update patch, should work with current GIT version.
>
> Regards
>
> Rens
>

Hi Rens,

Appreciate the help! Your updated patch worked for me and all tracks are
enabled after patching and compiling the most recent source.

Thanks,
Chris
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-user] Enable all audio tracks for MOV container

2016-07-19 Thread Rens Dijkshoorn
- Original Message -
> From: "Christian Johannesen" <chrisjohanne...@gmail.com>
> To: "FFmpeg user questions" <ffmpeg-user@ffmpeg.org>
> Sent: Tuesday, 19 July, 2016 21:41:48
> Subject: [FFmpeg-user] Enable all audio tracks for MOV container

> Hi all -
> 
> I had been using a patch from this mailing list on the FFMPEG source code
> to enable all audio tracks when encoding QuickTime MOV.
> 
> 
> However, it seems as though this no longer works as movenc has been
> modified since it last worked for me with source code from March 25th 2016.
> Is there a way to enable all audio tracks when encoding a MOV with the
> current source or does anyone have an updated patch?
> 
> Thanks,
> Chris

Hi Chris,

this is my update patch, should work with current GIT version. 

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index d614933..a30916b 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2410,6 +2410,10 @@ static int mov_write_tkhd_tag(AVIOContext *pb, 
MOVMuxContext *mov,
 (version == 1) ? avio_wb32(pb, 104) : avio_wb32(pb, 92); /* size */
 ffio_wfourcc(pb, "tkhd");
 avio_w8(pb, version);
+if (track->par->codec_type == AVMEDIA_TYPE_AUDIO ||
+track->par->codec_type == AVMEDIA_TYPE_DATA) /* enable all audio & 
data tracks */
+avio_wb24(pb, 0xf);
+else
 avio_wb24(pb, flags);
 if (version == 1) {
 avio_wb64(pb, track->time);
@@ -2430,7 +2434,7 @@ static int mov_write_tkhd_tag(AVIOContext *pb, 
MOVMuxContext *mov,
 avio_wb32(pb, 0); /* reserved */
 avio_wb32(pb, 0); /* reserved */
 avio_wb16(pb, 0); /* layer */
-avio_wb16(pb, group); /* alternate group) */
+avio_wb16(pb, 0x0); /* set alternate group 0 as default ) */
 /* Volume, only for audio */
 if (track->par->codec_type == AVMEDIA_TYPE_AUDIO)
 avio_wb16(pb, 0x0100);

Regards

Rens
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-user] Enable all audio tracks for MOV container

2016-07-19 Thread Christian Johannesen
Hi all -

I had been using a patch from this mailing list on the FFMPEG source code
to enable all audio tracks when encoding QuickTime MOV.

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index b6821d4..136adae 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2315,6 +2315,10 @@ static int mov_write_tkhd_tag(AVIOContext *pb,
MOVMuxContext *mov,
 (version == 1) ? avio_wb32(pb, 104) : avio_wb32(pb, 92); /* size */
 ffio_wfourcc(pb, "tkhd");
 avio_w8(pb, version);
+if (track->enc->codec_type == AVMEDIA_TYPE_AUDIO ||
+track->enc->codec_type == AVMEDIA_TYPE_DATA) /* enable all audio &
data tracks */
+avio_wb24(pb, 0xf);
+else
 avio_wb24(pb, flags);
 if (version == 1) {
 avio_wb64(pb, track->time);
@@ -2335,7 +2339,7 @@ static int mov_write_tkhd_tag(AVIOContext *pb,
MOVMuxContext *mov,
 avio_wb32(pb, 0); /* reserved */
 avio_wb32(pb, 0); /* reserved */
 avio_wb16(pb, 0); /* layer */
-avio_wb16(pb, group); /* alternate group) */
+avio_wb16(pb, 0x0); /* set alternate group 0 as default ) */
 /* Volume, only for audio */
 if (track->enc->codec_type == AVMEDIA_TYPE_AUDIO)
 avio_wb16(pb, 0x0100);

However, it seems as though this no longer works as movenc has been
modified since it last worked for me with source code from March 25th 2016.
Is there a way to enable all audio tracks when encoding a MOV with the
current source or does anyone have an updated patch?

Thanks,
Chris
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".