Re: [Firebird-devel] rpmbuild is still used in 2.5 branch
I have added a new pull request for 2.5 branch in .travis.yml i have commented the make dist (doesn't make sense to install it if we don't run tests on it , and rpmbuild is broken on ubuntu distros ) https://github.com/FirebirdSQL/firebird/pull/124 On Thu, Oct 26, 2017 at 9:08 PM, Alex Peshkoff via Firebird-devel < firebird-devel@lists.sourceforge.net> wrote: > On 10/26/17 18:13, marius adrian popa wrote: > >> rpm build failed on travis when doing make dist >> >> so I will redo the pull request >> >> > Marius, just please do not try to place a cart in front of a horse. > Changing FB built order, specially for version that people use for many > years, is not good idea. Certainly if you add PR changing travis-only build > (a kind of pre-travis patch removing rpm for travis build only) I see no > problems. If it's hard to achieve add new target into makefile that will do > all what you need (build dist w/o rpmfile) but please don't change behavior > of existing rules. > > > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > Firebird-Devel mailing list, web interface at > https://lists.sourceforge.net/lists/listinfo/firebird-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdotFirebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] rpmbuild is still used in 2.5 branch
On 10/26/17 18:13, marius adrian popa wrote: rpm build failed on travis when doing make dist so I will redo the pull request Marius, just please do not try to place a cart in front of a horse. Changing FB built order, specially for version that people use for many years, is not good idea. Certainly if you add PR changing travis-only build (a kind of pre-travis patch removing rpm for travis build only) I see no problems. If it's hard to achieve add new target into makefile that will do all what you need (build dist w/o rpmfile) but please don't change behavior of existing rules. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] rpmbuild is still used in 2.5 branch
rpm build failed on travis when doing make dist so I will redo the pull request On Thu, Oct 26, 2017 at 6:06 PM, Alex Peshkoff via Firebird-devel < firebird-devel@lists.sourceforge.net> wrote: > On 10/26/17 18:00, marius adrian popa wrote: > >> i have seen that is deprecated in 3.0/4.0 so i wanted to cleanup also in >> 2.5 branch >> >> > Bad and wrong desire. > If feature XXX is removed from version N it does not mean that it should > be removed from N-1 too. > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > Firebird-Devel mailing list, web interface at > https://lists.sourceforge.net/lists/listinfo/firebird-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdotFirebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] rpmbuild is still used in 2.5 branch
On 10/26/17 18:00, marius adrian popa wrote: i have seen that is deprecated in 3.0/4.0 so i wanted to cleanup also in 2.5 branch Bad and wrong desire. If feature XXX is removed from version N it does not mean that it should be removed from N-1 too. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
[Firebird-devel] rpmbuild is still used in 2.5 branch
i have seen that is deprecated in 3.0/4.0 so i wanted to cleanup also in 2.5 branch -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdotFirebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
