[Firebird-net-provider] Parameter check

2015-09-30 Thread Jiří Činčura 
Hi *,

I'm looking at
https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/blob/master/NETProvider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbParameterCollection.cs#L379
and I have a strong feeling the check is not correct. The check should
contain `value.ParameterName`, isn't it? Or am I spinning in my own
circles...

-- 
Mgr. Jiří Činčura
Independent IT Specialist

--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider

Re: [Firebird-net-provider] Parameter check

2015-09-30 Thread Jiří Činčura 
OK, glad to be right. It looked too simple to be true. Fixing.

-- 
Mgr. Jiří Činčura
Independent IT Specialist

--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider

Re: [Firebird-net-provider] Parameter check

2015-09-30 Thread Amro El-Fakharany 
Hi Jiri,
you're not spinning circles. 
Either the check should be value.ParameterName or FbParameter should override 
the Equals() method accordingly.


> -Ursprüngliche Nachricht-
> Von: Jiří Činčura [mailto:j...@cincura.net]
> Gesendet: Mittwoch, 30. September 2015 08:12
> An: firebird-net-provider@lists.sourceforge.net
> Betreff: [Firebird-net-provider] Parameter check
> 
> Hi *,
> 
> I'm looking at
> https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/blob/master/
> NETProvider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbParameterC
> ollection.cs#L379
> and I have a strong feeling the check is not correct. The check should contain
> `value.ParameterName`, isn't it? Or am I spinning in my own circles...
> 
> --
> Mgr. Jiří Činčura
> Independent IT Specialist
> 
> --
> ___
> Firebird-net-provider mailing list
> Firebird-net-provider@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/firebird-net-provider


--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider