[flac-dev] Meet the new maintainer
Hi all, Some time ago, I foolishly agreed to become the maintainer of FLAC, the Free Lossless Audio Codec. The original author and maintainer Josh Coalson has been MIA since early 2009. The code has been moved to the Xiph.org git repo and I'll be trying to spend an hour a day on it until I get a backlog of patches reviewed, tweaked and applied. The main problem is that the FLAC test suite takes 30 minutes to run on a 2.8 GHz Core II Duo. The gt repo is here: https://git.xiph.org/?p=flac.git;a%3Dsummary I encourage the keen to do a daily checkout and build. I will be building it on x86 and amd64 Linux every day and running the full test suite. Looking for someone to do that on Mac and Windows. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
JonY wrote: Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format warnings suppressed. JonY, Sorry for the delay on actually getting on to this. I tried your patch, but it wasn't quite right. The problem is that %ll is the correct format specifier for uint64_t on 32bit Linux but not on 64 bit Linux. In C99, the correct way to print a uint64_t value is: printf (THe value is : PRIu64 \n, value) ; I have gone ahead and fixed this through the code and fixed this, but I may have broken some either MSVC or MinGW on the way. I'd appreciate it if you test whats in git now. For those files where any compiler baulks at the PRIu64/PRIx64/PRId64, you should add a #ifdef block that might look something like: #ifdef HAVE_INTTYPES_H #include inttypes.h #else #if defined (_MSC_VER) ! defined (PRId64) #define PRId64 I64d #endif #if defined (_MSC_VER) ! defined (PRIu64) #define PRIu64 I64u #endif #endif We'll worry about compilers that don't have the PRI_64 values as we find them. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
Bastiaan Timmer wrote: Well, I have been away a couple of days, so I don't know if I'm in time, but I reported a memory leak and submitted a patch a couple of months ago. It would be nice if it can make it in. I first reported the leak here: http://lists.xiph.org/pipermail/flac-dev/2011-August/003002.html And the patch is here: http://sourceforge.net/tracker/?func=detailaid=3390048group_id=13478atid=313478 I've applied that patch. Thanks. I'll be working my way through the rest on SF.net in next week or two. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
[some snips] tweaked and applied. The main problem is that the FLAC test suite takes 30 minutes to run on a 2.8 GHz Core II Duo. I encourage the keen to do a daily checkout and build. I will be building it on x86 and amd64 Linux every day and running the full test suite. Looking for someone to do that on Mac and Windows. I'd be happy to help with Windows - I have the following: - XP SP3, 32-bit - W7 SP1, 64-bit Cheers, Martin ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
LRN wrote: Is it wise to aim at C99? While i have absolutely nothing against it, it is a known fact that MS never got around to support C99 in MSVC to any considerable degree. The idea is to only use the bits of C99 that can be worked around in MSVC with #ifdefs and #defines. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] xiph flac git build fails out of the box
Avuton Olrich wrote: Not sure where bug reports are going yet. Right here. I'd love to try to cross-compile with mingw, I too would be very keen for that to work. I'm also pretty sure I can fix it as I cross compile libsndfile from linux to windows regularly. I suspect that FLAC's configure and build stuff is a little crufty as it hasn't really been touched in 3 years. I'll put this on the TODO list. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
rapp...@dds.nl wrote: [some snips] tweaked and applied. The main problem is that the FLAC test suite takes 30 minutes to run on a 2.8 GHz Core II Duo. I encourage the keen to do a daily checkout and build. I will be building it on x86 and amd64 Linux every day and running the full test suite. Looking for someone to do that on Mac and Windows. I'd be happy to help with Windows - I have the following: - XP SP3, 32-bit - W7 SP1, 64-bit I'm particularly interested in seeing the results of compiling FLAC under MSVC and would love to see good quality patches. Erik PS : I'm on the list. Please don't CC me when replying. -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
On 2/1/2012 18:52, Erik de Castro Lopo wrote: JonY wrote: Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format warnings suppressed. JonY, Sorry for the delay on actually getting on to this. I tried your patch, but it wasn't quite right. The problem is that %ll is the correct format specifier for uint64_t on 32bit Linux but not on 64 bit Linux. Something is very very wrong about the above statements. I thought I used PRI?64 when inttypes.h is found (Linux should have it, old code uses %ll? anyway for non-msvc, so shouldn't have any new issues). inttypes.h and stdint.h is supposed to be abstractions to remove these issues. In C99, the correct way to print a uint64_t value is: printf (THe value is : PRIu64 \n, value) ; I have gone ahead and fixed this through the code and fixed this, but I may have broken some either MSVC or MinGW on the way. I'd appreciate it if you test whats in git now. For those files where any compiler baulks at the PRIu64/PRIx64/PRId64, you should add a #ifdef block that might look something like: #ifdef HAVE_INTTYPES_H #include inttypes.h #else #if defined (_MSC_VER) ! defined (PRId64) #define PRId64 I64d #endif #if defined (_MSC_VER) ! defined (PRIu64) #define PRIu64 I64u #endif #endif We'll worry about compilers that don't have the PRI_64 values as we find them. OK, I'll do a quick test build tomorrow. More thorough testing will come during the weekends. signature.asc Description: OpenPGP digital signature ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
rapp...@dds.nl wrote: I'm particularly interested in seeing the results of compiling FLAC under MSVC and would love to see good quality patches. It's been a while since I've worked with Visual Studio, so some dumb questions ahead. To start: should I use http://www.microsoft.com/visualstudio/en-us/products/2010-editions/visual-cpp-express, or something else? Err, I'm not sure. The last time I used windows in anger was the year 2000. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
JonY wrote: Sorry for the delay on actually getting on to this. I tried your patch, but it wasn't quite right. The problem is that %ll is the correct format specifier for uint64_t on 32bit Linux but not on 64 bit Linux. Something is very very wrong about the above statements. I thought I used PRI?64 when inttypes.h is found (Linux should have it, old code uses %ll? anyway for non-msvc, so shouldn't have any new issues). I think that may have been because configure was not detecting inttypes.h when I first tested that patch. inttypes.h and stdint.h is supposed to be abstractions to remove these issues. For the inttypes.h and stdint.h problem the way I usually prefer to tackle it is: a) Assume they are there. b) When they aren't, add the required #ifdef/#define nonsense to define them for the compiler when they are missing. OK, I'll do a quick test build tomorrow. More thorough testing will come during the weekends. Cool, thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
On 1 February 2012 04:30, rapp...@dds.nl wrote: It's been a while since I've worked with Visual Studio, so some dumb questions ahead. To start: should I use http://www.microsoft.com/visualstudio/en-us/products/2010-editions/visual-cpp-express, or something else? That's a fine place to start if you have windows but don't already have a copy of the microsoft compiler. -r -- Ralph Giles Xiph.org Foundation for open multimedia ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
Everything you need is in Visual Studio Express for C++ dev. Not sure why the complaint about an MS tax. -- Raymond Edwards On Wednesday, 1 February, 2012 at 3:58 PM, rapp...@dds.nl wrote: I'm particularly interested in seeing the results of compiling FLAC under MSVC and would love to see good quality patches. It's been a while since I've worked with Visual Studio, so some dumb questions ahead. To start: should I use http://www.microsoft.com/visualstudio/en-us/products/2010-editions/visual-cpp-express, or something else? Err, I'm not sure. The last time I used windows in anger was the year 2000. Hehe. I'll get cracking this weekend. Since the last FLAC release was 2007, I assume an earlier VC++ release will do as well - I just want to avoid the M$ tax which is really hefty for their full-blown IDE. ___ flac-dev mailing list flac-dev@xiph.org (mailto:flac-dev@xiph.org) http://lists.xiph.org/mailman/listinfo/flac-dev ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
It's been a while since I've worked with Visual Studio, so some dumb questions ahead. To start: should I use http://www.microsoft.com/visualstudio/en-us/products/2010-editions/visual-cpp-express, or something else? That's a fine place to start if you have windows but don't already have a copy of the microsoft compiler. Just checked, and I already have Microsoft Visual C++ 2005 Redistributable installed - probably part of the cruft of Windows Update. Will try with that first. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
On 1 February 2012 01:55, Erik de Castro Lopo mle...@mega-nerd.com wrote: Some time ago, I foolishly agreed to become the maintainer of FLAC, Thank you, Erik! Please find attached to patches which fix 'make dist' Unfortunately 'make distcheck' still fails, because test scripts don't work with out-of-tree builds. I have a partial fix for that, but I think it would be better to hoist most of the shell scripts into make and use the automake test support instead. The code has been moved to the Xiph.org git repo and I'll be trying to spend an hour a day on it until I get a backlog of patches reviewed, tweaked and applied. The main problem is that the FLAC test suite takes 30 minutes to run on a 2.8 GHz Core II Duo. I added a job to our jenkins continuous integration thing. Right now it doesn't test any more than you're proposing to do, but the results are public, which can be helpful. FWIW, -r 0001-Use-the-correct-project-filenames-for-flactimer.patch Description: Binary data 0002-Add-test_wrapper.sh-to-the-distribution.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Meet the new maintainer
On 1 February 2012 14:00, Ralph Giles gi...@thaumas.net wrote: I added a job to our jenkins continuous integration thing. Right now it doesn't test any more than you're proposing to do, but the results are public, which can be helpful. Er, which results are available at https://mf4.xiph.org/jenkins/job/flac/ Currently the build is failing on 'make distcheck' -r ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [flac-git] Install fails with --disable-doxygen-docs
Avuton Olrich wrote: On Wed, Feb 1, 2012 at 7:12 PM, Avuton Olrich avu...@gmail.com wrote: Latest git [3b41451197f2cc7afb13753caaccbadaa74eca32] cross compiles perfect without patches (this is the first time I've seen this with any flac tree). Install fails with --disable-doxygen-docs; it's probably easy to fix, but here's the problem: Well, had I knew it would be this easy to fix I would have just posted a fix. Please pull git://github.com/avuton/flac.git Thanks Avuton. Applied. In future, I'd prefer to have git format-patch formated patches sent to the mailing list so I can inspect them a little easier before applying them. This one was ok, because it was so obviously corrct. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] The XMMS plugin
Hi all, Anyone care if I kill off the XMMS plugin? I think XMMS is pretty much dead and the xmms-config script is no longer in Debian. I think its been replaced with XMMS2. If anyone cares about this, they should let us know and help us figure out how to compile and test it on a current Debian or Ubuntu system. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
