Re: [flac-dev] Testing needed
On 02/26/12 10:58 pm, Erik de Castro Lopo wrote: If you're interested in pursuing this please try changing line 175 of src/share/utf8/iconvert.c from: k = iconv(cd2, 0, 0, ob, obl); to: k = iconv(cd2, 0, 0, (const char**) ob, obl); and seeing if there is a warning with the replacement. Shouldn't that be changing k = iconv(cd2, ib, ibl, ob, obl); to k = iconv(cd2,(const char**) ib, ibl, ob, obl); which here gets rid of the warning on line 175. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Testing needed
On 02/26/12 10:37 pm, Erik de Castro Lopo wrote: Dave Yeo wrote: Couple of simple patches attached. Patches applied. Thanks. I also see that static builds are now broken, alloc.c:37 (../../src/share/grabbag/.libs/grabbag.a(alloc.o)): Definition of symbol _safe_malloc_mul_2op_ (multiply defined) memory.c:224 (../../src/libFLAC/.libs/FLAC.a(memory.o)): Definition of symbol _safe_malloc_mul_2op_ (multiply defined) make.exe[3]: *** [metaflac.exe] Error 1 Haven't looked into it yet as it is bed time here. Thanks Dave ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Testing needed
Dave Yeo wrote: I also see that static builds are now broken, alloc.c:37 (../../src/share/grabbag/.libs/grabbag.a(alloc.o)): Definition of symbol _safe_malloc_mul_2op_ (multiply defined) memory.c:224 (../../src/libFLAC/.libs/FLAC.a(memory.o)): Definition of symbol _safe_malloc_mul_2op_ (multiply defined) make.exe[3]: *** [metaflac.exe] Error 1 Haven't looked into it yet as it is bed time here. That was me. I'll fix it. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Testing needed
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27.02.2012 10:58, Erik de Castro Lopo wrote: LRN wrote: f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:175:5: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: expected 'const char **' but argument is of type 'char **' Firstly, what version of the mingw compiler are you using? mingw-gcc 4.6.2, with libiconv-1.13.1-1-mingw32-dev.tar.lzma package providing iconv.h This to me seems a big silly. From the error message I infer that the iconv function provided by mingw expects the argument to have type 'const char **' but the argument passed is of type 'char **'. However, it was my understanding that the C standard specified that conversions from 'char **' to 'const char **' should be allowed without warning. If you're interested in pursuing this Not interested. This is not the first time i see this, so there's nothing interesting in fixing this. Adding an #ifdef to cast the pointer as const char ** on W32 (or when using GNU libiconv) would fix the problem. In fact, [1] says that it IS const, so this is a GNU libiconv problem, not a MinGW problem. [1] http://www.gnu.org/savannah-checkouts/gnu/libiconv/documentation/libiconv-1.13/iconv.3.html -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPS5nOAAoJEOs4Jb6SI2Cwq20H/jN3OzIXKf1xCx3cpKFraUPS oXPLXzazj+XWa/GLnGxlhNy9gwayrxQ7a77fWh6sFr7r3v7hgz6TyxL+Wf+2NGud JoSmbu6DE98HMIRCFcMMBAKshrjAnrgiZXZM4SFI3CM6HrbXr+Pj49HGIN6Rgw5I pzHZ6Nr0+dIyCUSKtsIS0rX2vgUk/tyCSxVxUP9ESwTijEajwwI9LwzNTvka2bHh WGMlbbUQe4H9jGu9gbRCU2r9sWkN4/7ZjMgHERCNummIZtp61KczpmCJeLLX7SiL Vgqs/SpDKtvgt1GvfuNRrJyT1KvlXFYgmSgIFGpnXsqp4P+p3plOpE+2a20gtWA= =cVrV -END PGP SIGNATURE- ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Flac HiRes decoding problems
Hi Klaus, I'm not really sure where to start with this one. Klaus Schulz wrote: My first post over here. While working on a music server optimzation (which ususally goes hand in hand with running pretty low buffers on realtime streams) I figured that certain HiRez flacs were causing XRUNS/hickups on my Linux server platform. What is a HiRez flac? How does it differ from a regular flac? The interesting thing is to run into XRUNS even though the stream gets send to a Squeezebox Touch which got a 20s buffer on its receiving end. XRUNS are a kernel/music player thing and not really anything to do with the FLAC library. In order to better understand this issue, you need to separate the decoding from the playback. Do you have two files, one which rarely/never displays the problem and one which usually/always displays the problem? Are you able to post those files to a public website where I can retrieve them and test them? Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
