[flac-dev] [PATCH] Fix buffer overflow in metaflac

2012-04-04 Thread Cristian Rodríguez 
strlen() returns the length excluding the terminating null byte..then
an string of len 4 will be off-by-one in application_id[4];

GCC 4.7 detects this bug.
---
 src/metaflac/options.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/metaflac/options.c b/src/metaflac/options.c
index eb3498d..2cb0959 100644
--- a/src/metaflac/options.c
+++ b/src/metaflac/options.c
@@ -1040,7 +1040,7 @@ FLAC__bool parse_block_type(const char *in, 
Argument_BlockType *out)
out->entries[entry].type = 
FLAC__METADATA_TYPE_APPLICATION;
out->entries[entry].filter_application_by_id = (0 != r);
if(0 != r) {
-   if(strlen(r) == 4) {
+   if(strlen(r) == 3) {

strcpy(out->entries[entry].application_id, r);
}
else if(strlen(r) == 10 && strncmp(r, "0x", 2) 
== 0 && strspn(r+2, "0123456789ABCDEFabcdef") == 8) {
-- 
1.7.9.2

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Jenkins builds are failing

2012-04-04 Thread Erik de Castro Lopo 
Ralph Giles wrote:

> On 4 April 2012 04:54, Erik de Castro Lopo  wrote:
> 
> > Can you please check out whats happening here? See:
> >
> >    https://mf4.xiph.org/jenkins/job/flac/31/console
> 
> There were some permission problems in the jenkins working tree;
> probably my fault. I cleaned up a bit and build #34 passed.

Cool. Thanks Ralph.

Cheers,
Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Jenkins builds are failing

2012-04-04 Thread Ralph Giles 
On 4 April 2012 04:54, Erik de Castro Lopo  wrote:

> Can you please check out whats happening here? See:
>
>    https://mf4.xiph.org/jenkins/job/flac/31/console

There were some permission problems in the jenkins working tree;
probably my fault. I cleaned up a bit and build #34 passed.

 -r
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Erik de Castro Lopo 
Martijn van Beurden wrote:

> You can just take a look at the FLAC download page: 
> http://flac.sourceforge.net/download.html
> 
> There are links saying "FLAC full source code and Nightly CVS tarball".

The nightly CV tarball will not be of much use, the "FLAC full source
code" is exactly what the OP wants.

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Martijn van Beurden 
You can just take a look at the FLAC download page: 
http://flac.sourceforge.net/download.html


There are links saying "FLAC full source code and Nightly CVS tarball".

Op 04-04-12 14:30, Rafael Velasquez schreef:

I have also installe libflac-dev.
so, could you send me the good link please ?



2012/4/4 Erik de Castro Lopo >


Rafael Velasquez wrote:

> I have installed libflac via synaptic, the version is 1.2.1-3.

If you want to compile some other code against libflac, you also need
to install libflac-dev.

However, the code you posted a link to does not compile on it's own,
it requires other code in the source code tarball.

Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org 
http://lists.xiph.org/mailman/listinfo/flac-dev




___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Rafael Velasquez 
I have also installe libflac-dev.
so, could you send me the good link please ?



2012/4/4 Erik de Castro Lopo 

> Rafael Velasquez wrote:
>
> > I have installed libflac via synaptic, the version is 1.2.1-3.
>
> If you want to compile some other code against libflac, you also need
> to install libflac-dev.
>
> However, the code you posted a link to does not compile on it's own,
> it requires other code in the source code tarball.
>
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> ___
> flac-dev mailing list
> flac-dev@xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Erik de Castro Lopo 
Rafael Velasquez wrote:

> I have installed libflac via synaptic, the version is 1.2.1-3.

If you want to compile some other code against libflac, you also need
to install libflac-dev.

However, the code you posted a link to does not compile on it's own,
it requires other code in the source code tarball.

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Erik de Castro Lopo 
Rafael Velasquez wrote:

> My os is linux (Kubuntu).
> 
> What do u mean by grabbing the whole tarball ?

A tarball is a file with a .tar.gz or .tar.bz2 file extension that
in this case will contain the complete source code.

> The whole tarball that is here :
> http://flac.cvs.sourceforge.net/viewvc/flac/flac/ ?

No, you should try googling for "flac source code downlaod"

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Rafael Velasquez 
I have installed libflac via synaptic, the version is 1.2.1-3.

2012/4/4 Rafael Velasquez 

> My os is linux (Kubuntu).
>
> What do u mean by grabbing the whole tarball ?
>
> The whole tarball that is here :
> http://flac.cvs.sourceforge.net/viewvc/flac/flac/ ?
>
>
> 2012/4/4 Erik de Castro Lopo 
>
>> Rafael Velasquez wrote:
>>
>> > Hello, i'm new with Flac and C.
>>
>> What OS are you running on?
>>
>> > I download the example from your site (
>> > http://flac.cvs.sourceforge.net/viewvc/flac/flac/examples/).
>>
>> You cannot compile those examples without grabbing the whole FLAC
>> source code tarball.
>>
>> > I tried to compile the program in C by using : automake Makefile.am and
>> i
>> > have the next message :
>> > *`configure.ac' or `configure.in' is required*
>>
>> Why?
>>
>> Instructions for compiling the FLAC source code are contained
>> in the file named README in the top level directory of the FLAC
>> source code tarball.
>>
>> Erik
>> --
>> --
>> Erik de Castro Lopo
>> http://www.mega-nerd.com/
>> ___
>> flac-dev mailing list
>> flac-dev@xiph.org
>> http://lists.xiph.org/mailman/listinfo/flac-dev
>>
>
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Rafael Velasquez 
My os is linux (Kubuntu).

What do u mean by grabbing the whole tarball ?

The whole tarball that is here :
http://flac.cvs.sourceforge.net/viewvc/flac/flac/ ?

2012/4/4 Erik de Castro Lopo 

> Rafael Velasquez wrote:
>
> > Hello, i'm new with Flac and C.
>
> What OS are you running on?
>
> > I download the example from your site (
> > http://flac.cvs.sourceforge.net/viewvc/flac/flac/examples/).
>
> You cannot compile those examples without grabbing the whole FLAC
> source code tarball.
>
> > I tried to compile the program in C by using : automake Makefile.am and i
> > have the next message :
> > *`configure.ac' or `configure.in' is required*
>
> Why?
>
> Instructions for compiling the FLAC source code are contained
> in the file named README in the top level directory of the FLAC
> source code tarball.
>
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> ___
> flac-dev mailing list
> flac-dev@xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] Jenkins builds are failing

2012-04-04 Thread Erik de Castro Lopo 
Ralph,

Can you please check out whats happening here? See:

https://mf4.xiph.org/jenkins/job/flac/31/console

I've run the tests here without a problem.

Cheers,
Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] FLAC example compilation

2012-04-04 Thread Erik de Castro Lopo 
Rafael Velasquez wrote:

> Hello, i'm new with Flac and C.

What OS are you running on?

> I download the example from your site (
> http://flac.cvs.sourceforge.net/viewvc/flac/flac/examples/).

You cannot compile those examples without grabbing the whole FLAC
source code tarball.

> I tried to compile the program in C by using : automake Makefile.am and i
> have the next message :
> *`configure.ac' or `configure.in' is required*

Why?

Instructions for compiling the FLAC source code are contained
in the file named README in the top level directory of the FLAC
source code tarball.

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] FLAC example compilation

2012-04-04 Thread Rafael Velasquez 
Hello, i'm new with Flac and C.

I download the example from your site (
http://flac.cvs.sourceforge.net/viewvc/flac/flac/examples/).

I tried to compile the program in C by using : automake Makefile.am and i
have the next message :
*`configure.ac' or `configure.in' is required*

So i would like to know how to do for compile the program.

I tried to look in google, but i found no solution.

Best regards,

Rafael
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev