Re: [flac-dev] Commonly getting FLAC__STREAM_ENCODER_VERIFY_MISMATCH_IN_AUDIO_DATA on valid audio

2013-02-07 Thread Timothy B. Terriberry
Cristian Rodríguez wrote:
>> sample sets. Each set of samples returns this error at a different location 
>> in
>> the stream, but always the same location for the same file.
>>
>> or has many bytes that are close to the original. The bad frame's data is 
>> always
>> the same, no matter how many times I try to re-encode the original file.
>
> Before debugging further, ensure you can reproduce this in a different
> computer, or verify that you dont have broken RAM.

Given that the errors occur at repeatable locations, broken RAM seems 
unlikely.
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] Commonly getting FLAC__STREAM_ENCODER_VERIFY_MISMATCH_IN_AUDIO_DATA on valid audio

2013-02-07 Thread Cristian Rodríguez
El 07/02/13 19:07, Collin escribió:
> I'm using libflac on Windows to compress some audio samples. I'm building the
> library locally, using Visual Studio 2010. Each set of data is 2-5 MB and well
> formed PCM encoded data. I'm finding some very odd behavior.
>
> If I enable verify on the encode stream, I get a verify mismatch on most of my
> sample sets. Each set of samples returns this error at a different location in
> the stream, but always the same location for the same file.
>
> However, if I disable verify, the resulting FLAC encoded data DOES decode
> correctly in most cases, giving me an exact replica of the input.

Before debugging further, ensure you can reproduce this in a different 
computer, or verify that you dont have broken RAM.


___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] Commonly getting FLAC__STREAM_ENCODER_VERIFY_MISMATCH_IN_AUDIO_DATA on valid audio

2013-02-07 Thread Collin
I'm using libflac on Windows to compress some audio samples. I'm building the
library locally, using Visual Studio 2010. Each set of data is 2-5 MB and well
formed PCM encoded data. I'm finding some very odd behavior.

If I enable verify on the encode stream, I get a verify mismatch on most of my
sample sets. Each set of samples returns this error at a different location in
the stream, but always the same location for the same file.

However, if I disable verify, the resulting FLAC encoded data DOES decode
correctly in most cases, giving me an exact replica of the input.

In the other cases, one of the frames decodes into wrong data. I have not seen
more than one frame for a given set of data decode incorrectly; the frames
before and after it are correct. Sometimes the bad frame is partially correct,
or has many bytes that are close to the original. The bad frame's data is always
the same, no matter how many times I try to re-encode the original file.

I've tried encoding and decoding these files with the FLAC command line tool,
and it has no problems, so I think there might be an issue with my libflac 
binaries.

Has anyone encountered a similar problem, or are there any known issues that
could explain this?

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] [PATCH 4/4] Robustify autogen.sh

2013-02-07 Thread Timothy B. Terriberry
 >From 05343cb10947c378d8a7678d4cd3cc3f442b3290 Mon Sep 17 00:00:00 2001
From: "Timothy B. Terriberry" 
Date: Thu, 7 Feb 2013 12:33:03 -0800
Subject: [PATCH 4/4] Robustify autogen.sh

This allows the script to be run from somewhere other than the
 top-level build directory.
---
 autogen.sh | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/autogen.sh b/autogen.sh
index 1a9a020..ab52ab6 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -2,6 +2,13 @@
 # Run this to set up the build system: configure, makefiles, etc.
 # We trust that the user has a recent enough autoconf & automake setup
 # (not older than a few years...)
+set -e
+
+srcdir=`dirname $0`
+test -n "$srcdir" && cd "$srcdir"
+
+echo "Updating build configuration files for FLAC, please wait"
+
 touch config.rpath
-autoreconf -i
-#$srcdir/configure "$@" && echo
+autoreconf -isf
+#./configure "$@" && echo
-- 
1.7.12

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] [PATCH 3/4] xmms - Fix inline linking problems with old glib

2013-02-07 Thread Timothy B. Terriberry
 >From f392432e437c0ae7e3da2851e27ee3d997c3322c Mon Sep 17 00:00:00 2001
From: "Timothy B. Terriberry" 
Date: Thu, 7 Feb 2013 12:28:39 -0800
Subject: [PATCH 3/4] xmms - Fix inline linking problems with old glib

f0296255 switched to --std=c99 by default, but old glib relies on
 the pre-C99 extern inline rules.
Override G_INLINE_FUNC for it to avoid multiple definition linker
 errors.
---
 src/plugin_xmms/charset.c   | 4 +---
 src/plugin_xmms/configure.c | 4 +---
 src/plugin_xmms/fileinfo.c  | 4 +---
 src/plugin_xmms/http.c  | 5 +
 src/plugin_xmms/plugin.c| 4 +---
 src/plugin_xmms/plugin.h| 8 
 src/plugin_xmms/tag.c   | 4 +---
 7 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/src/plugin_xmms/charset.c b/src/plugin_xmms/charset.c
index d2d39e9..2c5167f 100644
--- a/src/plugin_xmms/charset.c
+++ b/src/plugin_xmms/charset.c
@@ -20,9 +20,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#if HAVE_CONFIG_H
-#  include 
-#endif
+#include "plugin.h"
 
 #include 
 #include 
diff --git a/src/plugin_xmms/configure.c b/src/plugin_xmms/configure.c
index af57f52..6b83435 100644
--- a/src/plugin_xmms/configure.c
+++ b/src/plugin_xmms/configure.c
@@ -21,9 +21,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#if HAVE_CONFIG_H
-#  include 
-#endif
+#include "plugin.h"
 
 #include 
 #include 
diff --git a/src/plugin_xmms/fileinfo.c b/src/plugin_xmms/fileinfo.c
index 392a128..e5e5fb1 100644
--- a/src/plugin_xmms/fileinfo.c
+++ b/src/plugin_xmms/fileinfo.c
@@ -18,9 +18,7 @@
  *  with this program; if not, write to the Free Software Foundation, Inc.,
  */
 
-#if HAVE_CONFIG_H
-#  include 
-#endif
+#include "plugin.h"
 
 #include 
 #include  /* for strlen() */
diff --git a/src/plugin_xmms/http.c b/src/plugin_xmms/http.c
index 44c9ce9..ce06447 100644
--- a/src/plugin_xmms/http.c
+++ b/src/plugin_xmms/http.c
@@ -17,9 +17,7 @@
  */
 /* modified for FLAC support by Steven Richman (2003) */
 
-#if HAVE_CONFIG_H
-#  include 
-#endif
+#include "plugin.h"
 
 #include 
 #include 
@@ -44,7 +42,6 @@
 #include "FLAC/format.h"
 #include "configure.h"
 #include "locale_hack.h"
-#include "plugin.h"
 
 /* on FreeBSD we get socklen_t from  */
 #if (!defined HAVE_SOCKLEN_T) && !defined(__FreeBSD__)
diff --git a/src/plugin_xmms/plugin.c b/src/plugin_xmms/plugin.c
index 32ad733..85147cf 100644
--- a/src/plugin_xmms/plugin.c
+++ b/src/plugin_xmms/plugin.c
@@ -16,9 +16,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#if HAVE_CONFIG_H
-#  include 
-#endif
+#include "plugin.h"
 
 #include 
 #include 
diff --git a/src/plugin_xmms/plugin.h b/src/plugin_xmms/plugin.h
index e17cb1c..858a874 100644
--- a/src/plugin_xmms/plugin.h
+++ b/src/plugin_xmms/plugin.h
@@ -19,6 +19,14 @@
 #ifndef FLAC__PLUGIN_XMMS__PLUGIN_H
 #define FLAC__PLUGIN_XMMS__PLUGIN_H
 
+#if HAVE_CONFIG_H
+#  include 
+#endif
+
+#if defined(__GNUC_STDC_INLINE__)
+#  define G_INLINE_FUNC extern inline __attribute__((gnu_inline))
+#endif
+
 void set_track_info(const char* title, int length_in_msec);
 
 #endif
diff --git a/src/plugin_xmms/tag.c b/src/plugin_xmms/tag.c
index 938cde8..3012d4d 100644
--- a/src/plugin_xmms/tag.c
+++ b/src/plugin_xmms/tag.c
@@ -19,9 +19,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#if HAVE_CONFIG_H
-#  include 
-#endif
+#include "plugin.h"
 
 #include 
 #include 
-- 
1.7.12

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] [PATCH 2/4] xmms - include inttypes.h for PRIu64

2013-02-07 Thread Timothy B. Terriberry
 >From b4dec97067239e547857fc13c4cd6903529baaef Mon Sep 17 00:00:00 2001
From: "Timothy B. Terriberry" 
Date: Thu, 7 Feb 2013 12:27:09 -0800
Subject: [PATCH 2/4] xmms - #include  for PRIu64

Not sure where this was coming from before, but it's not getting
 included elsewhere on my system, so include it explicitly.
---
 src/plugin_xmms/fileinfo.c | 1 +
 src/plugin_xmms/http.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/plugin_xmms/fileinfo.c b/src/plugin_xmms/fileinfo.c
index 4fe0fb1..392a128 100644
--- a/src/plugin_xmms/fileinfo.c
+++ b/src/plugin_xmms/fileinfo.c
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include "FLAC/metadata.h"
diff --git a/src/plugin_xmms/http.c b/src/plugin_xmms/http.c
index 5586ce2..44c9ce9 100644
--- a/src/plugin_xmms/http.c
+++ b/src/plugin_xmms/http.c
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
-- 
1.7.12

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] [PATCH 1/4] xmms - Fix libtool usage

2013-02-07 Thread Timothy B. Terriberry
 >From 9979edd1b6b6dd8c7c6bafaa68c9d974a8a77688 Mon Sep 17 00:00:00 2001
From: "Timothy B. Terriberry" 
Date: Thu, 7 Feb 2013 12:23:24 -0800
Subject: [PATCH 1/4] xmms - Fix libtool usage.

9b7cb22f removed the extra libtool-disable-static script in favor
 of always building with disable-static, but plugin_xmms still
 referenced libtool-disable-static explicitly.
---
 Makefile.am | 2 --
 src/plugin_xmms/Makefile.am | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 603c032..9b7bd04 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -32,8 +32,6 @@ ACLOCAL_AMFLAGS = -I m4
 
 SUBDIRS = doc include m4 man src examples test build objs
 
-DISTCLEANFILES = libtool-disable-static
-
 EXTRA_DIST = \
 	COPYING.FDL \
 	COPYING.GPL \
diff --git a/src/plugin_xmms/Makefile.am b/src/plugin_xmms/Makefile.am
index 29879ed..84c4106 100644
--- a/src/plugin_xmms/Makefile.am
+++ b/src/plugin_xmms/Makefile.am
@@ -38,9 +38,6 @@ else
 xmmsinputplugindir = @XMMS_INPUT_PLUGIN_DIR@
 endif
 
-# Don't build a static library
-LIBTOOL = $(top_builddir)/libtool-disable-static
-
 xmmsinputplugin_LTLIBRARIES = libxmms-flac.la
 
 plugin_sources = charset.c configure.c fileinfo.c http.c plugin.c tag.c
-- 
1.7.12

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev