Re: [flac-dev] flac 1.3.0pre2 pre-release

2013-03-18 Thread Jaren Stangret 
I'd also like to note that this is happening for me with current HEAD
(619b43df36b725e11e12db768d558b1930a583b6).


On Mon, Mar 18, 2013 at 11:25 PM, Jaren Stangret  wrote:

> I've been trying to get the test suite cleaned up and even with the
> original "untouched" test suite via flac 1.3.0pre2, I'm getting a test
> suite failure.
>
> *flac 1.3.0pre2*
> *
> *
> *configure options:*
> ./configure --prefix=/usr --build=i686-pc-linux-gnu
> --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info
> --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib
> --disable-dependency-tracking --enable-thorough-tests
> --enable-exhaustive-tests --disable-valgrind-testing --disable-static
> --disable-dependency-tracking --disable-debug --enable-sse --disable-3dnow
> --disable-altivec --disable-doxygen-docs --disable-xmms-plugin
> --enable-cpplibs --enable-ogg
>
> *make fullcheck:*
> This test fails with 'test_flac.sh':
>
> Testing --keep-foreign-metadata...
> round-trip test (wacky1.wav) encode... NOTE: --keep-foreign-metadata is a
> new feature; make sure to test the output file before deleting the original.
> decode... NOTE: --keep-foreign-metadata is a new feature; make sure to
> test the output file before deleting the original.
> compare... OK
> round-trip test (wacky2.wav) encode... NOTE: --keep-foreign-metadata is a
> new feature; make sure to test the output file before deleting the original.
> decode... NOTE: --keep-foreign-metadata is a new feature; make sure to
> test the output file before deleting the original.
> compare... OK
> round-trip test (wacky1.w64) encode... NOTE: --keep-foreign-metadata is a
> new feature; make sure to test the output file before deleting the original.
> decode... NOTE: --keep-foreign-metadata is a new feature; make sure to
> test the output file before deleting the original.
> compare... OK
> round-trip test (wacky2.w64) encode... NOTE: --keep-foreign-metadata is a
> new feature; make sure to test the output file before deleting the original.
> decode... NOTE: --keep-foreign-metadata is a new feature; make sure to
> test the output file before deleting the original.
> compare... OK
> round-trip test (wacky1.rf64) encode... NOTE: --keep-foreign-metadata is a
> new feature; make sure to test the output file before deleting the original.
> decode... NOTE: --keep-foreign-metadata is a new feature; make sure to
> test the output file before deleting the original.
> compare... OK
> round-trip test (wacky2.rf64) encode... NOTE: --keep-foreign-metadata is a
> new feature; make sure to test the output file before deleting the original.
> decode... NOTE: --keep-foreign-metadata is a new feature; make sure to
> test the output file before deleting the original.
> compare... OK
> Testing the metadata-handling properties of flac-to-flac encoding...
> case00a... Files case00a-expect.meta and out.meta differ
> ERROR: metadata does not match expected case00a-expect.meta
> make: *** [fullcheck] Error 1
>
> Anyone else hitting this or is just my system?
>
>
>
> On Thu, Mar 14, 2013 at 3:37 PM, Erik de Castro Lopo  > wrote:
>
>> Janne Hyvärinen wrote:
>>
>> >
>> > On 14.3.2013 9:37, Erik de Castro Lopo wrote:
>> > > Janne Hyvärinen wrote:
>> > >
>> > >> The patch was made from the published pre2 version. It missed the
>> MinGW
>> > >> changes that were applied to git version.
>> > > Patch applied. Thanks.
>> > >
>> > > Erik
>> >
>> > Unfortunately with this commit the LRN's patch from commit
>> > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch
>> > to bring its fixes back. Sorry I used old sources for the large patch.
>>
>> Applied, thanks!
>>
>> Erik
>> --
>> --
>> Erik de Castro Lopo
>> http://www.mega-nerd.com/
>> ___
>> flac-dev mailing list
>> flac-dev@xiph.org
>> http://lists.xiph.org/mailman/listinfo/flac-dev
>>
>
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] flac 1.3.0pre2 pre-release

2013-03-18 Thread Jaren Stangret 
I've been trying to get the test suite cleaned up and even with the
original "untouched" test suite via flac 1.3.0pre2, I'm getting a test
suite failure.

*flac 1.3.0pre2*
*
*
*configure options:*
./configure --prefix=/usr --build=i686-pc-linux-gnu
--host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info
--datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib
--disable-dependency-tracking --enable-thorough-tests
--enable-exhaustive-tests --disable-valgrind-testing --disable-static
--disable-dependency-tracking --disable-debug --enable-sse --disable-3dnow
--disable-altivec --disable-doxygen-docs --disable-xmms-plugin
--enable-cpplibs --enable-ogg

*make fullcheck:*
This test fails with 'test_flac.sh':

Testing --keep-foreign-metadata...
round-trip test (wacky1.wav) encode... NOTE: --keep-foreign-metadata is a
new feature; make sure to test the output file before deleting the original.
decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test
the output file before deleting the original.
compare... OK
round-trip test (wacky2.wav) encode... NOTE: --keep-foreign-metadata is a
new feature; make sure to test the output file before deleting the original.
decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test
the output file before deleting the original.
compare... OK
round-trip test (wacky1.w64) encode... NOTE: --keep-foreign-metadata is a
new feature; make sure to test the output file before deleting the original.
decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test
the output file before deleting the original.
compare... OK
round-trip test (wacky2.w64) encode... NOTE: --keep-foreign-metadata is a
new feature; make sure to test the output file before deleting the original.
decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test
the output file before deleting the original.
compare... OK
round-trip test (wacky1.rf64) encode... NOTE: --keep-foreign-metadata is a
new feature; make sure to test the output file before deleting the original.
decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test
the output file before deleting the original.
compare... OK
round-trip test (wacky2.rf64) encode... NOTE: --keep-foreign-metadata is a
new feature; make sure to test the output file before deleting the original.
decode... NOTE: --keep-foreign-metadata is a new feature; make sure to test
the output file before deleting the original.
compare... OK
Testing the metadata-handling properties of flac-to-flac encoding...
case00a... Files case00a-expect.meta and out.meta differ
ERROR: metadata does not match expected case00a-expect.meta
make: *** [fullcheck] Error 1

Anyone else hitting this or is just my system?



On Thu, Mar 14, 2013 at 3:37 PM, Erik de Castro Lopo
wrote:

> Janne Hyvärinen wrote:
>
> >
> > On 14.3.2013 9:37, Erik de Castro Lopo wrote:
> > > Janne Hyvärinen wrote:
> > >
> > >> The patch was made from the published pre2 version. It missed the
> MinGW
> > >> changes that were applied to git version.
> > > Patch applied. Thanks.
> > >
> > > Erik
> >
> > Unfortunately with this commit the LRN's patch from commit
> > b85cc57d73a286a07e544823cbeb41d3122b4e94 was overwritten. Here's a patch
> > to bring its fixes back. Sorry I used old sources for the large patch.
>
> Applied, thanks!
>
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> ___
> flac-dev mailing list
> flac-dev@xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
>
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread Janne Hyvärinen 

On 18.3.2013 15:17, JonY wrote:
> On 3/18/2013 19:34, LRN wrote:
>> On 18.03.2013 13:35, JonY wrote:
>>> Before anyone does anything, see __wgetmainargs
>>> .
>>> It can expand wildcards. Since it already provides argc/argv/env,
>>> it is more a less a drop-in replacement for the main() arguments.
>> I can't find its version info. MSDN only documents it as far as VS2010
>> (normal C functions are documented as far as VS2003), and it's not
>> present in any header file i have.
> I don't think it is, you probably required to declare it yourself.
>
> The symbol is in the MSVCRXX runtime dll, all the way from MSVCRT.dll to
> MSVC2012 MSVCR110. Suffice to say it is always there.
>

Seems you are correct. I just did some testing and the unicode version 
appears usable from ansi program too.

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Higher compression modes from Flake

2013-03-18 Thread rappard 
On 16 March 2013 09:25, Brian Willoughby  wrote:
>
> On Mar 14, 2013, at 13:24, Declan Kelly wrote:
>> I want the tightest possible compression, while remaining 100%
>> compatible with the subset that all known FLAC decoders can
>> successfully
>> stream or play now in cars, Hi-Fi units, "MP3 players" and cell
>> phones.
>> The out and out most widely supported lossless audio format could (and
>> should) have a better "bang for the buck" to the average user (who has
>> possibly been tempted away from MP3 or WMV or some Apple format).
>
> I have a vague recollection that going beyond -4 is incompatible with
> certain hardware players. Sorry I don't have a reference for this,
> but it seems like even -8 or --best are not 100% compatible with all
> decoders. Going beyond that to -9 or even -12 seems like it would be
> far less than 100% compatible.

I think you're referring to an old Squeezebox forum thread (now long
gone*) in which it was mentioned and consequently shown that anything
higher than the default of -5 could potentially run into playback
difficulties. Especially -8 was bad for some reason.

That said, I can't recall if a later firmware update solved the issue.
Also, are Squeezeboxes even being sold/manufactured anymore?

*: I thought the (now dead) link was mentioned somewhere on
Hydrogenaudio, but can't find it.

--Martin
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY 
On 3/18/2013 19:34, LRN wrote:
> On 18.03.2013 13:35, JonY wrote:
>> Before anyone does anything, see __wgetmainargs 
>> .
> 
>> It can expand wildcards. Since it already provides argc/argv/env,
>> it is more a less a drop-in replacement for the main() arguments.
> I can't find its version info. MSDN only documents it as far as VS2010
> (normal C functions are documented as far as VS2003), and it's not
> present in any header file i have.

I don't think it is, you probably required to declare it yourself.

The symbol is in the MSVCRXX runtime dll, all the way from MSVCRT.dll to
MSVC2012 MSVCR110. Suffice to say it is always there.





signature.asc
Description: OpenPGP digital signature
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread LRN 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 18.03.2013 13:35, JonY wrote:
> Before anyone does anything, see __wgetmainargs 
> .
> 
> It can expand wildcards. Since it already provides argc/argv/env,
> it is more a less a drop-in replacement for the main() arguments.
I can't find its version info. MSDN only documents it as far as VS2010
(normal C functions are documented as far as VS2003), and it's not
present in any header file i have.


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRRvvBAAoJEOs4Jb6SI2CwkX8IALcXD6FV5G8Mdg6G0ORajgbj
tveYgs7d7FUKZSB8zo9L4GmodfzqacnxYnAbl6G+5+6zMgb5MjBbJPV5Z5LvCFrI
OPk067seyK3ZY2YZuv6RFwOn3V0e4y1WnCa4h0eep1gkRuhIO5QXFeqtRVucys4E
U5Xcp61JcheAhIJf8dLvUn/C7DkZFTtrdoJnRxyzNSqQoOyGSb+aocIP/LADapFJ
QSqjSfXak4s6IGSro9lod9l6Au4/L1LxD6rS6JlNS+Yuy/tzJtsL6ANe4ULSFoVz
W8iZ9wMgHAK982GdyGJO76UmCe8p5N4KLUjPnOItLZDYvZxSHN/AkGY0xaK9388=
=cgor
-END PGP SIGNATURE-
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY 
On 3/18/2013 19:21, Janne Hyvärinen wrote:
> On 18.3.2013 11:35, JonY wrote:
>> Before anyone does anything, see __wgetmainargs
>> .
>>
>> It can expand wildcards. Since it already provides argc/argv/env, it is
>> more a less a drop-in replacement for the main() arguments.
> 
> MSVC also comes with
> http://msdn.microsoft.com/en-us/library/8bch7bkk%28v=vs.80%29.aspx. To
> support unicode with these methods would require somewhat more #ifdef
> code in main. We'd need to change project files to define Unicode
> character set and turn main into _wmain and char *argv to wchar_t *argv.
> Also these are MSVC's internal features, if I'm not mistaken. Other
> compilers on Windows would then require different solutions.
> 

For setargv.obj, it is equivalent to doing "int _dowildcard = 1;" in any
linked object on mingw.

For wmain, regular mingw does not support it, but mingw-w64 does. The
issue is that the former is far more common in the wild.

I still prefer the __wgetmainargs approach, the exact same code can be
used for both mingw and msvc. We don't need to care about 9x, I think.





signature.asc
Description: OpenPGP digital signature
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread Janne Hyvärinen 

On 18.3.2013 11:35, JonY wrote:

Before anyone does anything, see __wgetmainargs
.

It can expand wildcards. Since it already provides argc/argv/env, it is
more a less a drop-in replacement for the main() arguments.


MSVC also comes with 
http://msdn.microsoft.com/en-us/library/8bch7bkk%28v=vs.80%29.aspx. To 
support unicode with these methods would require somewhat more #ifdef 
code in main. We'd need to change project files to define Unicode 
character set and turn main into _wmain and char *argv to wchar_t *argv. 
Also these are MSVC's internal features, if I'm not mistaken. Other 
compilers on Windows would then require different solutions.


___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread Erik de Castro Lopo 
JonY wrote:

> Before anyone does anything, see __wgetmainargs
> .
> 
> It can expand wildcards. Since it already provides argc/argv/env, it is
> more a less a drop-in replacement for the main() arguments.

+1

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] flac-dev Digest, Vol 100, Issue 42

2013-03-18 Thread Marcus Johnson 
"Aren't Windows users accustomed to this feature being missing anyway?"

I use Mac mostly now, but when I used Windows, now and then I always
expected the wildcard to work, it just worked on most things so it was
actually a bit of a pain in the ass when it didn't.


On Mon, Mar 18, 2013 at 5:35 AM,  wrote:

> Send flac-dev mailing list submissions to
> flac-dev@xiph.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.xiph.org/mailman/listinfo/flac-dev
> or, via email, send a message with subject or body 'help' to
> flac-dev-requ...@xiph.org
>
> You can reach the person managing the list at
> flac-dev-ow...@xiph.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of flac-dev digest..."
>
> Today's Topics:
>
>1. Re: MSVC project updates (Erik de Castro Lopo)
>2. Re: Patch to add Unicode filename support for win32 flac (JonY)
>3. Re: Patch to add Unicode filename support for win32 flac
>   (Erik de Castro Lopo)
>4. Re: Patch to add Unicode filename support for win32 flac (LRN)
>5. Re: Patch to add Unicode filename support for win32 flac (LRN)
>6. Re: Patch to add Unicode filename support for win32 flac
>   (Brian Willoughby)
>7. Re: Patch to add Unicode filename support for win32 flac
>   (Erik de Castro Lopo)
>8. Re: Patch to add Unicode filename support for win32 flac (JonY)
>
>
> -- Forwarded message --
> From: Erik de Castro Lopo 
> To: flac-dev@xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 06:29:22 +1100
> Subject: Re: [flac-dev] MSVC project updates
> Janne Hyvärinen wrote:
>
> > One more set of MSVC project updates. Changed ogg_static.lib to
> > libogg_static.lib as that's the name latest version uses. Removed MSVC
> > 6.0 related parts from README and tweaked info there to be more
> > up-to-date. Also changed nasmw.exe into nasm.exe as nasmw.exe has been
> > long gone.
> > LibFLAC_dynamic was complaining in debug mode about conflicts with
> > libcmt, I excluded it from the project there as I saw no other way to
> > solve the problem.
>
> Applied. Thanks.
>
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
>
>
>
> -- Forwarded message --
> From: JonY <10wa...@gmail.com>
> To: flac-dev@xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 06:10:44 +0800
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> On 3/17/2013 23:01, LRN wrote:
> >> All those ifdefs will at least be confined rather than spread out
> >> through the code.
> > I did it plibc-style:
> >
> > in compat.h:
> > #if defined(_WIN32)
> > #define FOPEN grabbag__fopen_utf8_wrapper
> > #else
> > #define FOPEN fopen
> > #endif
> >
> > in grabbag:
> > #if defined(_WIN32)
> >  > as fopen, but does utf8->utf16 conversion internally, then calls wfopen>
> > #endif
> >
> > and replace "fopen" with "FOPEN" everywhere else.
>
> Don't do that, it leaks into the system headers and breaks mingw if
> FLAC_USE_FOPEN_UTF8 is defined.
>
> Call the wrappers directly instead of using a macro.
>
>
>
> -- Forwarded message --
> From: Erik de Castro Lopo 
> To: flac-dev@xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 09:37:56 +1100
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> JonY wrote:
>
> > On 3/17/2013 23:01, LRN wrote:
> > >> All those ifdefs will at least be confined rather than spread out
> > >> through the code.
> > > I did it plibc-style:
> > >
> > > in compat.h:
> > > #if defined(_WIN32)
> > > #define FOPEN grabbag__fopen_utf8_wrapper
> > > #else
> > > #define FOPEN fopen
> > > #endif
> > >
> > > in grabbag:
> > > #if defined(_WIN32)
> > >  > > as fopen, but does utf8->utf16 conversion internally, then calls
> wfopen>
> > > #endif
> > >
> > > and replace "fopen" with "FOPEN" everywhere else.
> >
> > Don't do that, it leaks into the system headers and breaks mingw if
> > FLAC_USE_FOPEN_UTF8 is defined.
> >
> > Call the wrappers directly instead of using a macro.
>
> +1
>
> Yep, I prefer not to have too much #ifdef hackery.
>
> In my recent replacement of all the sprintf/_snprintf stuff, I relaced all
> the
> calls with a call to flac_snprintf() and localised #ifdef hackery to the
> implementation of that function.
>
> >From a patch cleanliness POV, I like to see the new functionality added in
> one patch and a separate patch to change all the old function usage to the
> new function usage. For example, in commit 06af237c I added the new
> flac_snprintf() function and in commit 3c84f9e8 I replaced all the old
> calls to sprintf/_snprintf.
>
> Cheers,
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
>
>
>
> -- Forwarded message --
> From: LRN 
> To: flac-dev@xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 05:55:07 +0400
> Subject: Re: [flac-dev] P

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY 
On 3/18/2013 09:55, LRN wrote:
> On 18.03.2013 02:10, JonY wrote:
>> On 3/17/2013 23:01, LRN wrote:
 All those ifdefs will at least be confined rather than spread
 out through the code.
>>> I did it plibc-style:
>>>
>>> in compat.h: #if defined(_WIN32) #define FOPEN
>>> grabbag__fopen_utf8_wrapper #else #define FOPEN fopen #endif
>>>
>>> in grabbag: #if defined(_WIN32) >> grabbag__fopen_utf8_wrapper, which has the same signature as
>>> fopen, but does utf8->utf16 conversion internally, then calls
>>> wfopen> #endif
>>>
>>> and replace "fopen" with "FOPEN" everywhere else.
> 
>> Don't do that, it leaks into the system headers
> How? compat.h is not a public header, it is only used internally in
> FLAC. And i don't think that system headers have defines for "FOPEN"
> and such.
> 

Preprocessor macros are not scoped. Even if FOPEN may not, but future
compat code that follow this pattern might easily bump into unrelated
identifiers. utime_uft8 already did some amount of damage.




signature.asc
Description: OpenPGP digital signature
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY 
On 3/18/2013 14:55, Erik de Castro Lopo wrote:
> Brian Willoughby wrote:
> 
>> I believe that shell does handle wildcards on all Unix variants,  
>> including OSX.
> 
> Yes.
> 
>> Since Windows does not handle them, I suggest that the  
>> main flac code not be littered with code that's not necessary on the  
>> primary platforms.
> 
> No, the flac code will not be "littered with code that's not necessary
> on the primary platforms".
> 
> There will be some windows specific code in a new file, a bunch of
> replacements of existing fopen() calls with flac_fopen() (similarly
> for chmod and utime) and the main function for the flac and metaflac
> executables will have an additional:
> 
> #ifdef _WIN32
>   if (!convert_argv_to_utf8(&argc, &argv))
>   flac__utils_printf(stderr, 1, "ERROR: yada yada\n");
> #endif
> 
> This is a small un-obtrusive change that I fully support.
> 
> I would however like to see it sooner rather than later so we can get
> this damn thing released :-).
> 

Before anyone does anything, see __wgetmainargs
.

It can expand wildcards. Since it already provides argc/argv/env, it is
more a less a drop-in replacement for the main() arguments.




signature.asc
Description: OpenPGP digital signature
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev