Re: [flac-dev] [PATCH] fix getopt.c
lvqcl wrote: > This patch fixes 2 problems in getopt.c: > > 1) MSVC 2005 (and probably 2008) can't compile it because > it doesn't have stdint.h > > 2) nameend and nextchar are pointers and the difference > between them should be casted to 'size_t' type, not > 'unsigned int' or 'uint32_t'. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] How is the MD5 hash calculated?
Marcus Johnson wrote: > is it on a per subframe basis, and if so, is each frame padded if > it’s not a multiple of 512 bits? or do I have to decode all the data, > and run it over the decoded file at once? Documentation is here: https://xiph.org/flac/documentation_format_overview.html MD5SUM is of the un-encoded audio data and of the whole stream. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] MSVC 2005/2008 can't compile libFLAC
These versions of Visual Studio don't have stdint.h and all [u]intNN_t types. But now these types are everywhere in FLAC codebase. An easy fix would be to move definitions of these types from share/compat.h into FLAC/ordinals.h (see attached patch). But it may break some 3rd party programs that include (directly or indirectly) this file and also have their own typedefs for these types. (Also, currently FLAC/ordinals.h contains some nonsense like "typedef uint32_t __int32 FLAC__uint32;", but that's not a real problem) So, what to do? 1) include share/compat.h where needed (but it's too big, and even indirectly includes ). 2) create a new file compat_stdint.h or compat_inttypes.h that has only necessary definitions and include it. 3) apply the attached patch and hope that it has the most compatible definitions for these types. 4) drop MSVC 2005/2008 support. 5) revert some changes of integer types to [u]intNN_t. ordinals_fix.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] [PATCH] fix getopt.c
This patch fixes 2 problems in getopt.c: 1) MSVC 2005 (and probably 2008) can't compile it because it doesn't have stdint.h 2) nameend and nextchar are pointers and the difference between them should be casted to 'size_t' type, not 'unsigned int' or 'uint32_t'. getopt_fix.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
