Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)
Cristian Rodríguez wrote: The following changes since commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255: FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc specific optimizations (2012-03-28 15:43:48 -0300) are available in the git repository at: git://github.com/crrodriguez/flac.git master for you to fetch changes up to 3a060556772c5d6a6464afddfda7c3ad2f93a306: Hi Cristian, Thanks for your interest in improving FLAC. I will address your patches one-by-one. * b78d8e4db1.. FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc… +1. You sent me this patch in a private email and I was in the process of commiting a slightly modified version. * 7077ba8be2.. Use a single source-code wide definition of min() and max() I like the idea of this commit but don't understand why it modifies configure.ac. I also don't think the FLAC_SAFE_MIN/MAX defintions belong in the file include/FLAC/export.h which is a public header file. Instead, this definition belongs in one of the private/internal header files. * 8f05d0114c.. Support symbol visibility features present in GCC 4 Again I like the idea of this patch, but I had in mind a solution to this problem which will work for a number of compilers other than just GCC. * f2b0d3f6c9.. Remove xmms plugin. I polled the list earlier this year and on the basis of one of the Xiph developers still using this code and being willing to maintain it, we decided to keep it. * 3a06055677.. Remove winamp2 plugin. This one I fully endorse, but is unlikely to apply without the patches above being applied first. I'll apply a version of this patch. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)
El 30/03/12 07:14, Erik de Castro Lopo escribió: * 7077ba8be2.. Use a single source-code wide definition of min() and max() I like the idea of this commit but don't understand why it modifies configure.ac. I also don't think the FLAC_SAFE_MIN/MAX defintions belong in the file include/FLAC/export.h which is a public header file. Instead, this definition belongs in one of the private/internal header files. Yes, I didnt find the right header ;) * 8f05d0114c.. Support symbol visibility features present in GCC 4 Again I like the idea of this patch, but I had in mind a solution to this problem which will work for a number of compilers other than just GCC. The current version will work with clang, icc and gcc those define __GNUC__ and accept the -fvisibility-hidden flag ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)
Cristian Rodríguez wrote: * 8f05d0114c.. Support symbol visibility features present in GCC 4 Again I like the idea of this patch, but I had in mind a solution to this problem which will work for a number of compilers other than just GCC. The current version will work with clang, icc and gcc those define __GNUC__ and accept the -fvisibility-hidden flag It doesn't work for the Microsoft compilers (ie VS). My solution does :-). Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)
El 30/03/12 07:14, Erik de Castro Lopo escribió: Cristian Rodríguez wrote: The following changes since commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255: FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc specific optimizations (2012-03-28 15:43:48 -0300) are available in the git repository at: git://github.com/crrodriguez/flac.git master for you to fetch changes up to 3a060556772c5d6a6464afddfda7c3ad2f93a306: Hi Cristian, Thanks for your interest in improving FLAC. I will address your patches one-by-one. * b78d8e4db1.. FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc… +1. You sent me this patch in a private email and I was in the process of commiting a slightly modified version. there is a tiny problem there. the preprocessor check for __builtin_clz #if defined(__GNUC__) ((__GNUC__ == 3 __GNUC_MINOR__ = 4) || __GNUC__ = 4) So it compiles on very old systems... ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)
The following changes since commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255: FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc specific optimizations (2012-03-28 15:43:48 -0300) are available in the git repository at: git://github.com/crrodriguez/flac.git master for you to fetch changes up to 3a060556772c5d6a6464afddfda7c3ad2f93a306: Remove winamp2 plugin. (2012-03-29 13:51:24 -0300) Cristian Rodríguez (4): Use a single source-code wide definition of min() and max() Support symbol visibility features present in GCC 4 Remove xmms plugin. (project abandoned in 2007) Remove winamp2 plugin(native flac support is in winamp 5.3 6yr/old configure.ac | 89 +-- include/FLAC++/export.h|7 +- include/FLAC/export.h | 26 +- m4/visibility.m4 | 77 ++ src/Makefile.am|6 - src/flac/Makefile.am |2 +- src/flac/encode.c | 29 +- src/flac/foreign_metadata.c|7 +- src/libFLAC++/Makefile.am |3 +- src/libFLAC++/metadata.cpp |4 + src/libFLAC++/stream_decoder.cpp |4 + src/libFLAC++/stream_encoder.cpp |4 + src/libFLAC/Makefile.am|6 +- src/libFLAC/bitreader.c| 13 +- src/libFLAC/bitwriter.c| 11 +- src/libFLAC/fixed.c| 16 +- src/libFLAC/lpc.c | 16 +- src/libFLAC/metadata_iterators.c | 15 +- src/libFLAC/ogg_decoder_aspect.c |7 +- src/libFLAC/stream_decoder.c |7 +- src/libFLAC/stream_encoder.c | 48 +- src/libFLAC/stream_encoder_framing.c |5 - src/metaflac/Makefile.am |2 +- src/plugin_common/Makefile.am | 48 -- src/plugin_common/Makefile.lite| 36 - src/plugin_common/README |2 - src/plugin_common/all.h| 26 - src/plugin_common/charset.c| 157 src/plugin_common/charset.h| 39 - src/plugin_common/defs.h | 24 - src/plugin_common/dither.c | 262 --- src/plugin_common/dither.h | 29 - src/plugin_common/plugin_common_static.dsp | 128 src/plugin_common/plugin_common_static.vcproj | 209 -- src/plugin_common/replaygain.c | 64 -- src/plugin_common/replaygain.h | 32 - src/plugin_common/tags.c | 358 - src/plugin_common/tags.h | 74 -- src/plugin_winamp2/Makefile.am | 33 - src/plugin_winamp2/configure.c | 428 --- src/plugin_winamp2/configure.h | 49 -- src/plugin_winamp2/in_flac.c | 443 src/plugin_winamp2/in_flac.dsp | 154 src/plugin_winamp2/in_flac.vcproj | 253 --- src/plugin_winamp2/include/Makefile.am | 18 - src/plugin_winamp2/include/winamp2/Makefile.am | 20 - src/plugin_winamp2/include/winamp2/in2.h | 107 --- src/plugin_winamp2/include/winamp2/out.h | 55 -- src/plugin_winamp2/infobox.c | 459 src/plugin_winamp2/infobox.h | 28 - src/plugin_winamp2/playback.c | 307 src/plugin_winamp2/playback.h | 92 --- src/plugin_winamp2/resource.h | 47 -- src/plugin_winamp2/resource.rc | 236 -- src/plugin_winamp2/tagz.cpp| 921 src/plugin_winamp2/tagz.h | 32 - src/plugin_xmms/Makefile.am| 70 -- src/plugin_xmms/Makefile.lite | 43 -- src/plugin_xmms/charset.c | 198 - src/plugin_xmms/charset.h | 56 -- src/plugin_xmms/configure.c| 823 - src/plugin_xmms/configure.h| 77 -- src/plugin_xmms/fileinfo.c | 492 - src/plugin_xmms/http.c | 899 --- src/plugin_xmms/http.h | 26 - src/plugin_xmms/locale_hack.h | 55 -- src/plugin_xmms/plugin.c | 684 -- src/plugin_xmms/plugin.h | 24 - src/plugin_xmms/tag.c | 154
Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)
El 29/03/12 14:32, Cristian Rodríguez escribió: The following changes since commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255: FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc specific optimizations (2012-03-28 15:43:48 -0300) are available in the git repository at: git://github.com/crrodriguez/flac.git master for you to fetch changes up to 3a060556772c5d6a6464afddfda7c3ad2f93a306: Remove winamp2 plugin. (2012-03-29 13:51:24 -0300) Cristian Rodríguez (4): Use a single source-code wide definition of min() and max() Support symbol visibility features present in GCC 4 Remove xmms plugin. (project abandoned in 2007) Remove winamp2 plugin(native flac support is in winamp 5.3 6yr/old Please pull from commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255 including that particular commit , I made a mistake in the since field. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
